From: Finn Thain <fthain@telegraphics.com.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
<linuxppc-dev@lists.ozlabs.org>, <linux-m68k@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 03/11] macintosh/via-pmu: Don't clear shift register interrupt flag twice
Date: Fri, 1 Jun 2018 23:27:51 -0400 (EDT) [thread overview]
Message-ID: <8597ac466215f573d8bea40e74fdec2bf72fabbb.1527909627.git.fthain@telegraphics.com.au> (raw)
In-Reply-To: <7ce9a8c3996506ae6f9ab16b3cf73c287e205a89.1527909627.git.fthain@telegraphics.com.au>
Clearing the interrupt flag twice in succession creates a theoretical
race condition. Fix this.
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/macintosh/via-pmu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 9c94f99e80da..087c3aa5233a 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -1458,7 +1458,6 @@ pmu_sr_intr(void)
if (in_8(&via[B]) & TREQ) {
printk(KERN_ERR "PMU: spurious SR intr (%x)\n", in_8(&via[B]));
- out_8(&via[IFR], SR_INT);
return NULL;
}
/* The ack may not yet be low when we get the interrupt */
--
2.16.1
WARNING: multiple messages have this Message-ID (diff)
From: Finn Thain <fthain@telegraphics.com.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
<linuxppc-dev@lists.ozlabs.org>,
<linux-m68k@lists.linux-m68k.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 03/11] macintosh/via-pmu: Don't clear shift register interrupt flag twice
Date: Fri, 1 Jun 2018 23:27:51 -0400 (EDT) [thread overview]
Message-ID: <8597ac466215f573d8bea40e74fdec2bf72fabbb.1527909627.git.fthain@telegraphics.com.au> (raw)
In-Reply-To: <7ce9a8c3996506ae6f9ab16b3cf73c287e205a89.1527909627.git.fthain@telegraphics.com.au>
Clearing the interrupt flag twice in succession creates a theoretical
race condition. Fix this.
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/macintosh/via-pmu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 9c94f99e80da..087c3aa5233a 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -1458,7 +1458,6 @@ pmu_sr_intr(void)
if (in_8(&via[B]) & TREQ) {
printk(KERN_ERR "PMU: spurious SR intr (%x)\n", in_8(&via[B]));
- out_8(&via[IFR], SR_INT);
return NULL;
}
/* The ack may not yet be low when we get the interrupt */
--
2.16.1
next prev parent reply other threads:[~2018-06-02 3:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 3:27 [PATCH 00/11] macintosh: Resolve various PMU driver problems Finn Thain
2018-06-02 3:27 ` Finn Thain
2018-06-02 3:27 ` [PATCH 01/11] macintosh/via-pmu: Fix section mismatch warning Finn Thain
2018-06-02 3:27 ` Finn Thain
2018-06-02 3:27 ` [PATCH 02/11] macintosh/via-pmu: Add missing mmio accessors Finn Thain
2018-06-02 3:27 ` Finn Thain
2018-06-02 3:27 ` Finn Thain [this message]
2018-06-02 3:27 ` [PATCH 03/11] macintosh/via-pmu: Don't clear shift register interrupt flag twice Finn Thain
2018-06-02 3:27 ` [PATCH 04/11] macintosh/via-pmu: Enhance state machine with new 'uninitialized' state Finn Thain
2018-06-02 3:27 ` Finn Thain
2018-06-02 3:27 ` [PATCH 05/11] macintosh/via-pmu: Replace via pointer with via1 and via2 pointers Finn Thain
2018-06-02 3:27 ` Finn Thain
2018-06-02 3:27 ` [PATCH 06/11] macintosh/via-pmu: Add support for m68k PowerBooks Finn Thain
2018-06-02 3:27 ` Finn Thain
2018-06-02 3:27 ` [PATCH 07/11] macintosh/via-pmu: Make CONFIG_PPC_PMAC Kconfig deps explicit Finn Thain
2018-06-02 3:27 ` Finn Thain
2018-06-02 3:27 ` [PATCH 08/11] macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver Finn Thain
2018-06-02 3:27 ` Finn Thain
2018-06-02 3:27 ` [PATCH 09/11] macintosh: Use common code to access RTC Finn Thain
2018-06-02 3:27 ` Finn Thain
2018-06-02 3:27 ` [PATCH 10/11] macintosh/via-pmu: Clean up interrupt statistics Finn Thain
2018-06-02 3:27 ` Finn Thain
2018-06-02 3:27 ` [PATCH 11/11] macintosh/via-pmu: Disambiguate " Finn Thain
2018-06-02 3:27 ` Finn Thain
2018-06-04 12:00 ` [PATCH 10/11] macintosh/via-pmu: Clean up " Geert Uytterhoeven
2018-06-04 12:00 ` Geert Uytterhoeven
2018-06-04 11:55 ` [PATCH 08/11] macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver Geert Uytterhoeven
2018-06-04 11:55 ` Geert Uytterhoeven
2018-06-06 6:57 ` Finn Thain
2018-06-06 7:15 ` Geert Uytterhoeven
2018-06-07 5:29 ` Finn Thain
2018-06-04 11:48 ` [PATCH 03/11] macintosh/via-pmu: Don't clear shift register interrupt flag twice Geert Uytterhoeven
2018-06-04 11:48 ` Geert Uytterhoeven
2018-06-04 11:46 ` [PATCH 02/11] macintosh/via-pmu: Add missing mmio accessors Geert Uytterhoeven
2018-06-04 11:46 ` Geert Uytterhoeven
2018-06-04 11:44 ` [PATCH 01/11] macintosh/via-pmu: Fix section mismatch warning Geert Uytterhoeven
2018-06-04 11:44 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8597ac466215f573d8bea40e74fdec2bf72fabbb.1527909627.git.fthain@telegraphics.com.au \
--to=fthain@telegraphics.com.au \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.