Re: [PATCH stable 3.9 to 3.16] staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write()

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

On Mon, 2018-11-12 at 11:56 +0000, Ian Abbott wrote:
> On 09/11/18 23:44, Ben Hutchings wrote:
> > On Tue, 2018-07-10 at 18:02 +0100, Ian Abbott wrote:
> > > From: Dan Carpenter <dan.carpenter@oracle.com>
> > > 
> > > [ Upstream commit 1376b0a2160319125c3a2822e8c09bd283cd8141 ]
> > > 
> > > There is a '>' vs '<' typo so this loop is a no-op.
> > 
> > Thanks, but this driver seems to have lots of other bugs in 3.16, like
> > it only ever accesses data[0] in this loop.  I don't think there's much
> > point in applying just this one.  But if you think it's worth fixing
> > then I can apply all the necessary fixes.
> > 
> > Ben.
> 
> It restores some basic functionality for daqp_ao_insn_write() that was 
> broken.  The most common case to be handled is insn->n == 1, as that is 
> what the comedi_data_write() function in the user-space Comedilib 
> library sets.
> 
> However, it may be worth applying e024181b02ed ("staging: comedi: 
> quatech_daqp_cs: fix bug in daqp_ao_insn_write()") and (with a small 
> amount of backporting) e031642eccc0 ("staging: comedi: quatech_daqp_cs: 
> use comedi_timeout() in ao (*insn_write)") before this one.  I'll append 
> a patch series as replies to this email.

I've queued these up for the next update, thanks.

Ben.

-- 
Ben Hutchings
Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]