* [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests @ 2020-08-25 20:05 Juha-Pekka Heikkila 2020-08-25 20:38 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork ` (3 more replies) 0 siblings, 4 replies; 6+ messages in thread From: Juha-Pekka Heikkila @ 2020-08-25 20:05 UTC (permalink / raw) To: igt-dev attempt to cause cdclk changes and stress scalers with flipping to different size fb with different modifiers. Verify results with crc. Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> --- tests/kms_flip.c | 155 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 155 insertions(+) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index b33cfe9ca..5f906f5f0 100755 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -1605,6 +1605,155 @@ static void test_nonblocking_read(int in) close(fd); } +const struct { + const char *name; + const char *describe; + uint64_t firstmodifier; + uint32_t firstformat; + uint64_t secondmodifier; + uint32_t secondformat; +} special_flip_scenario_test[] = { + { + "flip-32bpp-ytile-to-64bpp-ytile", + "Try to flip from 32bpp non scaled fb to 64bpp downscaled fb in attempt to stress cdclk reprogramming.", + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB16161616F + }, + { + "flip-32bpp-ytile-to-32bpp-ytilegen12rcccs", + "Try to flip from 32bpp non scaled fb to 32bpp downscaled gen12 rc ccs fb in attempt to stress cdclk reprogramming.", + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, + LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS, DRM_FORMAT_XRGB8888 + }, + { + "flip-32bpp-ytile-to-32bpp-ytileccs", + "Try to flip from 32bpp non scaled ytiled fb to 32bpp downscaled ytiled ccs fb.", + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, + LOCAL_I915_FORMAT_MOD_Y_TILED_CCS, DRM_FORMAT_XRGB8888 + }, + { + "flip-64bpp-ytile-to-32bpp-ytileccs", + "Try to flip from 64bpp non scaled ytiled fb to 32bpp downscaled gen12 rc ccs fb.", + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, + LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS, DRM_FORMAT_XRGB8888 + }, +}; + +static void test_flip_to_scaled(uint32_t index) +{ + uint32_t screenwidth, screenheight; + uint32_t bigfbwidth, bigfbheight; + uint32_t pipe = 0; //lets just run on first output, first pipe + uint64_t smallmodifier = special_flip_scenario_test[index].firstmodifier; + uint64_t bigmodifier = special_flip_scenario_test[index].secondmodifier; + uint32_t smallformat = special_flip_scenario_test[index].firstformat; + uint32_t bigformat = special_flip_scenario_test[index].secondformat; + uint32_t gen; + + igt_display_t display; + igt_output_t *output; + igt_plane_t *primary; + igt_pipe_crc_t *pipe_crc; + igt_crc_t small_crc, big_crc; + struct igt_fb small_fb, big_fb; + + struct drm_mode_fb_cmd2 f = {0}; + drmModeModeInfo *mode; + struct drm_event_vblank ev; + + cairo_t *cr; + + // this is Intel only test so bail out early. + igt_require_intel(drm_fd); + gen = intel_gen(intel_get_drm_devid(drm_fd)); + + // will be using scalers hence gen need to be >= 9 + igt_require(gen >= 9); + igt_require_pipe_crc(drm_fd); + igt_display_require(&display, drm_fd); + igt_require(display.is_atomic); + igt_require(igt_display_has_format_mod(&display, smallformat, smallmodifier)); + igt_require(igt_display_has_format_mod(&display, bigformat, bigmodifier)); + + for_each_connected_output(&display, output) { + mode = igt_output_get_mode(output); + screenwidth = min(mode->hdisplay, 1920); + screenheight = min(mode->vdisplay, 1080); + + // big fb will be 4k unless running on older than ICL + if (gen < 11) { + bigfbwidth = 2560; + bigfbheight = 1440; + } else { + bigfbwidth = 3840; + bigfbheight = 2160; + } + + igt_require(igt_create_color_fb(drm_fd, screenwidth, screenheight, + smallformat, smallmodifier, + 0, 1, 0, &small_fb)); + + igt_create_bo_for_fb(drm_fd, bigfbwidth, bigfbheight, bigformat, + bigmodifier, &big_fb); + igt_assert(big_fb.gem_handle > 0); + + f.width = big_fb.width; + f.height = big_fb.height; + f.pixel_format = big_fb.drm_format; + f.flags = LOCAL_DRM_MODE_FB_MODIFIERS; + + for (int n = 0; n < big_fb.num_planes; n++) { + f.handles[n] = big_fb.gem_handle; + f.modifier[n] = big_fb.modifier; + f.pitches[n] = big_fb.strides[n]; + f.offsets[n] = big_fb.offsets[n]; + } + + cr = igt_get_cairo_ctx(drm_fd, &big_fb); + igt_paint_color(cr, 0, 0, bigfbwidth, bigfbheight, 0, 1, 0); + igt_put_cairo_ctx(cr); + + igt_assert(drmIoctl(drm_fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) == 0); + big_fb.fb_id = f.fb_id; + + igt_output_set_pipe(output, pipe); + + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + igt_plane_set_fb(primary, NULL); + + igt_display_commit_atomic(&display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL); + pipe_crc = igt_pipe_crc_new(drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO); + igt_pipe_crc_start(pipe_crc); + + igt_plane_set_position(primary, 0, 0); + igt_plane_set_fb(primary, &small_fb); + igt_plane_set_size(primary, screenwidth, screenheight); + + igt_display_commit_atomic(&display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL); + igt_pipe_crc_collect_crc(pipe_crc, &small_crc); + + igt_plane_set_fb(primary, &big_fb); + igt_plane_set_size(primary, screenwidth, screenheight); + igt_display_commit_atomic(&display, DRM_MODE_ATOMIC_ALLOW_MODESET | + DRM_MODE_PAGE_FLIP_EVENT, NULL); + + igt_assert(read(drm_fd, &ev, sizeof(ev)) == sizeof(ev)); + + igt_pipe_crc_collect_crc(pipe_crc, &big_crc); + + igt_pipe_crc_stop(pipe_crc); + igt_pipe_crc_free(pipe_crc); + igt_remove_fb(drm_fd, &small_fb); + igt_remove_fb(drm_fd, &big_fb); + igt_output_set_pipe(output, PIPE_ANY); + + igt_assert(igt_check_crc_equal(&small_crc, &big_crc)); + + // run just on first found connected output. + break; + } +} + igt_main { struct { @@ -1720,4 +1869,10 @@ igt_main run_pair(tests[i].duration, tests[i].flags); } igt_stop_signal_helper(); + + for (int index = 0; index < ARRAY_SIZE(special_flip_scenario_test); index++) { + igt_describe(special_flip_scenario_test[index].describe); + igt_subtest(special_flip_scenario_test[index].name) + test_flip_to_scaled(index); + } } -- 2.28.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_flip: add flip to downscaled subtests 2020-08-25 20:05 [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests Juha-Pekka Heikkila @ 2020-08-25 20:38 ` Patchwork 2020-08-26 4:44 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: add flip to downscaled subtests (rev2) Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-08-25 20:38 UTC (permalink / raw) To: Juha-Pekka Heikkila; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 6249 bytes --] == Series Details == Series: tests/kms_flip: add flip to downscaled subtests URL : https://patchwork.freedesktop.org/series/80996/ State : failure == Summary == CI Bug Log - changes from IGT_5771 -> IGTPW_4905 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_4905 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_4905, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_4905: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_parallel@engines@fds: - fi-cml-s: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5771/fi-cml-s/igt@gem_exec_parallel@engines@fds.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/fi-cml-s/igt@gem_exec_parallel@engines@fds.html * igt@runner@aborted: - fi-kbl-7500u: NOTRUN -> [FAIL][3] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/fi-kbl-7500u/igt@runner@aborted.html Known issues ------------ Here are the changes found in IGTPW_4905 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_pm_rpm@basic-pci-d3-state: - fi-bsw-kefka: [PASS][4] -> [DMESG-WARN][5] ([i915#1982]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5771/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1: - fi-icl-u2: [PASS][6] -> [DMESG-WARN][7] ([i915#1982]) +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5771/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html #### Possible fixes #### * igt@gem_exec_store@basic: - fi-tgl-u2: [TIMEOUT][8] -> [PASS][9] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5771/fi-tgl-u2/igt@gem_exec_store@basic.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/fi-tgl-u2/igt@gem_exec_store@basic.html * igt@i915_module_load@reload: - fi-byt-j1900: [DMESG-WARN][10] ([i915#1982]) -> [PASS][11] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5771/fi-byt-j1900/igt@i915_module_load@reload.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/fi-byt-j1900/igt@i915_module_load@reload.html - fi-bxt-dsi: [TIMEOUT][12] ([i915#1418] / [i915#1635]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5771/fi-bxt-dsi/igt@i915_module_load@reload.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/fi-bxt-dsi/igt@i915_module_load@reload.html * igt@i915_pm_rpm@module-reload: - fi-bxt-dsi: [SKIP][14] ([fdo#109271] / [i915#1635]) -> [PASS][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5771/fi-bxt-dsi/igt@i915_pm_rpm@module-reload.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/fi-bxt-dsi/igt@i915_pm_rpm@module-reload.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-bsw-kefka: [DMESG-WARN][16] ([i915#1982]) -> [PASS][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5771/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html #### Warnings #### * igt@gem_exec_suspend@basic-s3: - fi-kbl-x1275: [DMESG-WARN][18] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][19] ([i915#62] / [i915#92]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5771/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html * igt@kms_force_connector_basic@force-connector-state: - fi-kbl-x1275: [DMESG-WARN][20] ([i915#62] / [i915#92]) -> [DMESG-WARN][21] ([i915#62] / [i915#92] / [i915#95]) +5 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5771/fi-kbl-x1275/igt@kms_force_connector_basic@force-connector-state.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/fi-kbl-x1275/igt@kms_force_connector_basic@force-connector-state.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1418]: https://gitlab.freedesktop.org/drm/intel/issues/1418 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (37 -> 34) ------------------------------ Missing (3): fi-byt-clapper fi-byt-squawks fi-bsw-cyan Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5771 -> IGTPW_4905 CI-20190529: 20190529 CI_DRM_8924: a8c0611e412aab46eab5475b0117d074892b96e2 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4905: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/index.html IGT_5771: f1d0c240ea2e631dfb9f493f37f8fb61cb2b1cf2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Testlist changes == +igt@kms_flip@flip-32bpp-ytile-to-32bpp-ytileccs +igt@kms_flip@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs +igt@kms_flip@flip-32bpp-ytile-to-64bpp-ytile +igt@kms_flip@flip-64bpp-ytile-to-32bpp-ytileccs == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4905/index.html [-- Attachment #1.2: Type: text/html, Size: 7819 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: add flip to downscaled subtests (rev2) 2020-08-25 20:05 [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests Juha-Pekka Heikkila 2020-08-25 20:38 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork @ 2020-08-26 4:44 ` Patchwork 2020-08-26 6:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2020-08-26 12:09 ` [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests Maarten Lankhorst 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-08-26 4:44 UTC (permalink / raw) To: Juha-Pekka Heikkila; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 3979 bytes --] == Series Details == Series: tests/kms_flip: add flip to downscaled subtests (rev2) URL : https://patchwork.freedesktop.org/series/80996/ State : success == Summary == CI Bug Log - changes from CI_DRM_8925 -> IGTPW_4906 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/index.html Known issues ------------ Here are the changes found in IGTPW_4906 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_cursor_legacy@basic-flip-after-cursor-atomic: - fi-icl-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html #### Possible fixes #### * igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1: - fi-icl-u2: [DMESG-WARN][3] ([i915#1982]) -> [PASS][4] +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html * igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2: - fi-skl-guc: [DMESG-WARN][5] ([i915#2203]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html #### Warnings #### * igt@gem_exec_suspend@basic-s0: - fi-kbl-x1275: [DMESG-WARN][7] ([i915#62] / [i915#92]) -> [DMESG-WARN][8] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html * igt@kms_flip@basic-flip-vs-modeset@a-dp1: - fi-kbl-x1275: [DMESG-WARN][9] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][10] ([i915#62] / [i915#92]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203 [i915#2249]: https://gitlab.freedesktop.org/drm/intel/issues/2249 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (37 -> 34) ------------------------------ Missing (3): fi-byt-clapper fi-byt-squawks fi-bsw-cyan Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5771 -> IGTPW_4906 CI-20190529: 20190529 CI_DRM_8925: b0f0c5e0b08e7d93135a27141919e765db3aaeef @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4906: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/index.html IGT_5771: f1d0c240ea2e631dfb9f493f37f8fb61cb2b1cf2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Testlist changes == +igt@kms_flip@flip-32bpp-ytile-to-32bpp-ytileccs +igt@kms_flip@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs +igt@kms_flip@flip-32bpp-ytile-to-64bpp-ytile +igt@kms_flip@flip-64bpp-ytile-to-32bpp-ytileccs == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/index.html [-- Attachment #1.2: Type: text/html, Size: 5171 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_flip: add flip to downscaled subtests (rev2) 2020-08-25 20:05 [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests Juha-Pekka Heikkila 2020-08-25 20:38 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork 2020-08-26 4:44 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: add flip to downscaled subtests (rev2) Patchwork @ 2020-08-26 6:41 ` Patchwork 2020-08-26 12:09 ` [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests Maarten Lankhorst 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-08-26 6:41 UTC (permalink / raw) To: Juha-Pekka Heikkila; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 19042 bytes --] == Series Details == Series: tests/kms_flip: add flip to downscaled subtests (rev2) URL : https://patchwork.freedesktop.org/series/80996/ State : success == Summary == CI Bug Log - changes from CI_DRM_8925_full -> IGTPW_4906_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_4906_full: ### IGT changes ### #### Possible regressions #### * {igt@kms_flip@flip-32bpp-ytile-to-32bpp-ytileccs} (NEW): - shard-tglb: NOTRUN -> [SKIP][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-tglb8/igt@kms_flip@flip-32bpp-ytile-to-32bpp-ytileccs.html * {igt@kms_flip@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs} (NEW): - shard-iclb: NOTRUN -> [SKIP][2] +1 similar issue [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-iclb3/igt@kms_flip@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html * {igt@kms_flip@flip-32bpp-ytile-to-64bpp-ytile} (NEW): - shard-glk: NOTRUN -> [FAIL][3] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-glk8/igt@kms_flip@flip-32bpp-ytile-to-64bpp-ytile.html - shard-kbl: NOTRUN -> [FAIL][4] +1 similar issue [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-kbl4/igt@kms_flip@flip-32bpp-ytile-to-64bpp-ytile.html New tests --------- New tests have been introduced between CI_DRM_8925_full and IGTPW_4906_full: ### New IGT tests (4) ### * igt@kms_flip@flip-32bpp-ytile-to-32bpp-ytileccs: - Statuses : 1 dmesg-fail(s) 2 fail(s) 1 pass(s) 3 skip(s) - Exec time: [0.0, 1.71] s * igt@kms_flip@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs: - Statuses : 1 dmesg-fail(s) 6 skip(s) - Exec time: [0.0, 1.46] s * igt@kms_flip@flip-32bpp-ytile-to-64bpp-ytile: - Statuses : 2 dmesg-fail(s) 3 fail(s) 2 skip(s) - Exec time: [0.0, 1.99] s * igt@kms_flip@flip-64bpp-ytile-to-32bpp-ytileccs: - Statuses : 1 dmesg-fail(s) 6 skip(s) - Exec time: [0.0, 1.47] s Known issues ------------ Here are the changes found in IGTPW_4906_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_gttfill@all: - shard-glk: [PASS][5] -> [DMESG-WARN][6] ([i915#118] / [i915#95]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-glk3/igt@gem_exec_gttfill@all.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-glk8/igt@gem_exec_gttfill@all.html * igt@gem_exec_whisper@basic-fds: - shard-apl: [PASS][7] -> [TIMEOUT][8] ([i915#1635] / [i915#1958]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-apl6/igt@gem_exec_whisper@basic-fds.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-apl3/igt@gem_exec_whisper@basic-fds.html * igt@gem_exec_whisper@basic-queues: - shard-iclb: [PASS][9] -> [TIMEOUT][10] ([i915#1958]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-iclb1/igt@gem_exec_whisper@basic-queues.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-iclb7/igt@gem_exec_whisper@basic-queues.html * igt@gem_exec_whisper@basic-queues-all: - shard-glk: [PASS][11] -> [TIMEOUT][12] ([i915#1958]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-glk6/igt@gem_exec_whisper@basic-queues-all.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-glk3/igt@gem_exec_whisper@basic-queues-all.html * igt@gem_partial_pwrite_pread@writes-after-reads-uncached: - shard-glk: [PASS][13] -> [FAIL][14] ([i915#2261]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-glk3/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-glk3/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html * igt@gem_sync@basic-store-all: - shard-glk: [PASS][15] -> [FAIL][16] ([i915#2356]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-glk4/igt@gem_sync@basic-store-all.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-glk8/igt@gem_sync@basic-store-all.html - shard-kbl: [PASS][17] -> [FAIL][18] ([i915#2356]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-kbl2/igt@gem_sync@basic-store-all.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-kbl2/igt@gem_sync@basic-store-all.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +10 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw: - shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#1635] / [i915#1982]) +1 similar issue [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-apl7/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu: - shard-glk: [PASS][23] -> [FAIL][24] ([i915#49]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-glk4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-glk5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html - shard-kbl: [PASS][25] -> [FAIL][26] ([i915#49]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html - shard-apl: [PASS][27] -> [FAIL][28] ([i915#1635] / [i915#49]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-apl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-apl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite: - shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([i915#1982]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-stridechange: - shard-glk: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-glk4/igt@kms_frontbuffer_tracking@fbc-stridechange.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-glk5/igt@kms_frontbuffer_tracking@fbc-stridechange.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render: - shard-tglb: [PASS][33] -> [DMESG-WARN][34] ([i915#1982]) +6 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-tglb1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-tglb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html #### Possible fixes #### * {igt@feature_discovery@psr2}: - shard-iclb: [SKIP][37] ([i915#658]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-iclb4/igt@feature_discovery@psr2.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-iclb2/igt@feature_discovery@psr2.html * igt@gem_exec_whisper@basic-contexts-all: - shard-glk: [TIMEOUT][39] ([i915#1958]) -> [PASS][40] +3 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-glk2/igt@gem_exec_whisper@basic-contexts-all.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-glk3/igt@gem_exec_whisper@basic-contexts-all.html * igt@gem_exec_whisper@basic-fds-priority: - shard-kbl: [TIMEOUT][41] ([i915#1958]) -> [PASS][42] +1 similar issue [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-kbl4/igt@gem_exec_whisper@basic-fds-priority.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-kbl1/igt@gem_exec_whisper@basic-fds-priority.html * igt@gem_exec_whisper@basic-normal: - shard-apl: [TIMEOUT][43] ([i915#1635] / [i915#1958]) -> [PASS][44] +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-apl7/igt@gem_exec_whisper@basic-normal.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-apl4/igt@gem_exec_whisper@basic-normal.html * igt@gem_exec_whisper@basic-queues: - shard-tglb: [TIMEOUT][45] ([i915#1958]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-tglb7/igt@gem_exec_whisper@basic-queues.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-tglb1/igt@gem_exec_whisper@basic-queues.html * igt@i915_module_load@reload: - shard-tglb: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48] +2 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-tglb5/igt@i915_module_load@reload.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-tglb7/igt@i915_module_load@reload.html * igt@i915_pm_dc@dc5-psr: - shard-tglb: [FAIL][49] ([i915#1899]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-tglb1/igt@i915_pm_dc@dc5-psr.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-tglb8/igt@i915_pm_dc@dc5-psr.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [FAIL][51] ([i915#1899]) -> [PASS][52] +1 similar issue [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-iclb5/igt@i915_pm_dc@dc6-psr.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-iclb4/igt@i915_pm_dc@dc6-psr.html * igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen: - shard-apl: [FAIL][53] ([i915#1635] / [i915#54]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html - shard-glk: [FAIL][55] ([i915#54]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-glk9/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-glk7/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html - shard-kbl: [FAIL][57] ([i915#54]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html * igt@kms_flip@2x-blocking-wf_vblank@ab-vga1-hdmi-a1: - shard-hsw: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-hsw4/igt@kms_flip@2x-blocking-wf_vblank@ab-vga1-hdmi-a1.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-hsw7/igt@kms_flip@2x-blocking-wf_vblank@ab-vga1-hdmi-a1.html * igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1: - shard-kbl: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62] +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-kbl4/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-kbl1/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend@b-dp1: - shard-kbl: [DMESG-WARN][63] ([i915#180]) -> [PASS][64] +4 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-kbl1/igt@kms_flip@flip-vs-suspend@b-dp1.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-kbl2/igt@kms_flip@flip-vs-suspend@b-dp1.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt: - shard-iclb: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render: - shard-iclb: [TIMEOUT][67] ([i915#123] / [i915#1958]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-iclb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: - shard-glk: [FAIL][69] ([i915#53]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-glk4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-glk7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html * igt@kms_psr@psr2_sprite_render: - shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72] +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-iclb8/igt@kms_psr@psr2_sprite_render.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-iclb2/igt@kms_psr@psr2_sprite_render.html * igt@kms_setmode@basic: - shard-kbl: [FAIL][73] ([i915#31]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-kbl7/igt@kms_setmode@basic.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-kbl1/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-c-query-forked-busy: - shard-iclb: [TIMEOUT][75] ([i915#1958]) -> [PASS][76] +3 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-iclb2/igt@kms_vblank@pipe-c-query-forked-busy.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-iclb1/igt@kms_vblank@pipe-c-query-forked-busy.html * igt@perf@blocking-parameterized: - shard-iclb: [FAIL][77] ([i915#1542]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-iclb5/igt@perf@blocking-parameterized.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-iclb6/igt@perf@blocking-parameterized.html * igt@sysfs_timeslice_duration@timeout@vecs0: - shard-iclb: [FAIL][79] ([i915#1755]) -> [PASS][80] [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-iclb7/igt@sysfs_timeslice_duration@timeout@vecs0.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-iclb2/igt@sysfs_timeslice_duration@timeout@vecs0.html #### Warnings #### * igt@gem_exec_whisper@basic-queues-forked-all: - shard-glk: [DMESG-WARN][81] ([i915#118] / [i915#95]) -> [TIMEOUT][82] ([i915#1958]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-glk5/igt@gem_exec_whisper@basic-queues-forked-all.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-glk6/igt@gem_exec_whisper@basic-queues-forked-all.html * igt@i915_pm_dc@dc6-psr: - shard-tglb: [FAIL][83] ([i915#1899]) -> [FAIL][84] ([i915#454]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/shard-tglb3/igt@i915_pm_dc@dc6-psr.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/shard-tglb5/igt@i915_pm_dc@dc6-psr.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1899]: https://gitlab.freedesktop.org/drm/intel/issues/1899 [i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2261]: https://gitlab.freedesktop.org/drm/intel/issues/2261 [i915#2356]: https://gitlab.freedesktop.org/drm/intel/issues/2356 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (10 -> 8) ------------------------------ Missing (2): pig-skl-6260u pig-glk-j5005 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5771 -> IGTPW_4906 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_8925: b0f0c5e0b08e7d93135a27141919e765db3aaeef @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4906: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/index.html IGT_5771: f1d0c240ea2e631dfb9f493f37f8fb61cb2b1cf2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4906/index.html [-- Attachment #1.2: Type: text/html, Size: 22860 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests 2020-08-25 20:05 [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests Juha-Pekka Heikkila ` (2 preceding siblings ...) 2020-08-26 6:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2020-08-26 12:09 ` Maarten Lankhorst 2020-08-27 10:47 ` Juha-Pekka Heikkila 3 siblings, 1 reply; 6+ messages in thread From: Maarten Lankhorst @ 2020-08-26 12:09 UTC (permalink / raw) To: Juha-Pekka Heikkila, igt-dev Hey, Can you make a separate testcase for those scalings? kms_flip is a legacy test, and you can see that in your subtests. Op 25-08-2020 om 22:05 schreef Juha-Pekka Heikkila: > attempt to cause cdclk changes and stress scalers with flipping > to different size fb with different modifiers. Verify results > with crc. > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > --- > tests/kms_flip.c | 155 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 155 insertions(+) > > diff --git a/tests/kms_flip.c b/tests/kms_flip.c > index b33cfe9ca..5f906f5f0 100755 > --- a/tests/kms_flip.c > +++ b/tests/kms_flip.c > @@ -1605,6 +1605,155 @@ static void test_nonblocking_read(int in) > close(fd); > } > > +const struct { > + const char *name; > + const char *describe; > + uint64_t firstmodifier; > + uint32_t firstformat; > + uint64_t secondmodifier; > + uint32_t secondformat; > +} special_flip_scenario_test[] = { > + { > + "flip-32bpp-ytile-to-64bpp-ytile", > + "Try to flip from 32bpp non scaled fb to 64bpp downscaled fb in attempt to stress cdclk reprogramming.", > + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, > + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB16161616F > + }, > + { > + "flip-32bpp-ytile-to-32bpp-ytilegen12rcccs", > + "Try to flip from 32bpp non scaled fb to 32bpp downscaled gen12 rc ccs fb in attempt to stress cdclk reprogramming.", > + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, > + LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS, DRM_FORMAT_XRGB8888 > + }, > + { > + "flip-32bpp-ytile-to-32bpp-ytileccs", > + "Try to flip from 32bpp non scaled ytiled fb to 32bpp downscaled ytiled ccs fb.", > + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, > + LOCAL_I915_FORMAT_MOD_Y_TILED_CCS, DRM_FORMAT_XRGB8888 > + }, > + { > + "flip-64bpp-ytile-to-32bpp-ytileccs", > + "Try to flip from 64bpp non scaled ytiled fb to 32bpp downscaled gen12 rc ccs fb.", > + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, > + LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS, DRM_FORMAT_XRGB8888 > + }, > +}; > + > +static void test_flip_to_scaled(uint32_t index) > +{ > + uint32_t screenwidth, screenheight; > + uint32_t bigfbwidth, bigfbheight; > + uint32_t pipe = 0; //lets just run on first output, first pipe > + uint64_t smallmodifier = special_flip_scenario_test[index].firstmodifier; > + uint64_t bigmodifier = special_flip_scenario_test[index].secondmodifier; > + uint32_t smallformat = special_flip_scenario_test[index].firstformat; > + uint32_t bigformat = special_flip_scenario_test[index].secondformat; > + uint32_t gen; > + > + igt_display_t display; > + igt_output_t *output; > + igt_plane_t *primary; > + igt_pipe_crc_t *pipe_crc; > + igt_crc_t small_crc, big_crc; > + struct igt_fb small_fb, big_fb; > + > + struct drm_mode_fb_cmd2 f = {0}; > + drmModeModeInfo *mode; > + struct drm_event_vblank ev; > + > + cairo_t *cr; > + > + // this is Intel only test so bail out early. > + igt_require_intel(drm_fd); > + gen = intel_gen(intel_get_drm_devid(drm_fd)); > + > + // will be using scalers hence gen need to be >= 9 > + igt_require(gen >= 9); > + igt_require_pipe_crc(drm_fd); > + igt_display_require(&display, drm_fd); > + igt_require(display.is_atomic); > + igt_require(igt_display_has_format_mod(&display, smallformat, smallmodifier)); > + igt_require(igt_display_has_format_mod(&display, bigformat, bigmodifier)); This should be a in preamble, which is simple if you make a separate test. > + for_each_connected_output(&display, output) { > + mode = igt_output_get_mode(output); > + screenwidth = min(mode->hdisplay, 1920); > + screenheight = min(mode->vdisplay, 1080); > + > + // big fb will be 4k unless running on older than ICL > + if (gen < 11) { > + bigfbwidth = 2560; > + bigfbheight = 1440; > + } else { > + bigfbwidth = 3840; > + bigfbheight = 2160; > + } > + > + igt_require(igt_create_color_fb(drm_fd, screenwidth, screenheight, > + smallformat, smallmodifier, > + 0, 1, 0, &small_fb)); > + > + igt_create_bo_for_fb(drm_fd, bigfbwidth, bigfbheight, bigformat, > + bigmodifier, &big_fb); > + igt_assert(big_fb.gem_handle > 0); > + > + f.width = big_fb.width; > + f.height = big_fb.height; > + f.pixel_format = big_fb.drm_format; > + f.flags = LOCAL_DRM_MODE_FB_MODIFIERS; > + > + for (int n = 0; n < big_fb.num_planes; n++) { > + f.handles[n] = big_fb.gem_handle; > + f.modifier[n] = big_fb.modifier; > + f.pitches[n] = big_fb.strides[n]; > + f.offsets[n] = big_fb.offsets[n]; > + } > + > + cr = igt_get_cairo_ctx(drm_fd, &big_fb); > + igt_paint_color(cr, 0, 0, bigfbwidth, bigfbheight, 0, 1, 0); > + igt_put_cairo_ctx(cr); > + > + igt_assert(drmIoctl(drm_fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) == 0); > + big_fb.fb_id = f.fb_id; > + > + igt_output_set_pipe(output, pipe); > + > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > + igt_plane_set_fb(primary, NULL); > + > + igt_display_commit_atomic(&display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL); > + pipe_crc = igt_pipe_crc_new(drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO); > + igt_pipe_crc_start(pipe_crc); > + > + igt_plane_set_position(primary, 0, 0); > + igt_plane_set_fb(primary, &small_fb); > + igt_plane_set_size(primary, screenwidth, screenheight); > + > + igt_display_commit_atomic(&display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL); > + igt_pipe_crc_collect_crc(pipe_crc, &small_crc); > + > + igt_plane_set_fb(primary, &big_fb); > + igt_plane_set_size(primary, screenwidth, screenheight); > + igt_display_commit_atomic(&display, DRM_MODE_ATOMIC_ALLOW_MODESET | > + DRM_MODE_PAGE_FLIP_EVENT, NULL); > + > + igt_assert(read(drm_fd, &ev, sizeof(ev)) == sizeof(ev)); > + > + igt_pipe_crc_collect_crc(pipe_crc, &big_crc); > + > + igt_pipe_crc_stop(pipe_crc); > + igt_pipe_crc_free(pipe_crc); > + igt_remove_fb(drm_fd, &small_fb); > + igt_remove_fb(drm_fd, &big_fb); > + igt_output_set_pipe(output, PIPE_ANY); > + > + igt_assert(igt_check_crc_equal(&small_crc, &big_crc)); > + > + // run just on first found connected output. > + break; > + } Run those with a separate subtest per pipe, and do output = igt_get_single_output_for_pipe ? > +} > + > igt_main > { > struct { > @@ -1720,4 +1869,10 @@ igt_main > run_pair(tests[i].duration, tests[i].flags); > } > igt_stop_signal_helper(); > + > + for (int index = 0; index < ARRAY_SIZE(special_flip_scenario_test); index++) { > + igt_describe(special_flip_scenario_test[index].describe); > + igt_subtest(special_flip_scenario_test[index].name) > + test_flip_to_scaled(index); Can you unroll this struct, and perhaps pass pipe as argument? > + } > } _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests 2020-08-26 12:09 ` [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests Maarten Lankhorst @ 2020-08-27 10:47 ` Juha-Pekka Heikkila 0 siblings, 0 replies; 6+ messages in thread From: Juha-Pekka Heikkila @ 2020-08-27 10:47 UTC (permalink / raw) To: Maarten Lankhorst, igt-dev On 26.8.2020 15.09, Maarten Lankhorst wrote: > Hey, > > Can you make a separate testcase for those scalings? kms_flip is a legacy test, and you can see that in your subtests. > Yea, I'll make them into separate test. I was thinking these tests are in the wrong place but they were still just flip tests. > Op 25-08-2020 om 22:05 schreef Juha-Pekka Heikkila: >> attempt to cause cdclk changes and stress scalers with flipping >> to different size fb with different modifiers. Verify results >> with crc. >> >> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> >> --- >> tests/kms_flip.c | 155 +++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 155 insertions(+) >> >> diff --git a/tests/kms_flip.c b/tests/kms_flip.c >> index b33cfe9ca..5f906f5f0 100755 >> --- a/tests/kms_flip.c >> +++ b/tests/kms_flip.c >> @@ -1605,6 +1605,155 @@ static void test_nonblocking_read(int in) >> close(fd); >> } >> >> +const struct { >> + const char *name; >> + const char *describe; >> + uint64_t firstmodifier; >> + uint32_t firstformat; >> + uint64_t secondmodifier; >> + uint32_t secondformat; >> +} special_flip_scenario_test[] = { >> + { >> + "flip-32bpp-ytile-to-64bpp-ytile", >> + "Try to flip from 32bpp non scaled fb to 64bpp downscaled fb in attempt to stress cdclk reprogramming.", >> + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, >> + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB16161616F >> + }, >> + { >> + "flip-32bpp-ytile-to-32bpp-ytilegen12rcccs", >> + "Try to flip from 32bpp non scaled fb to 32bpp downscaled gen12 rc ccs fb in attempt to stress cdclk reprogramming.", >> + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, >> + LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS, DRM_FORMAT_XRGB8888 >> + }, >> + { >> + "flip-32bpp-ytile-to-32bpp-ytileccs", >> + "Try to flip from 32bpp non scaled ytiled fb to 32bpp downscaled ytiled ccs fb.", >> + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, >> + LOCAL_I915_FORMAT_MOD_Y_TILED_CCS, DRM_FORMAT_XRGB8888 >> + }, >> + { >> + "flip-64bpp-ytile-to-32bpp-ytileccs", >> + "Try to flip from 64bpp non scaled ytiled fb to 32bpp downscaled gen12 rc ccs fb.", >> + LOCAL_I915_FORMAT_MOD_Y_TILED, DRM_FORMAT_XRGB8888, >> + LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS, DRM_FORMAT_XRGB8888 >> + }, >> +}; >> + >> +static void test_flip_to_scaled(uint32_t index) >> +{ >> + uint32_t screenwidth, screenheight; >> + uint32_t bigfbwidth, bigfbheight; >> + uint32_t pipe = 0; //lets just run on first output, first pipe >> + uint64_t smallmodifier = special_flip_scenario_test[index].firstmodifier; >> + uint64_t bigmodifier = special_flip_scenario_test[index].secondmodifier; >> + uint32_t smallformat = special_flip_scenario_test[index].firstformat; >> + uint32_t bigformat = special_flip_scenario_test[index].secondformat; >> + uint32_t gen; >> + >> + igt_display_t display; >> + igt_output_t *output; >> + igt_plane_t *primary; >> + igt_pipe_crc_t *pipe_crc; >> + igt_crc_t small_crc, big_crc; >> + struct igt_fb small_fb, big_fb; >> + >> + struct drm_mode_fb_cmd2 f = {0}; >> + drmModeModeInfo *mode; >> + struct drm_event_vblank ev; >> + >> + cairo_t *cr; >> + >> + // this is Intel only test so bail out early. >> + igt_require_intel(drm_fd); >> + gen = intel_gen(intel_get_drm_devid(drm_fd)); >> + >> + // will be using scalers hence gen need to be >= 9 >> + igt_require(gen >= 9); >> + igt_require_pipe_crc(drm_fd); >> + igt_display_require(&display, drm_fd); >> + igt_require(display.is_atomic); >> + igt_require(igt_display_has_format_mod(&display, smallformat, smallmodifier)); >> + igt_require(igt_display_has_format_mod(&display, bigformat, bigmodifier)); > > This should be a in preamble, which is simple if you make a separate test. > > >> + for_each_connected_output(&display, output) { >> + mode = igt_output_get_mode(output); >> + screenwidth = min(mode->hdisplay, 1920); >> + screenheight = min(mode->vdisplay, 1080); >> + >> + // big fb will be 4k unless running on older than ICL >> + if (gen < 11) { >> + bigfbwidth = 2560; >> + bigfbheight = 1440; >> + } else { >> + bigfbwidth = 3840; >> + bigfbheight = 2160; >> + } >> + >> + igt_require(igt_create_color_fb(drm_fd, screenwidth, screenheight, >> + smallformat, smallmodifier, >> + 0, 1, 0, &small_fb)); >> + >> + igt_create_bo_for_fb(drm_fd, bigfbwidth, bigfbheight, bigformat, >> + bigmodifier, &big_fb); >> + igt_assert(big_fb.gem_handle > 0); >> + >> + f.width = big_fb.width; >> + f.height = big_fb.height; >> + f.pixel_format = big_fb.drm_format; >> + f.flags = LOCAL_DRM_MODE_FB_MODIFIERS; >> + >> + for (int n = 0; n < big_fb.num_planes; n++) { >> + f.handles[n] = big_fb.gem_handle; >> + f.modifier[n] = big_fb.modifier; >> + f.pitches[n] = big_fb.strides[n]; >> + f.offsets[n] = big_fb.offsets[n]; >> + } >> + >> + cr = igt_get_cairo_ctx(drm_fd, &big_fb); >> + igt_paint_color(cr, 0, 0, bigfbwidth, bigfbheight, 0, 1, 0); >> + igt_put_cairo_ctx(cr); >> + >> + igt_assert(drmIoctl(drm_fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) == 0); >> + big_fb.fb_id = f.fb_id; >> + >> + igt_output_set_pipe(output, pipe); >> + >> + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); >> + igt_plane_set_fb(primary, NULL); >> + >> + igt_display_commit_atomic(&display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL); >> + pipe_crc = igt_pipe_crc_new(drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO); >> + igt_pipe_crc_start(pipe_crc); >> + >> + igt_plane_set_position(primary, 0, 0); >> + igt_plane_set_fb(primary, &small_fb); >> + igt_plane_set_size(primary, screenwidth, screenheight); >> + >> + igt_display_commit_atomic(&display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL); >> + igt_pipe_crc_collect_crc(pipe_crc, &small_crc); >> + >> + igt_plane_set_fb(primary, &big_fb); >> + igt_plane_set_size(primary, screenwidth, screenheight); >> + igt_display_commit_atomic(&display, DRM_MODE_ATOMIC_ALLOW_MODESET | >> + DRM_MODE_PAGE_FLIP_EVENT, NULL); >> + >> + igt_assert(read(drm_fd, &ev, sizeof(ev)) == sizeof(ev)); >> + >> + igt_pipe_crc_collect_crc(pipe_crc, &big_crc); >> + >> + igt_pipe_crc_stop(pipe_crc); >> + igt_pipe_crc_free(pipe_crc); >> + igt_remove_fb(drm_fd, &small_fb); >> + igt_remove_fb(drm_fd, &big_fb); >> + igt_output_set_pipe(output, PIPE_ANY); >> + >> + igt_assert(igt_check_crc_equal(&small_crc, &big_crc)); >> + >> + // run just on first found connected output. >> + break; >> + } > > Run those with a separate subtest per pipe, and do output = igt_get_single_output_for_pipe ? I can add those separate pipe tests. I wasn't certain if there's need for these tests to run on each pipe so I was at first just going with first pipe. This part of test anyway need some scrubbing, now if there was no output found this test would say 'success' :) There's also those scalers I need to figure correct values for pre ICL hw, now on test results there's "34, Numerical result out of range" in couple of tests. > > >> +} >> + >> igt_main >> { >> struct { >> @@ -1720,4 +1869,10 @@ igt_main >> run_pair(tests[i].duration, tests[i].flags); >> } >> igt_stop_signal_helper(); >> + >> + for (int index = 0; index < ARRAY_SIZE(special_flip_scenario_test); index++) { >> + igt_describe(special_flip_scenario_test[index].describe); >> + igt_subtest(special_flip_scenario_test[index].name) >> + test_flip_to_scaled(index); > > Can you unroll this struct, and perhaps pass pipe as argument? Why unroll? I though things look more clean this way and if there was need to add new flip test for these sets one would just need to put it into the 'special_flip_scenario_test' array. > > >> + } >> } > > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-27 10:47 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-08-25 20:05 [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests Juha-Pekka Heikkila 2020-08-25 20:38 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork 2020-08-26 4:44 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: add flip to downscaled subtests (rev2) Patchwork 2020-08-26 6:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2020-08-26 12:09 ` [igt-dev] [PATCH i-g-t] tests/kms_flip: add flip to downscaled subtests Maarten Lankhorst 2020-08-27 10:47 ` Juha-Pekka Heikkila
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.