All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: "Leonidas P. Papadakos" <papadakospan@gmail.com>,
	Jose Abreu <jose.abreu@synopsys.com>
Cc: "Philipp Tomsich" <philipp.tomsich@theobroma-systems.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Christoph Müllner" <christoph.muellner@theobroma-systems.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Klaus Goger" <klaus.goger@theobroma-systems.com>
Subject: Re: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices
Date: Fri, 5 Apr 2019 19:29:03 +0100	[thread overview]
Message-ID: <85c1d945-d49b-3350-6ff4-a058c5a8c1d7@arm.com> (raw)
In-Reply-To: <1554488052.1193.1@gmail.com>

On 05/04/2019 19:14, Leonidas P. Papadakos wrote:
> 
> Seems like snps,txpbl = <0x20> gives me better performance

What's your overall setup? So far with my RK3328 box I've found that 
with an IPv4 link and an MTU of 2000 I have to dial PBL right down to 1 
or 2 (with no-pbl-x8 as well) to prevent Tx stalling, and with the MTU 
bumped up to 3000 it just won't play at any PBL setting...

Robin.

WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: "Leonidas P. Papadakos" <papadakospan@gmail.com>,
	Jose Abreu <jose.abreu@synopsys.com>
Cc: "Alexandre Torgue" <alexandre.torgue@st.com>,
	netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	"Christoph Müllner" <christoph.muellner@theobroma-systems.com>,
	"Klaus Goger" <klaus.goger@theobroma-systems.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Philipp Tomsich" <philipp.tomsich@theobroma-systems.com>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Heiko Stübner" <heiko@sntech.de>
Subject: Re: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices
Date: Fri, 5 Apr 2019 19:29:03 +0100	[thread overview]
Message-ID: <85c1d945-d49b-3350-6ff4-a058c5a8c1d7@arm.com> (raw)
In-Reply-To: <1554488052.1193.1@gmail.com>

On 05/04/2019 19:14, Leonidas P. Papadakos wrote:
> 
> Seems like snps,txpbl = <0x20> gives me better performance

What's your overall setup? So far with my RK3328 box I've found that 
with an IPv4 link and an MTU of 2000 I have to dial PBL right down to 1 
or 2 (with no-pbl-x8 as well) to prevent Tx stalling, and with the MTU 
bumped up to 3000 it just won't play at any PBL setting...

Robin.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-04-05 18:29 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 18:18 [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices Leonidas P. Papadakos
2019-04-01 18:18 ` Leonidas P. Papadakos
2019-04-01 18:31 ` Heiko Stübner
2019-04-01 18:31   ` Heiko Stübner
2019-04-01 18:54 ` Robin Murphy
2019-04-01 18:54   ` Robin Murphy
2019-04-01 19:06   ` Heiko Stübner
2019-04-01 19:06     ` Heiko Stübner
2019-04-01 19:12     ` Philipp Tomsich
2019-04-01 19:12       ` Philipp Tomsich
2019-04-02  7:59       ` Jose Abreu
2019-04-02  7:59         ` Jose Abreu
2019-04-02 11:49         ` Robin Murphy
2019-04-02 11:49           ` Robin Murphy
2019-04-02 11:53           ` Jose Abreu
2019-04-02 11:53             ` Jose Abreu
2019-04-02 22:08             ` Robin Murphy
2019-04-02 22:08               ` Robin Murphy
2019-04-02 22:48               ` Leonidas P. Papadakos
2019-04-02 22:48                 ` Leonidas P. Papadakos
2019-04-03  7:55                 ` Jose Abreu
2019-04-03  7:55                   ` Jose Abreu
2019-04-03 15:35                   ` Leonidas P. Papadakos
2019-04-03 15:35                     ` Leonidas P. Papadakos
2019-04-03 15:55                     ` Leonidas P. Papadakos
2019-04-03 15:55                       ` Leonidas P. Papadakos
2019-04-03 16:12                       ` Robin Murphy
2019-04-03 16:12                         ` Robin Murphy
2019-04-05 10:24                         ` Jose Abreu
2019-04-05 10:24                           ` Jose Abreu
2019-04-05 17:58                           ` Leonidas P. Papadakos
2019-04-05 17:58                             ` Leonidas P. Papadakos
2019-04-05 18:14                           ` Leonidas P. Papadakos
2019-04-05 18:14                             ` Leonidas P. Papadakos
2019-04-05 18:29                             ` Robin Murphy [this message]
2019-04-05 18:29                               ` Robin Murphy
2019-04-05 18:38                               ` Leonidas P. Papadakos
2019-04-05 18:38                                 ` Leonidas P. Papadakos
2019-04-11 21:09                                 ` Leonidas P. Papadakos
2019-04-11 21:09                                   ` Leonidas P. Papadakos
2019-04-12  7:35                                   ` Jose Abreu
2019-04-12  7:35                                     ` Jose Abreu
2019-04-12 11:13                                     ` Leonidas P. Papadakos
2019-04-12 11:13                                       ` Leonidas P. Papadakos
2019-04-15  8:15                                       ` Jose Abreu
2019-04-15  8:15                                         ` Jose Abreu
2019-04-15 21:45                                         ` Leonidas P. Papadakos
2019-04-15 21:45                                           ` Leonidas P. Papadakos
2019-04-15 22:19                                           ` Leonidas P. Papadakos
2019-04-15 22:19                                             ` Leonidas P. Papadakos
2019-04-16  8:01                                             ` Jose Abreu
2019-04-16  8:01                                               ` Jose Abreu
2019-04-16 10:03                                               ` Leonidas P. Papadakos
2019-04-16 10:03                                                 ` Leonidas P. Papadakos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85c1d945-d49b-3350-6ff4-a058c5a8c1d7@arm.com \
    --to=robin.murphy@arm.com \
    --cc=alexandre.torgue@st.com \
    --cc=christoph.muellner@theobroma-systems.com \
    --cc=heiko@sntech.de \
    --cc=jose.abreu@synopsys.com \
    --cc=klaus.goger@theobroma-systems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=papadakospan@gmail.com \
    --cc=philipp.tomsich@theobroma-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.