* [PATCH] fbdev: Switch i2c drivers back to use .probe()
@ 2023-05-26 5:41 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2023-05-26 5:41 UTC (permalink / raw)
To: Helge Deller
Cc: Vladimir Oltean, Sebastian Reichel, Andy Shevchenko, Ajay Gupta,
Srinivas Pandruvada, Hans Verkuil, Jilin Yuan, linux-fbdev,
dri-devel, kernel
After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
call-back type"), all drivers being converted to .probe_new() and then
03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
convert back to (the new) .probe() to be able to eventually drop
.probe_new() from struct i2c_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/video/fbdev/matrox/matroxfb_maven.c | 2 +-
drivers/video/fbdev/ssd1307fb.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/matrox/matroxfb_maven.c b/drivers/video/fbdev/matrox/matroxfb_maven.c
index 727a10a59811..b15a8ad92ba7 100644
--- a/drivers/video/fbdev/matrox/matroxfb_maven.c
+++ b/drivers/video/fbdev/matrox/matroxfb_maven.c
@@ -1291,7 +1291,7 @@ static struct i2c_driver maven_driver={
.driver = {
.name = "maven",
},
- .probe_new = maven_probe,
+ .probe = maven_probe,
.remove = maven_remove,
.id_table = maven_id,
};
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 046b9990d27c..132d1a205011 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -844,7 +844,7 @@ static const struct i2c_device_id ssd1307fb_i2c_id[] = {
MODULE_DEVICE_TABLE(i2c, ssd1307fb_i2c_id);
static struct i2c_driver ssd1307fb_driver = {
- .probe_new = ssd1307fb_probe,
+ .probe = ssd1307fb_probe,
.remove = ssd1307fb_remove,
.id_table = ssd1307fb_i2c_id,
.driver = {
base-commit: ac9a78681b921877518763ba0e89202254349d1b
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] fbdev: Switch i2c drivers back to use .probe()
@ 2023-05-26 5:41 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2023-05-26 5:41 UTC (permalink / raw)
To: Helge Deller
Cc: linux-fbdev, Andy Shevchenko, Jilin Yuan, Ajay Gupta,
Sebastian Reichel, dri-devel, kernel, Srinivas Pandruvada,
Hans Verkuil, Vladimir Oltean
After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
call-back type"), all drivers being converted to .probe_new() and then
03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
convert back to (the new) .probe() to be able to eventually drop
.probe_new() from struct i2c_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/video/fbdev/matrox/matroxfb_maven.c | 2 +-
drivers/video/fbdev/ssd1307fb.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/matrox/matroxfb_maven.c b/drivers/video/fbdev/matrox/matroxfb_maven.c
index 727a10a59811..b15a8ad92ba7 100644
--- a/drivers/video/fbdev/matrox/matroxfb_maven.c
+++ b/drivers/video/fbdev/matrox/matroxfb_maven.c
@@ -1291,7 +1291,7 @@ static struct i2c_driver maven_driver={
.driver = {
.name = "maven",
},
- .probe_new = maven_probe,
+ .probe = maven_probe,
.remove = maven_remove,
.id_table = maven_id,
};
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 046b9990d27c..132d1a205011 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -844,7 +844,7 @@ static const struct i2c_device_id ssd1307fb_i2c_id[] = {
MODULE_DEVICE_TABLE(i2c, ssd1307fb_i2c_id);
static struct i2c_driver ssd1307fb_driver = {
- .probe_new = ssd1307fb_probe,
+ .probe = ssd1307fb_probe,
.remove = ssd1307fb_remove,
.id_table = ssd1307fb_i2c_id,
.driver = {
base-commit: ac9a78681b921877518763ba0e89202254349d1b
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fbdev: Switch i2c drivers back to use .probe()
2023-05-26 5:41 ` Uwe Kleine-König
@ 2023-05-27 6:21 ` Helge Deller
-1 siblings, 0 replies; 4+ messages in thread
From: Helge Deller @ 2023-05-27 6:21 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Vladimir Oltean, Sebastian Reichel, Andy Shevchenko, Ajay Gupta,
Srinivas Pandruvada, Hans Verkuil, Jilin Yuan, linux-fbdev,
dri-devel, kernel
On 5/26/23 07:41, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/matrox/matroxfb_maven.c | 2 +-
> drivers/video/fbdev/ssd1307fb.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/matrox/matroxfb_maven.c b/drivers/video/fbdev/matrox/matroxfb_maven.c
> index 727a10a59811..b15a8ad92ba7 100644
> --- a/drivers/video/fbdev/matrox/matroxfb_maven.c
> +++ b/drivers/video/fbdev/matrox/matroxfb_maven.c
> @@ -1291,7 +1291,7 @@ static struct i2c_driver maven_driver={
> .driver = {
> .name = "maven",
> },
> - .probe_new = maven_probe,
> + .probe = maven_probe,
> .remove = maven_remove,
> .id_table = maven_id,
> };
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index 046b9990d27c..132d1a205011 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -844,7 +844,7 @@ static const struct i2c_device_id ssd1307fb_i2c_id[] = {
> MODULE_DEVICE_TABLE(i2c, ssd1307fb_i2c_id);
>
> static struct i2c_driver ssd1307fb_driver = {
> - .probe_new = ssd1307fb_probe,
> + .probe = ssd1307fb_probe,
> .remove = ssd1307fb_remove,
> .id_table = ssd1307fb_i2c_id,
> .driver = {
>
> base-commit: ac9a78681b921877518763ba0e89202254349d1b
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fbdev: Switch i2c drivers back to use .probe()
@ 2023-05-27 6:21 ` Helge Deller
0 siblings, 0 replies; 4+ messages in thread
From: Helge Deller @ 2023-05-27 6:21 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-fbdev, Andy Shevchenko, Jilin Yuan, Ajay Gupta,
Sebastian Reichel, dri-devel, kernel, Srinivas Pandruvada,
Hans Verkuil, Vladimir Oltean
On 5/26/23 07:41, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/matrox/matroxfb_maven.c | 2 +-
> drivers/video/fbdev/ssd1307fb.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/matrox/matroxfb_maven.c b/drivers/video/fbdev/matrox/matroxfb_maven.c
> index 727a10a59811..b15a8ad92ba7 100644
> --- a/drivers/video/fbdev/matrox/matroxfb_maven.c
> +++ b/drivers/video/fbdev/matrox/matroxfb_maven.c
> @@ -1291,7 +1291,7 @@ static struct i2c_driver maven_driver={
> .driver = {
> .name = "maven",
> },
> - .probe_new = maven_probe,
> + .probe = maven_probe,
> .remove = maven_remove,
> .id_table = maven_id,
> };
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index 046b9990d27c..132d1a205011 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -844,7 +844,7 @@ static const struct i2c_device_id ssd1307fb_i2c_id[] = {
> MODULE_DEVICE_TABLE(i2c, ssd1307fb_i2c_id);
>
> static struct i2c_driver ssd1307fb_driver = {
> - .probe_new = ssd1307fb_probe,
> + .probe = ssd1307fb_probe,
> .remove = ssd1307fb_remove,
> .id_table = ssd1307fb_i2c_id,
> .driver = {
>
> base-commit: ac9a78681b921877518763ba0e89202254349d1b
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-27 6:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-26 5:41 [PATCH] fbdev: Switch i2c drivers back to use .probe() Uwe Kleine-König
2023-05-26 5:41 ` Uwe Kleine-König
2023-05-27 6:21 ` Helge Deller
2023-05-27 6:21 ` Helge Deller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.