* [U-Boot] [PATCH v3 0/5] Add support for TI PCF8575 I2C GPIO expander
@ 2016-08-02 4:44 Vignesh R
2016-08-02 4:44 ` [U-Boot] [PATCH v3 1/5] gpio: Add driver " Vignesh R
` (4 more replies)
0 siblings, 5 replies; 18+ messages in thread
From: Vignesh R @ 2016-08-02 4:44 UTC (permalink / raw)
To: u-boot
This series adds support for TI's PCF8575 I2C GPIO expander[1] based on
Linux Kernel driver for the same. Also adds support for ethernet to use
new PCF8575 driver to select appropriate cpsw slaves on dra72.
Tested on DRA72 EVM.
[1]http://www.ti.com/lit/ds/symlink/pcf8575.pdf
Vignesh R (5):
gpio: Add driver for TI PCF8575 I2C GPIO expander
ARM: dra7xx_evm: Enable support for TI PCF8575
ARM: dts: dra7xx: Add u-boot specific property for PCF8575 nodes
net: cpsw: Add support to drive gpios for ethernet to be functional
ARM: dts: dra72-evm: Add mode-gpios entry for mac node
arch/arm/dts/dra7-evm.dts | 1 +
arch/arm/dts/dra72-evm.dts | 4 +-
configs/dra7xx_evm_defconfig | 1 +
configs/dra7xx_hs_evm_defconfig | 1 +
doc/device-tree-bindings/gpio/gpio-pcf857x.txt | 71 ++++++++++
drivers/gpio/Kconfig | 7 +
drivers/gpio/Makefile | 1 +
drivers/gpio/pcf8575_gpio.c | 180 +++++++++++++++++++++++++
drivers/net/cpsw.c | 12 ++
9 files changed, 277 insertions(+), 1 deletion(-)
create mode 100644 doc/device-tree-bindings/gpio/gpio-pcf857x.txt
create mode 100644 drivers/gpio/pcf8575_gpio.c
--
2.9.2
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 1/5] gpio: Add driver for TI PCF8575 I2C GPIO expander
2016-08-02 4:44 [U-Boot] [PATCH v3 0/5] Add support for TI PCF8575 I2C GPIO expander Vignesh R
@ 2016-08-02 4:44 ` Vignesh R
2016-08-02 6:47 ` Mugunthan V N
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-08-02 4:44 ` [U-Boot] [PATCH v3 2/5] ARM: dra7xx_evm: Enable support for TI PCF8575 Vignesh R
` (3 subsequent siblings)
4 siblings, 2 replies; 18+ messages in thread
From: Vignesh R @ 2016-08-02 4:44 UTC (permalink / raw)
To: u-boot
TI's PCF8575 is a 16-bit I2C GPIO expander.The device features a
16-bit quasi-bidirectional I/O ports. Each quasi-bidirectional I/O can
be used as an input or output without the use of a data-direction
control signal. The I/Os should be high before being used as inputs.
Read the device documentation for more details[1].
This driver is based on pcf857x driver available in Linux v4.7 kernel.
It supports basic reading and writing of gpio pins.
[1] http://www.ti.com/lit/ds/symlink/pcf8575.pdf
Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
v3: use dm_i2c_read/write() instead of dm_i2c_xfer().
cleanups as suggested by Simon Glass
doc/device-tree-bindings/gpio/gpio-pcf857x.txt | 71 ++++++++++
drivers/gpio/Kconfig | 7 +
drivers/gpio/Makefile | 1 +
drivers/gpio/pcf8575_gpio.c | 180 +++++++++++++++++++++++++
4 files changed, 259 insertions(+)
create mode 100644 doc/device-tree-bindings/gpio/gpio-pcf857x.txt
create mode 100644 drivers/gpio/pcf8575_gpio.c
diff --git a/doc/device-tree-bindings/gpio/gpio-pcf857x.txt b/doc/device-tree-bindings/gpio/gpio-pcf857x.txt
new file mode 100644
index 000000000000..ada4e2973323
--- /dev/null
+++ b/doc/device-tree-bindings/gpio/gpio-pcf857x.txt
@@ -0,0 +1,71 @@
+* PCF857x-compatible I/O expanders
+
+The PCF857x-compatible chips have "quasi-bidirectional" I/O lines that can be
+driven high by a pull-up current source or driven low to ground. This combines
+the direction and output level into a single bit per line, which can't be read
+back. We can't actually know at initialization time whether a line is configured
+(a) as output and driving the signal low/high, or (b) as input and reporting a
+low/high value, without knowing the last value written since the chip came out
+of reset (if any). The only reliable solution for setting up line direction is
+thus to do it explicitly.
+
+Required Properties:
+
+ - compatible: should be one of the following.
+ - "maxim,max7328": For the Maxim MAX7378
+ - "maxim,max7329": For the Maxim MAX7329
+ - "nxp,pca8574": For the NXP PCA8574
+ - "nxp,pca8575": For the NXP PCA8575
+ - "nxp,pca9670": For the NXP PCA9670
+ - "nxp,pca9671": For the NXP PCA9671
+ - "nxp,pca9672": For the NXP PCA9672
+ - "nxp,pca9673": For the NXP PCA9673
+ - "nxp,pca9674": For the NXP PCA9674
+ - "nxp,pca9675": For the NXP PCA9675
+ - "nxp,pcf8574": For the NXP PCF8574
+ - "nxp,pcf8574a": For the NXP PCF8574A
+ - "nxp,pcf8575": For the NXP PCF8575
+ - "ti,tca9554": For the TI TCA9554
+
+ - reg: I2C slave address.
+
+ - gpio-controller: Marks the device node as a gpio controller.
+ - #gpio-cells: Should be 2. The first cell is the GPIO number and the second
+ cell specifies GPIO flags, as defined in <dt-bindings/gpio/gpio.h>. Only the
+ GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW flags are supported.
+
+Optional Properties:
+
+ - lines-initial-states: Bitmask that specifies the initial state of each
+ line. When a bit is set to zero, the corresponding line will be initialized to
+ the input (pulled-up) state. When the bit is set to one, the line will be
+ initialized the low-level output state. If the property is not specified
+ all lines will be initialized to the input state.
+
+ The I/O expander can detect input state changes, and thus optionally act as
+ an interrupt controller. When the expander interrupt line is connected all the
+ following properties must be set. For more information please see the
+ interrupt controller device tree bindings documentation available at
+ Documentation/devicetree/bindings/interrupt-controller/interrupts.txt.
+
+ - interrupt-controller: Identifies the node as an interrupt controller.
+ - #interrupt-cells: Number of cells to encode an interrupt source, shall be 2.
+ - interrupt-parent: phandle of the parent interrupt controller.
+ - interrupts: Interrupt specifier for the controllers interrupt.
+
+
+Please refer to gpio.txt in this directory for details of the common GPIO
+bindings used by client devices.
+
+Example: PCF8575 I/O expander node
+
+ pcf8575: gpio at 20 {
+ compatible = "nxp,pcf8575";
+ reg = <0x20>;
+ interrupt-parent = <&irqpin2>;
+ interrupts = <3 0>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 73b862dc0b21..64cf221abefa 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -79,6 +79,13 @@ config PM8916_GPIO
Power and reset buttons are placed in "pm8916_key" bank and
have gpio numbers 0 and 1 respectively.
+config PCF8575_GPIO
+ bool "PCF8575 I2C GPIO Expander driver"
+ depends on DM_GPIO && DM_I2C
+ help
+ Support for PCF8575 I2C 16-bit GPIO expander. Most of these
+ chips are from NXP and TI.
+
config ROCKCHIP_GPIO
bool "Rockchip GPIO driver"
depends on DM_GPIO
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index 792d19186aad..89392264a4ab 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -56,4 +56,5 @@ obj-$(CONFIG_HIKEY_GPIO) += hi6220_gpio.o
obj-$(CONFIG_PIC32_GPIO) += pic32_gpio.o
obj-$(CONFIG_MVEBU_GPIO) += mvebu_gpio.o
obj-$(CONFIG_MSM_GPIO) += msm_gpio.o
+obj-$(CONFIG_$(SPL_)PCF8575_GPIO) += pcf8575_gpio.o
obj-$(CONFIG_PM8916_GPIO) += pm8916_gpio.o
diff --git a/drivers/gpio/pcf8575_gpio.c b/drivers/gpio/pcf8575_gpio.c
new file mode 100644
index 000000000000..2bda0ff9966b
--- /dev/null
+++ b/drivers/gpio/pcf8575_gpio.c
@@ -0,0 +1,180 @@
+/*
+ * PCF8575 I2C GPIO EXPANDER DRIVER
+ *
+ * Copyright (C) 2016 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * Vignesh R <vigneshr@ti.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0
+ *
+ *
+ * Driver for TI PCF-8575 16-bit I2C gpio expander. Based on
+ * gpio-pcf857x Linux Kernel(v4.7) driver.
+ *
+ * Copyright (C) 2007 David Brownell
+ *
+ */
+
+/*
+ * NOTE: The driver and devicetree bindings are borrowed from Linux
+ * Kernel, but driver does not support all PCF857x devices. It currently
+ * supports PCF8575 16-bit expander by TI and NXP.
+ *
+ * TODO(vigneshr at ti.com):
+ * Support 8 bit PCF857x compatible expanders.
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <i2c.h>
+#include <asm-generic/gpio.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+struct pcf8575_chip {
+ int gpio_count; /* No. GPIOs supported by the chip */
+
+ /* NOTE: these chips have strange "quasi-bidirectional" I/O pins.
+ * We can't actually know whether a pin is configured (a) as output
+ * and driving the signal low, or (b) as input and reporting a low
+ * value ... without knowing the last value written since the chip
+ * came out of reset (if any). We can't read the latched output.
+ * In short, the only reliable solution for setting up pin direction
+ * is to do it explicitly.
+ *
+ * Using "out" avoids that trouble. When left initialized to zero,
+ * our software copy of the "latch" then matches the chip's all-ones
+ * reset state. Otherwise it flags pins to be driven low.
+ */
+ unsigned int out; /* software latch */
+ const char *bank_name; /* Name of the expander bank */
+};
+
+/* Read/Write to 16-bit I/O expander */
+
+static int pcf8575_i2c_write_le16(struct udevice *dev, unsigned int word)
+{
+ struct dm_i2c_chip *chip = dev_get_parent_platdata(dev);
+ u8 buf[2] = { word & 0xff, word >> 8, };
+ int ret;
+
+ ret = dm_i2c_write(dev, 0, buf, 2);
+ if (ret)
+ printf("%s i2c write failed to addr %x\n", __func__,
+ chip->chip_addr);
+
+ return ret;
+}
+
+static int pcf8575_i2c_read_le16(struct udevice *dev)
+{
+ struct dm_i2c_chip *chip = dev_get_parent_platdata(dev);
+ u8 buf[2];
+ int ret;
+
+ ret = dm_i2c_read(dev, 0, buf, 2);
+ if (ret) {
+ printf("%s i2c read failed from addr %x\n", __func__,
+ chip->chip_addr);
+ return ret;
+ }
+
+ return (buf[1] << 8) | buf[0];
+}
+
+static int pcf8575_direction_input(struct udevice *dev, unsigned offset)
+{
+ struct pcf8575_chip *plat = dev_get_platdata(dev);
+ int status;
+
+ plat->out |= BIT(offset);
+ status = pcf8575_i2c_write_le16(dev, plat->out);
+
+ return status;
+}
+
+static int pcf8575_direction_output(struct udevice *dev,
+ unsigned int offset, int value)
+{
+ struct pcf8575_chip *plat = dev_get_platdata(dev);
+ int ret;
+
+ if (value)
+ plat->out |= BIT(offset);
+ else
+ plat->out &= ~BIT(offset);
+
+ ret = pcf8575_i2c_write_le16(dev, plat->out);
+
+ return ret;
+}
+
+static int pcf8575_get_value(struct udevice *dev, unsigned int offset)
+{
+ int value;
+
+ value = pcf8575_i2c_read_le16(dev);
+
+ return (value < 0) ? value : ((value & BIT(offset)) >> offset);
+}
+
+static int pcf8575_set_value(struct udevice *dev, unsigned int offset,
+ int value)
+{
+ return pcf8575_direction_output(dev, offset, value);
+}
+
+static int pcf8575_ofdata_platdata(struct udevice *dev)
+{
+ struct pcf8575_chip *plat = dev_get_platdata(dev);
+ struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
+
+ int n_latch;
+
+ uc_priv->gpio_count = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
+ "gpio-count", 16);
+ uc_priv->bank_name = fdt_getprop(gd->fdt_blob, dev->of_offset,
+ "gpio-bank-name", NULL);
+ if (!uc_priv->bank_name)
+ uc_priv->bank_name = fdt_get_name(gd->fdt_blob,
+ dev->of_offset, NULL);
+
+ n_latch = fdtdec_get_uint(gd->fdt_blob, dev->of_offset,
+ "lines-initial-states", 0);
+ plat->out = ~n_latch;
+
+ return 0;
+}
+
+static int pcf8575_gpio_probe(struct udevice *dev)
+{
+ struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
+
+ debug("%s GPIO controller with %d gpios probed\n",
+ uc_priv->bank_name, uc_priv->gpio_count);
+
+ return 0;
+}
+
+static const struct dm_gpio_ops pcf8575_gpio_ops = {
+ .direction_input = pcf8575_direction_input,
+ .direction_output = pcf8575_direction_output,
+ .get_value = pcf8575_get_value,
+ .set_value = pcf8575_set_value,
+};
+
+static const struct udevice_id pcf8575_gpio_ids[] = {
+ { .compatible = "nxp,pcf8575" },
+ { .compatible = "ti,pcf8575" },
+ { }
+};
+
+U_BOOT_DRIVER(gpio_pcf8575) = {
+ .name = "gpio_pcf8575",
+ .id = UCLASS_GPIO,
+ .ops = &pcf8575_gpio_ops,
+ .of_match = pcf8575_gpio_ids,
+ .ofdata_to_platdata = pcf8575_ofdata_platdata,
+ .probe = pcf8575_gpio_probe,
+ .platdata_auto_alloc_size = sizeof(struct pcf8575_chip),
+};
--
2.9.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 2/5] ARM: dra7xx_evm: Enable support for TI PCF8575
2016-08-02 4:44 [U-Boot] [PATCH v3 0/5] Add support for TI PCF8575 I2C GPIO expander Vignesh R
2016-08-02 4:44 ` [U-Boot] [PATCH v3 1/5] gpio: Add driver " Vignesh R
@ 2016-08-02 4:44 ` Vignesh R
2016-08-02 6:47 ` Mugunthan V N
` (2 more replies)
2016-08-02 4:44 ` [U-Boot] [PATCH v3 3/5] ARM: dts: dra7xx: Add u-boot specific property for PCF8575 nodes Vignesh R
` (2 subsequent siblings)
4 siblings, 3 replies; 18+ messages in thread
From: Vignesh R @ 2016-08-02 4:44 UTC (permalink / raw)
To: u-boot
On DRA7, pcf chip present at address 0x21 on i2c1, is used to
switch between cpsw slave0 and slave1. Hence, enable PCF
driver for the same.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
v3: Pick up CONFIG_PCF8575_GPIO via Kconfig.
configs/dra7xx_evm_defconfig | 1 +
configs/dra7xx_hs_evm_defconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig
index 1d27e52ac38b..81d2a0e30a10 100644
--- a/configs/dra7xx_evm_defconfig
+++ b/configs/dra7xx_evm_defconfig
@@ -58,3 +58,4 @@ CONFIG_SPL_OF_LIBFDT=y
CONFIG_SPL_LOAD_FIT=y
CONFIG_OF_LIST="dra7-evm dra72-evm"
CONFIG_DM_I2C=y
+CONFIG_PCF8575_GPIO=y
diff --git a/configs/dra7xx_hs_evm_defconfig b/configs/dra7xx_hs_evm_defconfig
index faf9cd57e474..ab68b1ceaca8 100644
--- a/configs/dra7xx_hs_evm_defconfig
+++ b/configs/dra7xx_hs_evm_defconfig
@@ -61,3 +61,4 @@ CONFIG_SPL_LOAD_FIT=y
CONFIG_SPL_FIT_IMAGE_POST_PROCESS=y
CONFIG_OF_LIST="dra7-evm dra72-evm"
CONFIG_DM_I2C=y
+CONFIG_PCF8575_GPIO=y
--
2.9.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 3/5] ARM: dts: dra7xx: Add u-boot specific property for PCF8575 nodes
2016-08-02 4:44 [U-Boot] [PATCH v3 0/5] Add support for TI PCF8575 I2C GPIO expander Vignesh R
2016-08-02 4:44 ` [U-Boot] [PATCH v3 1/5] gpio: Add driver " Vignesh R
2016-08-02 4:44 ` [U-Boot] [PATCH v3 2/5] ARM: dra7xx_evm: Enable support for TI PCF8575 Vignesh R
@ 2016-08-02 4:44 ` Vignesh R
2016-08-02 6:48 ` Mugunthan V N
` (2 more replies)
2016-08-02 4:44 ` [U-Boot] [PATCH v3 4/5] net: cpsw: Add support to drive gpios for ethernet to be functional Vignesh R
2016-08-02 4:44 ` [U-Boot] [PATCH v3 5/5] ARM: dts: dra72-evm: Add mode-gpios entry for mac node Vignesh R
4 siblings, 3 replies; 18+ messages in thread
From: Vignesh R @ 2016-08-02 4:44 UTC (permalink / raw)
To: u-boot
PCF8575 does not have any registers hence, offset field needs to be
ignored for i2c read/write. Therefore populate u-boot,i2c-offset-len
with 0 in PCF8575 DT nodes.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
v3: New patch.
arch/arm/dts/dra7-evm.dts | 1 +
arch/arm/dts/dra72-evm.dts | 2 ++
2 files changed, 3 insertions(+)
diff --git a/arch/arm/dts/dra7-evm.dts b/arch/arm/dts/dra7-evm.dts
index 429b9edc1b2b..fc62904621f5 100644
--- a/arch/arm/dts/dra7-evm.dts
+++ b/arch/arm/dts/dra7-evm.dts
@@ -415,6 +415,7 @@
interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
interrupt-controller;
#interrupt-cells = <2>;
+ u-boot,i2c-offset-len = <0>;
};
};
diff --git a/arch/arm/dts/dra72-evm.dts b/arch/arm/dts/dra72-evm.dts
index ced2f1166d8c..06fb3d895a27 100644
--- a/arch/arm/dts/dra72-evm.dts
+++ b/arch/arm/dts/dra72-evm.dts
@@ -348,6 +348,7 @@
interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
interrupt-controller;
#interrupt-cells = <2>;
+ u-boot,i2c-offset-len = <0>;
};
};
@@ -369,6 +370,7 @@
* VIN6_SEL_S0 is low, thus selecting McASP3 over VIN6
*/
lines-initial-states = <0x0f2b>;
+ u-boot,i2c-offset-len = <0>;
};
};
--
2.9.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 4/5] net: cpsw: Add support to drive gpios for ethernet to be functional
2016-08-02 4:44 [U-Boot] [PATCH v3 0/5] Add support for TI PCF8575 I2C GPIO expander Vignesh R
` (2 preceding siblings ...)
2016-08-02 4:44 ` [U-Boot] [PATCH v3 3/5] ARM: dts: dra7xx: Add u-boot specific property for PCF8575 nodes Vignesh R
@ 2016-08-02 4:44 ` Vignesh R
2016-08-02 6:48 ` Mugunthan V N
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-08-02 4:44 ` [U-Boot] [PATCH v3 5/5] ARM: dts: dra72-evm: Add mode-gpios entry for mac node Vignesh R
4 siblings, 2 replies; 18+ messages in thread
From: Vignesh R @ 2016-08-02 4:44 UTC (permalink / raw)
To: u-boot
On DRA72 EVM, cpsw slaves may be muxed with other modules. This
selection is controlled by a pcf gpio line. Add support for cpsw driver
to acquire mode-gpios and select the appropriate slave using gpio APIs.
Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
---
v3: No change
drivers/net/cpsw.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
index 2ce4ec69f1df..774b021e356e 100644
--- a/drivers/net/cpsw.c
+++ b/drivers/net/cpsw.c
@@ -22,6 +22,7 @@
#include <netdev.h>
#include <cpsw.h>
#include <asm/errno.h>
+#include <asm/gpio.h>
#include <asm/io.h>
#include <phy.h>
#include <asm/arch/cpu.h>
@@ -1152,12 +1153,14 @@ static int cpsw_eth_ofdata_to_platdata(struct udevice *dev)
{
struct eth_pdata *pdata = dev_get_platdata(dev);
struct cpsw_priv *priv = dev_get_priv(dev);
+ struct gpio_desc *mode_gpios;
const char *phy_mode;
const void *fdt = gd->fdt_blob;
int node = dev->of_offset;
int subnode;
int slave_index = 0;
int active_slave;
+ int num_mode_gpios;
int ret;
pdata->iobase = dev_get_addr(dev);
@@ -1203,6 +1206,15 @@ static int cpsw_eth_ofdata_to_platdata(struct udevice *dev)
return -ENOENT;
}
+ num_mode_gpios = gpio_get_list_count(dev, "mode-gpios");
+ if (num_mode_gpios > 0) {
+ mode_gpios = malloc(sizeof(struct gpio_desc) *
+ num_mode_gpios);
+ gpio_request_list_by_name(dev, "mode-gpios", mode_gpios,
+ num_mode_gpios, GPIOD_IS_OUT);
+ free(mode_gpios);
+ }
+
active_slave = fdtdec_get_int(fdt, node, "active_slave", 0);
priv->data.active_slave = active_slave;
--
2.9.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 5/5] ARM: dts: dra72-evm: Add mode-gpios entry for mac node
2016-08-02 4:44 [U-Boot] [PATCH v3 0/5] Add support for TI PCF8575 I2C GPIO expander Vignesh R
` (3 preceding siblings ...)
2016-08-02 4:44 ` [U-Boot] [PATCH v3 4/5] net: cpsw: Add support to drive gpios for ethernet to be functional Vignesh R
@ 2016-08-02 4:44 ` Vignesh R
2016-08-02 6:48 ` Mugunthan V N
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
4 siblings, 2 replies; 18+ messages in thread
From: Vignesh R @ 2016-08-02 4:44 UTC (permalink / raw)
To: u-boot
On DRA72 EVM, cpsw slave1 is muxed with VIN2A, hence switch to cpsw
slave0 for ethernet. This is controlled by pcf gpio line. Add
appropriate mode-gpios DT entry so that driver can select the required
slave.
Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
---
v3: No change
arch/arm/dts/dra72-evm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/dra72-evm.dts b/arch/arm/dts/dra72-evm.dts
index 06fb3d895a27..9e395ac4564f 100644
--- a/arch/arm/dts/dra72-evm.dts
+++ b/arch/arm/dts/dra72-evm.dts
@@ -578,6 +578,7 @@
pinctrl-names = "default", "sleep";
pinctrl-0 = <&cpsw_default>;
pinctrl-1 = <&cpsw_sleep>;
+ mode-gpios = <&pcf_gpio_21 4 GPIO_ACTIVE_HIGH>;
};
&cpsw_emac1 {
@@ -589,7 +590,6 @@
pinctrl-names = "default", "sleep";
pinctrl-0 = <&davinci_mdio_default>;
pinctrl-1 = <&davinci_mdio_sleep>;
- active_slave = <1>;
};
&dcan1 {
--
2.9.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 1/5] gpio: Add driver for TI PCF8575 I2C GPIO expander
2016-08-02 4:44 ` [U-Boot] [PATCH v3 1/5] gpio: Add driver " Vignesh R
@ 2016-08-02 6:47 ` Mugunthan V N
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
1 sibling, 0 replies; 18+ messages in thread
From: Mugunthan V N @ 2016-08-02 6:47 UTC (permalink / raw)
To: u-boot
On Tuesday 02 August 2016 10:14 AM, Vignesh R wrote:
> TI's PCF8575 is a 16-bit I2C GPIO expander.The device features a
> 16-bit quasi-bidirectional I/O ports. Each quasi-bidirectional I/O can
> be used as an input or output without the use of a data-direction
> control signal. The I/Os should be high before being used as inputs.
> Read the device documentation for more details[1].
>
> This driver is based on pcf857x driver available in Linux v4.7 kernel.
> It supports basic reading and writing of gpio pins.
>
> [1] http://www.ti.com/lit/ds/symlink/pcf8575.pdf
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 2/5] ARM: dra7xx_evm: Enable support for TI PCF8575
2016-08-02 4:44 ` [U-Boot] [PATCH v3 2/5] ARM: dra7xx_evm: Enable support for TI PCF8575 Vignesh R
@ 2016-08-02 6:47 ` Mugunthan V N
2016-08-02 17:39 ` Tom Rini
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
2 siblings, 0 replies; 18+ messages in thread
From: Mugunthan V N @ 2016-08-02 6:47 UTC (permalink / raw)
To: u-boot
On Tuesday 02 August 2016 10:14 AM, Vignesh R wrote:
> On DRA7, pcf chip present at address 0x21 on i2c1, is used to
> switch between cpsw slave0 and slave1. Hence, enable PCF
> driver for the same.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 3/5] ARM: dts: dra7xx: Add u-boot specific property for PCF8575 nodes
2016-08-02 4:44 ` [U-Boot] [PATCH v3 3/5] ARM: dts: dra7xx: Add u-boot specific property for PCF8575 nodes Vignesh R
@ 2016-08-02 6:48 ` Mugunthan V N
2016-08-02 17:39 ` Tom Rini
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
2 siblings, 0 replies; 18+ messages in thread
From: Mugunthan V N @ 2016-08-02 6:48 UTC (permalink / raw)
To: u-boot
On Tuesday 02 August 2016 10:14 AM, Vignesh R wrote:
> PCF8575 does not have any registers hence, offset field needs to be
> ignored for i2c read/write. Therefore populate u-boot,i2c-offset-len
> with 0 in PCF8575 DT nodes.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 4/5] net: cpsw: Add support to drive gpios for ethernet to be functional
2016-08-02 4:44 ` [U-Boot] [PATCH v3 4/5] net: cpsw: Add support to drive gpios for ethernet to be functional Vignesh R
@ 2016-08-02 6:48 ` Mugunthan V N
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
1 sibling, 0 replies; 18+ messages in thread
From: Mugunthan V N @ 2016-08-02 6:48 UTC (permalink / raw)
To: u-boot
On Tuesday 02 August 2016 10:14 AM, Vignesh R wrote:
> On DRA72 EVM, cpsw slaves may be muxed with other modules. This
> selection is controlled by a pcf gpio line. Add support for cpsw driver
> to acquire mode-gpios and select the appropriate slave using gpio APIs.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 5/5] ARM: dts: dra72-evm: Add mode-gpios entry for mac node
2016-08-02 4:44 ` [U-Boot] [PATCH v3 5/5] ARM: dts: dra72-evm: Add mode-gpios entry for mac node Vignesh R
@ 2016-08-02 6:48 ` Mugunthan V N
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
1 sibling, 0 replies; 18+ messages in thread
From: Mugunthan V N @ 2016-08-02 6:48 UTC (permalink / raw)
To: u-boot
On Tuesday 02 August 2016 10:14 AM, Vignesh R wrote:
> On DRA72 EVM, cpsw slave1 is muxed with VIN2A, hence switch to cpsw
> slave0 for ethernet. This is controlled by pcf gpio line. Add
> appropriate mode-gpios DT entry so that driver can select the required
> slave.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 2/5] ARM: dra7xx_evm: Enable support for TI PCF8575
2016-08-02 4:44 ` [U-Boot] [PATCH v3 2/5] ARM: dra7xx_evm: Enable support for TI PCF8575 Vignesh R
2016-08-02 6:47 ` Mugunthan V N
@ 2016-08-02 17:39 ` Tom Rini
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
2 siblings, 0 replies; 18+ messages in thread
From: Tom Rini @ 2016-08-02 17:39 UTC (permalink / raw)
To: u-boot
On Tue, Aug 02, 2016 at 10:14:25AM +0530, Vignesh R wrote:
> On DRA7, pcf chip present at address 0x21 on i2c1, is used to
> switch between cpsw slave0 and slave1. Hence, enable PCF
> driver for the same.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160802/74df7fb9/attachment.sig>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 3/5] ARM: dts: dra7xx: Add u-boot specific property for PCF8575 nodes
2016-08-02 4:44 ` [U-Boot] [PATCH v3 3/5] ARM: dts: dra7xx: Add u-boot specific property for PCF8575 nodes Vignesh R
2016-08-02 6:48 ` Mugunthan V N
@ 2016-08-02 17:39 ` Tom Rini
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
2 siblings, 0 replies; 18+ messages in thread
From: Tom Rini @ 2016-08-02 17:39 UTC (permalink / raw)
To: u-boot
On Tue, Aug 02, 2016 at 10:14:26AM +0530, Vignesh R wrote:
> PCF8575 does not have any registers hence, offset field needs to be
> ignored for i2c read/write. Therefore populate u-boot,i2c-offset-len
> with 0 in PCF8575 DT nodes.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160802/0efeb001/attachment.sig>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 1/5] gpio: Add driver for TI PCF8575 I2C GPIO expander
2016-08-02 4:44 ` [U-Boot] [PATCH v3 1/5] gpio: Add driver " Vignesh R
2016-08-02 6:47 ` Mugunthan V N
@ 2016-08-10 0:45 ` Tom Rini
1 sibling, 0 replies; 18+ messages in thread
From: Tom Rini @ 2016-08-10 0:45 UTC (permalink / raw)
To: u-boot
On Tue, Aug 02, 2016 at 10:14:24AM +0530, Vignesh R wrote:
> TI's PCF8575 is a 16-bit I2C GPIO expander.The device features a
> 16-bit quasi-bidirectional I/O ports. Each quasi-bidirectional I/O can
> be used as an input or output without the use of a data-direction
> control signal. The I/Os should be high before being used as inputs.
> Read the device documentation for more details[1].
>
> This driver is based on pcf857x driver available in Linux v4.7 kernel.
> It supports basic reading and writing of gpio pins.
>
> [1] http://www.ti.com/lit/ds/symlink/pcf8575.pdf
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160809/84a3c47c/attachment.sig>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 2/5] ARM: dra7xx_evm: Enable support for TI PCF8575
2016-08-02 4:44 ` [U-Boot] [PATCH v3 2/5] ARM: dra7xx_evm: Enable support for TI PCF8575 Vignesh R
2016-08-02 6:47 ` Mugunthan V N
2016-08-02 17:39 ` Tom Rini
@ 2016-08-10 0:45 ` Tom Rini
2 siblings, 0 replies; 18+ messages in thread
From: Tom Rini @ 2016-08-10 0:45 UTC (permalink / raw)
To: u-boot
On Tue, Aug 02, 2016 at 10:14:25AM +0530, Vignesh R wrote:
> On DRA7, pcf chip present at address 0x21 on i2c1, is used to
> switch between cpsw slave0 and slave1. Hence, enable PCF
> driver for the same.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160809/5587a723/attachment.sig>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 3/5] ARM: dts: dra7xx: Add u-boot specific property for PCF8575 nodes
2016-08-02 4:44 ` [U-Boot] [PATCH v3 3/5] ARM: dts: dra7xx: Add u-boot specific property for PCF8575 nodes Vignesh R
2016-08-02 6:48 ` Mugunthan V N
2016-08-02 17:39 ` Tom Rini
@ 2016-08-10 0:45 ` Tom Rini
2 siblings, 0 replies; 18+ messages in thread
From: Tom Rini @ 2016-08-10 0:45 UTC (permalink / raw)
To: u-boot
On Tue, Aug 02, 2016 at 10:14:26AM +0530, Vignesh R wrote:
> PCF8575 does not have any registers hence, offset field needs to be
> ignored for i2c read/write. Therefore populate u-boot,i2c-offset-len
> with 0 in PCF8575 DT nodes.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160809/2409bd54/attachment.sig>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 4/5] net: cpsw: Add support to drive gpios for ethernet to be functional
2016-08-02 4:44 ` [U-Boot] [PATCH v3 4/5] net: cpsw: Add support to drive gpios for ethernet to be functional Vignesh R
2016-08-02 6:48 ` Mugunthan V N
@ 2016-08-10 0:45 ` Tom Rini
1 sibling, 0 replies; 18+ messages in thread
From: Tom Rini @ 2016-08-10 0:45 UTC (permalink / raw)
To: u-boot
On Tue, Aug 02, 2016 at 10:14:27AM +0530, Vignesh R wrote:
> On DRA72 EVM, cpsw slaves may be muxed with other modules. This
> selection is controlled by a pcf gpio line. Add support for cpsw driver
> to acquire mode-gpios and select the appropriate slave using gpio APIs.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160809/1075a480/attachment.sig>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 5/5] ARM: dts: dra72-evm: Add mode-gpios entry for mac node
2016-08-02 4:44 ` [U-Boot] [PATCH v3 5/5] ARM: dts: dra72-evm: Add mode-gpios entry for mac node Vignesh R
2016-08-02 6:48 ` Mugunthan V N
@ 2016-08-10 0:45 ` Tom Rini
1 sibling, 0 replies; 18+ messages in thread
From: Tom Rini @ 2016-08-10 0:45 UTC (permalink / raw)
To: u-boot
On Tue, Aug 02, 2016 at 10:14:28AM +0530, Vignesh R wrote:
> On DRA72 EVM, cpsw slave1 is muxed with VIN2A, hence switch to cpsw
> slave0 for ethernet. This is controlled by pcf gpio line. Add
> appropriate mode-gpios DT entry so that driver can select the required
> slave.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160809/3aec5451/attachment.sig>
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2016-08-10 0:45 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 4:44 [U-Boot] [PATCH v3 0/5] Add support for TI PCF8575 I2C GPIO expander Vignesh R
2016-08-02 4:44 ` [U-Boot] [PATCH v3 1/5] gpio: Add driver " Vignesh R
2016-08-02 6:47 ` Mugunthan V N
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-08-02 4:44 ` [U-Boot] [PATCH v3 2/5] ARM: dra7xx_evm: Enable support for TI PCF8575 Vignesh R
2016-08-02 6:47 ` Mugunthan V N
2016-08-02 17:39 ` Tom Rini
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-08-02 4:44 ` [U-Boot] [PATCH v3 3/5] ARM: dts: dra7xx: Add u-boot specific property for PCF8575 nodes Vignesh R
2016-08-02 6:48 ` Mugunthan V N
2016-08-02 17:39 ` Tom Rini
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-08-02 4:44 ` [U-Boot] [PATCH v3 4/5] net: cpsw: Add support to drive gpios for ethernet to be functional Vignesh R
2016-08-02 6:48 ` Mugunthan V N
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-08-02 4:44 ` [U-Boot] [PATCH v3 5/5] ARM: dts: dra72-evm: Add mode-gpios entry for mac node Vignesh R
2016-08-02 6:48 ` Mugunthan V N
2016-08-10 0:45 ` [U-Boot] [U-Boot, v3, " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.