* [PATCH] HID: change KEY_DATA from 0x275 to 0x277
@ 2016-11-28 20:49 Ping Cheng
2016-11-28 21:20 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Ping Cheng @ 2016-11-28 20:49 UTC (permalink / raw)
To: linux-input; +Cc: jkosina, dmitry.torokhov, Ping Cheng, Ping Cheng
0x275 is used by KEY_FASTREVERSE. Or, was that on purpose to use
the same value as KEY_FASTREVERSE for KEY_DATA?
Signed-off-by: Ping Cheng <ping.cheng@wacom.com>
---
include/uapi/linux/input-event-codes.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index d6d071f..3af60ee 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -640,7 +640,7 @@
* Control a data application associated with the currently viewed channel,
* e.g. teletext or data broadcast application (MHEG, MHP, HbbTV, etc.)
*/
-#define KEY_DATA 0x275
+#define KEY_DATA 0x277
#define BTN_TRIGGER_HAPPY 0x2c0
#define BTN_TRIGGER_HAPPY1 0x2c0
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: change KEY_DATA from 0x275 to 0x277
2016-11-28 20:49 [PATCH] HID: change KEY_DATA from 0x275 to 0x277 Ping Cheng
@ 2016-11-28 21:20 ` Dmitry Torokhov
2016-11-29 7:09 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2016-11-28 21:20 UTC (permalink / raw)
To: Ping Cheng, Kamil Debski, Hans Verkuil
Cc: linux-input, jkosina, Ping Cheng, Ping Cheng
On Mon, Nov 28, 2016 at 12:49:24PM -0800, Ping Cheng wrote:
> 0x275 is used by KEY_FASTREVERSE. Or, was that on purpose to use
> the same value as KEY_FASTREVERSE for KEY_DATA?
>
> Signed-off-by: Ping Cheng <ping.cheng@wacom.com>
Ugh, that's not good. I guess we should indeed change this and make sure
it goes to stable.
Hans, Kamil, I do not suppose anyone actually been using KEY_DATA as it
would have been clashing with KEY_FASTREVERSE?
Thanks.
> ---
> include/uapi/linux/input-event-codes.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index d6d071f..3af60ee 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -640,7 +640,7 @@
> * Control a data application associated with the currently viewed channel,
> * e.g. teletext or data broadcast application (MHEG, MHP, HbbTV, etc.)
> */
> -#define KEY_DATA 0x275
> +#define KEY_DATA 0x277
>
> #define BTN_TRIGGER_HAPPY 0x2c0
> #define BTN_TRIGGER_HAPPY1 0x2c0
> --
> 2.7.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: change KEY_DATA from 0x275 to 0x277
2016-11-28 21:20 ` Dmitry Torokhov
@ 2016-11-29 7:09 ` Hans Verkuil
0 siblings, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2016-11-29 7:09 UTC (permalink / raw)
To: Dmitry Torokhov, Ping Cheng, Kamil Debski, Hans Verkuil
Cc: linux-input, jkosina, Ping Cheng, Ping Cheng
On 11/28/2016 10:20 PM, Dmitry Torokhov wrote:
> On Mon, Nov 28, 2016 at 12:49:24PM -0800, Ping Cheng wrote:
>> 0x275 is used by KEY_FASTREVERSE. Or, was that on purpose to use
>> the same value as KEY_FASTREVERSE for KEY_DATA?
>>
>> Signed-off-by: Ping Cheng <ping.cheng@wacom.com>
>
> Ugh, that's not good. I guess we should indeed change this and make sure
> it goes to stable.
>
> Hans, Kamil, I do not suppose anyone actually been using KEY_DATA as it
> would have been clashing with KEY_FASTREVERSE?
No problem. These CEC event defines are only used by the CEC framework which
as of 4.9 is still in staging (will go out of staging in 4.10). So it is no
problem changing this. Nor has anyone been using this.
So:
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Thanks!
Hans
>
> Thanks.
>
>> ---
>> include/uapi/linux/input-event-codes.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
>> index d6d071f..3af60ee 100644
>> --- a/include/uapi/linux/input-event-codes.h
>> +++ b/include/uapi/linux/input-event-codes.h
>> @@ -640,7 +640,7 @@
>> * Control a data application associated with the currently viewed channel,
>> * e.g. teletext or data broadcast application (MHEG, MHP, HbbTV, etc.)
>> */
>> -#define KEY_DATA 0x275
>> +#define KEY_DATA 0x277
>>
>> #define BTN_TRIGGER_HAPPY 0x2c0
>> #define BTN_TRIGGER_HAPPY1 0x2c0
>> --
>> 2.7.4
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-29 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-28 20:49 [PATCH] HID: change KEY_DATA from 0x275 to 0x277 Ping Cheng
2016-11-28 21:20 ` Dmitry Torokhov
2016-11-29 7:09 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.