* [Qemu-devel] [PATCH] qga: improve fsfreeze documentations
@ 2017-04-03 9:54 Marc-André Lureau
2017-04-03 11:09 ` Vinzenz Feenstra
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marc-André Lureau @ 2017-04-03 9:54 UTC (permalink / raw)
To: qemu-devel; +Cc: mdroth, Marc-André Lureau
Some users find the fsfreeze behaviour confusing. Add some notes about
invalid mount points and Windows usage.
Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1436976
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
qga/qapi-schema.json | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index a02dbf2d18..8d901f556a 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -426,7 +426,13 @@
##
# @guest-fsfreeze-freeze:
#
-# Sync and freeze all freezable, local guest filesystems
+# Sync and freeze all freezable, local guest filesystems. If this
+# command succeeded, you may call @guest-fsfreeze-thaw later to
+# unfreeze.
+#
+# Note: On Windows, the command is implemented with the help of a
+# Volume Shadow-copy Service DLL helper. The frozen state is limited
+# for up to 10 seconds by VSS.
#
# Returns: Number of file systems currently frozen. On error, all filesystems
# will be thawed.
@@ -439,10 +445,12 @@
##
# @guest-fsfreeze-freeze-list:
#
-# Sync and freeze specified guest filesystems
+# Sync and freeze specified guest filesystems.
+# See also @guest-fsfreeze-freeze.
#
# @mountpoints: an array of mountpoints of filesystems to be frozen.
# If omitted, every mounted filesystem is frozen.
+# Invalid mount points are ignored.
#
# Returns: Number of file systems currently frozen. On error, all filesystems
# will be thawed.
--
2.12.0.191.gc5d8de91d
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qga: improve fsfreeze documentations
2017-04-03 9:54 [Qemu-devel] [PATCH] qga: improve fsfreeze documentations Marc-André Lureau
@ 2017-04-03 11:09 ` Vinzenz Feenstra
2017-04-13 14:59 ` Vinzenz Feenstra
2017-04-13 20:30 ` Michael Roth
2 siblings, 0 replies; 4+ messages in thread
From: Vinzenz Feenstra @ 2017-04-03 11:09 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: QEMU Developers, mdroth
LGTM
> On Apr 3, 2017, at 11:54 AM, Marc-André Lureau <marcandre.lureau@redhat.com> wrote:
>
> Some users find the fsfreeze behaviour confusing. Add some notes about
> invalid mount points and Windows usage.
>
> Related to:
> https://bugzilla.redhat.com/show_bug.cgi?id=1436976
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/qapi-schema.json | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index a02dbf2d18..8d901f556a 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -426,7 +426,13 @@
> ##
> # @guest-fsfreeze-freeze:
> #
> -# Sync and freeze all freezable, local guest filesystems
> +# Sync and freeze all freezable, local guest filesystems. If this
> +# command succeeded, you may call @guest-fsfreeze-thaw later to
> +# unfreeze.
> +#
> +# Note: On Windows, the command is implemented with the help of a
> +# Volume Shadow-copy Service DLL helper. The frozen state is limited
> +# for up to 10 seconds by VSS.
> #
> # Returns: Number of file systems currently frozen. On error, all filesystems
> # will be thawed.
> @@ -439,10 +445,12 @@
> ##
> # @guest-fsfreeze-freeze-list:
> #
> -# Sync and freeze specified guest filesystems
> +# Sync and freeze specified guest filesystems.
> +# See also @guest-fsfreeze-freeze.
> #
> # @mountpoints: an array of mountpoints of filesystems to be frozen.
> # If omitted, every mounted filesystem is frozen.
> +# Invalid mount points are ignored.
> #
> # Returns: Number of file systems currently frozen. On error, all filesystems
> # will be thawed.
> --
> 2.12.0.191.gc5d8de91d
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qga: improve fsfreeze documentations
2017-04-03 9:54 [Qemu-devel] [PATCH] qga: improve fsfreeze documentations Marc-André Lureau
2017-04-03 11:09 ` Vinzenz Feenstra
@ 2017-04-13 14:59 ` Vinzenz Feenstra
2017-04-13 20:30 ` Michael Roth
2 siblings, 0 replies; 4+ messages in thread
From: Vinzenz Feenstra @ 2017-04-13 14:59 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, mdroth
Reviewed-by: Vinzenz Feenstra <vfeenstr@redhat.com <mailto:marcandre.lureau@redhat.com>>
> On Apr 3, 2017, at 11:54 AM, Marc-André Lureau <marcandre.lureau@redhat.com> wrote:
>
> Some users find the fsfreeze behaviour confusing. Add some notes about
> invalid mount points and Windows usage.
>
> Related to:
> https://bugzilla.redhat.com/show_bug.cgi?id=1436976
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/qapi-schema.json | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index a02dbf2d18..8d901f556a 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -426,7 +426,13 @@
> ##
> # @guest-fsfreeze-freeze:
> #
> -# Sync and freeze all freezable, local guest filesystems
> +# Sync and freeze all freezable, local guest filesystems. If this
> +# command succeeded, you may call @guest-fsfreeze-thaw later to
> +# unfreeze.
> +#
> +# Note: On Windows, the command is implemented with the help of a
> +# Volume Shadow-copy Service DLL helper. The frozen state is limited
> +# for up to 10 seconds by VSS.
> #
> # Returns: Number of file systems currently frozen. On error, all filesystems
> # will be thawed.
> @@ -439,10 +445,12 @@
> ##
> # @guest-fsfreeze-freeze-list:
> #
> -# Sync and freeze specified guest filesystems
> +# Sync and freeze specified guest filesystems.
> +# See also @guest-fsfreeze-freeze.
> #
> # @mountpoints: an array of mountpoints of filesystems to be frozen.
> # If omitted, every mounted filesystem is frozen.
> +# Invalid mount points are ignored.
> #
> # Returns: Number of file systems currently frozen. On error, all filesystems
> # will be thawed.
> --
> 2.12.0.191.gc5d8de91d
>
>
--
Vinzenz Feenstra
Senior Software Developer
Red Hat Czech
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qga: improve fsfreeze documentations
2017-04-03 9:54 [Qemu-devel] [PATCH] qga: improve fsfreeze documentations Marc-André Lureau
2017-04-03 11:09 ` Vinzenz Feenstra
2017-04-13 14:59 ` Vinzenz Feenstra
@ 2017-04-13 20:30 ` Michael Roth
2 siblings, 0 replies; 4+ messages in thread
From: Michael Roth @ 2017-04-13 20:30 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel
Quoting Marc-André Lureau (2017-04-03 04:54:38)
> Some users find the fsfreeze behaviour confusing. Add some notes about
> invalid mount points and Windows usage.
>
> Related to:
> https://bugzilla.redhat.com/show_bug.cgi?id=1436976
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Thanks, applied to qga tree:
https://github.com/mdroth/qemu/commits/qga
> ---
> qga/qapi-schema.json | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index a02dbf2d18..8d901f556a 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -426,7 +426,13 @@
> ##
> # @guest-fsfreeze-freeze:
> #
> -# Sync and freeze all freezable, local guest filesystems
> +# Sync and freeze all freezable, local guest filesystems. If this
> +# command succeeded, you may call @guest-fsfreeze-thaw later to
> +# unfreeze.
> +#
> +# Note: On Windows, the command is implemented with the help of a
> +# Volume Shadow-copy Service DLL helper. The frozen state is limited
> +# for up to 10 seconds by VSS.
> #
> # Returns: Number of file systems currently frozen. On error, all filesystems
> # will be thawed.
> @@ -439,10 +445,12 @@
> ##
> # @guest-fsfreeze-freeze-list:
> #
> -# Sync and freeze specified guest filesystems
> +# Sync and freeze specified guest filesystems.
> +# See also @guest-fsfreeze-freeze.
> #
> # @mountpoints: an array of mountpoints of filesystems to be frozen.
> # If omitted, every mounted filesystem is frozen.
> +# Invalid mount points are ignored.
> #
> # Returns: Number of file systems currently frozen. On error, all filesystems
> # will be thawed.
> --
> 2.12.0.191.gc5d8de91d
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-13 20:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-03 9:54 [Qemu-devel] [PATCH] qga: improve fsfreeze documentations Marc-André Lureau
2017-04-03 11:09 ` Vinzenz Feenstra
2017-04-13 14:59 ` Vinzenz Feenstra
2017-04-13 20:30 ` Michael Roth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.