[PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad Mixx 310

[PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad Mixx 310

[Hans de Goede]

Some production batches of the Lenovo Ideapad Mixx 310 laptop use
a portrait LCD panel, add a quirk for this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 902cc1a71e45..9274237b7f57 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -60,6 +60,12 @@ static const struct drm_dmi_panel_orientation_data itworks_tw891 = {
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };
 
+static const struct drm_dmi_panel_orientation_data lenovo_ideapad_miix_310 = {
+	.width = 800,
+	.height = 1280,
+	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
+
 static const struct drm_dmi_panel_orientation_data vios_lth17 = {
 	.width = 800,
 	.height = 1280,
@@ -102,6 +108,17 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
 		},
 		.driver_data = (void *)&itworks_tw891,
+	}, {	/*
+		 * Lenovo Ideapad Miix 310 laptop, only some production batches
+		 * have a portrait screen, the resolution checks makes the quirk
+		 * apply only to those batches.
+		 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
+		},
+		.driver_data = (void *)&lenovo_ideapad_miix_310,
 	}, {	/* VIOS LTH17 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
-- 
2.17.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/2] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad Mixx 320

[Hans de Goede]

The Lenovo Ideapad Mixx 320 laptop uses a portrait LCD panel, add a
quirk for this.

While at it instead of duplicating the same drm_dmi_panel_orientation_data
for 3 laptops add a generic lcd800x1280_rightside_up orientation_data and
use that for all 3 (including the new Mixx 320 entry).

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 .../gpu/drm/drm_panel_orientation_quirks.c    | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 9274237b7f57..caebddda8bce 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -60,13 +60,7 @@ static const struct drm_dmi_panel_orientation_data itworks_tw891 = {
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };
 
-static const struct drm_dmi_panel_orientation_data lenovo_ideapad_miix_310 = {
-	.width = 800,
-	.height = 1280,
-	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
-};
-
-static const struct drm_dmi_panel_orientation_data vios_lth17 = {
+static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = {
 	.width = 800,
 	.height = 1280,
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
@@ -118,13 +112,20 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
 		},
-		.driver_data = (void *)&lenovo_ideapad_miix_310,
+		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* Lenovo Ideapad Miix 320 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
+		},
+		.driver_data = (void *)&lcd800x1280_rightside_up,
 	}, {	/* VIOS LTH17 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
 		},
-		.driver_data = (void *)&vios_lth17,
+		.driver_data = (void *)&lcd800x1280_rightside_up,
 	},
 	{}
 };
-- 
2.17.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad Mixx 310

[Hans de Goede]

Hi,

On 18-04-18 14:36, Hans de Goede wrote:
> Some production batches of the Lenovo Ideapad Mixx 310 laptop use
> a portrait LCD panel, add a quirk for this.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Ping?

Can I please get an ack for these 2 trivial patches to that I can
push them to drm-misc-next ?

Thanks & Regards,

Hans




> --- >   drivers/gpu/drm/drm_panel_orientation_quirks.c | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 902cc1a71e45..9274237b7f57 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -60,6 +60,12 @@ static const struct drm_dmi_panel_orientation_data itworks_tw891 = {
>   	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
>   };
>   
> +static const struct drm_dmi_panel_orientation_data lenovo_ideapad_miix_310 = {
> +	.width = 800,
> +	.height = 1280,
> +	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> +};
> +
>   static const struct drm_dmi_panel_orientation_data vios_lth17 = {
>   	.width = 800,
>   	.height = 1280,
> @@ -102,6 +108,17 @@ static const struct dmi_system_id orientation_data[] = {
>   		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
>   		},
>   		.driver_data = (void *)&itworks_tw891,
> +	}, {	/*
> +		 * Lenovo Ideapad Miix 310 laptop, only some production batches
> +		 * have a portrait screen, the resolution checks makes the quirk
> +		 * apply only to those batches.
> +		 */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
> +		},
> +		.driver_data = (void *)&lenovo_ideapad_miix_310,
>   	}, {	/* VIOS LTH17 */
>   		.matches = {
>   		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad Mixx 310

[Maarten Lankhorst]

Op 24-04-18 om 12:09 schreef Hans de Goede:
> Hi,
>
> On 18-04-18 14:36, Hans de Goede wrote:
>> Some production batches of the Lenovo Ideapad Mixx 310 laptop use
>> a portrait LCD panel, add a quirk for this.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Ping?
>
> Can I please get an ack for these 2 trivial patches to that I can
> push them to drm-misc-next ?
>
> Thanks & Regards, 
I don't have the hw, but patches look sane..

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad Mixx 310

[Hans de Goede]

Hi,

On 24-04-18 12:26, Maarten Lankhorst wrote:
> Op 24-04-18 om 12:09 schreef Hans de Goede:
>> Hi,
>>
>> On 18-04-18 14:36, Hans de Goede wrote:
>>> Some production batches of the Lenovo Ideapad Mixx 310 laptop use
>>> a portrait LCD panel, add a quirk for this.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Ping?
>>
>> Can I please get an ack for these 2 trivial patches to that I can
>> push them to drm-misc-next ?
>>
>> Thanks & Regards,
> I don't have the hw, but patches look sane..
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Thank you, pushed.

Regards,

Hans
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad Mixx 310

[Daniel Vetter]

On Tue, Apr 24, 2018 at 12:26:04PM +0200, Maarten Lankhorst wrote:
> Op 24-04-18 om 12:09 schreef Hans de Goede:
> > Hi,
> >
> > On 18-04-18 14:36, Hans de Goede wrote:
> >> Some production batches of the Lenovo Ideapad Mixx 310 laptop use
> >> a portrait LCD panel, add a quirk for this.
> >>
> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Ping?
> >
> > Can I please get an ack for these 2 trivial patches to that I can
> > push them to drm-misc-next ?
> >
> > Thanks & Regards, 
> I don't have the hw, but patches look sane..
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

For quirks, bugzilla/reporter/any other evidence why we need it would be
really good. If you haven't pushed yet, pls add that.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad Mixx 310

[Hans de Goede]

Hi,

On 24-04-18 14:18, Daniel Vetter wrote:
> On Tue, Apr 24, 2018 at 12:26:04PM +0200, Maarten Lankhorst wrote:
>> Op 24-04-18 om 12:09 schreef Hans de Goede:
>>> Hi,
>>>
>>> On 18-04-18 14:36, Hans de Goede wrote:
>>>> Some production batches of the Lenovo Ideapad Mixx 310 laptop use
>>>> a portrait LCD panel, add a quirk for this.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>
>>> Ping?
>>>
>>> Can I please get an ack for these 2 trivial patches to that I can
>>> push them to drm-misc-next ?
>>>
>>> Thanks & Regards,
>> I don't have the hw, but patches look sane..
>>
>> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> 
> For quirks, bugzilla/reporter/any other evidence why we need it would be
> really good. If you haven't pushed yet, pls add that.

Sorry, too late.  I must admit I'm a bit of a hoarder when it
comes to BYT / CHT hardware (as I spend my spare time on trying
to make those work properly with Linux) and I own all devices
currently listed, except for the GPD Pocket which I borrowed
from a friend for a while to get it supported properly under
Linux.

But I'm currently emailing with someone who has a device with
a non-upright mounted LCD-panel which will need a quirk too,
which will be the first device I don't have access to myself.

I will add his email address as a comment to the entry when I
submit the patch for that.

Regards,

Hans
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad Mixx 310

[Daniel Vetter]

On Tue, Apr 24, 2018 at 02:24:59PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 24-04-18 14:18, Daniel Vetter wrote:
> > On Tue, Apr 24, 2018 at 12:26:04PM +0200, Maarten Lankhorst wrote:
> > > Op 24-04-18 om 12:09 schreef Hans de Goede:
> > > > Hi,
> > > > 
> > > > On 18-04-18 14:36, Hans de Goede wrote:
> > > > > Some production batches of the Lenovo Ideapad Mixx 310 laptop use
> > > > > a portrait LCD panel, add a quirk for this.
> > > > > 
> > > > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > > > 
> > > > Ping?
> > > > 
> > > > Can I please get an ack for these 2 trivial patches to that I can
> > > > push them to drm-misc-next ?
> > > > 
> > > > Thanks & Regards,
> > > I don't have the hw, but patches look sane..
> > > 
> > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > 
> > For quirks, bugzilla/reporter/any other evidence why we need it would be
> > really good. If you haven't pushed yet, pls add that.
> 
> Sorry, too late.  I must admit I'm a bit of a hoarder when it
> comes to BYT / CHT hardware (as I spend my spare time on trying
> to make those work properly with Linux) and I own all devices
> currently listed, except for the GPD Pocket which I borrowed
> from a friend for a while to get it supported properly under
> Linux.
> 
> But I'm currently emailing with someone who has a device with
> a non-upright mounted LCD-panel which will need a quirk too,
> which will be the first device I don't have access to myself.

Ah ok, as long as all we need to figure this out is nag you I think it's
ok. We've had plenty of cases in the past where it looked like quirk
entries just papered over a driver bug (which we discovered much later),
so it's good if there's some way to get hold of the original reporters
again. Even if chances are generally slim.

> I will add his email address as a comment to the entry when I
> submit the patch for that.

Commit message is prefectly fine.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel