From: Oleksandr <olekstysh@gmail.com>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
sstabellini@kernel.org
Subject: Re: [PATCH V4 5/5] xen/arm: Add early printk support for SCIFA compatible UARTs
Date: Tue, 30 Apr 2019 14:04:21 +0300 [thread overview]
Message-ID: <864da0bc-0c5d-9ef8-f0dc-02d89dd34cab@gmail.com> (raw)
In-Reply-To: <c7ac1368-a3cc-0eb2-76ca-195665db5fff@arm.com>
On 29.04.19 17:30, Julien Grall wrote:
> Hi Oleksandr,
Hi, Julien
>> @@ -22,10 +22,13 @@
>> #ifdef EARLY_PRINTK_VERSION_NONE
>> #define STATUS_REG SCIF_SCFSR
>> #define TX_FIFO_REG SCIF_SCFTDR
>> +#elif EARLY_PRINTK_VERSION_A
>> +#define STATUS_REG SCIFA_SCASSR
>> +#define TX_FIFO_REG SCIFA_SCAFTDR
>> #endif
>> /*
>> - * SCIF UART wait UART to be ready to transmit
>> + * Wait UART to be ready to transmit
>
> This change and ...
>
>> * rb: register which contains the UART base address
>> * rc: scratch register
>> */
>> @@ -37,7 +40,7 @@
>> .endm
>> /*
>> - * SCIF UART transmit character
>> + * UART transmit character
>
> ... this one look like more a change for the previous than this one.
agree, will move to previous patch.
--
Regards,
Oleksandr Tyshchenko
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Oleksandr <olekstysh@gmail.com>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
sstabellini@kernel.org
Subject: Re: [Xen-devel] [PATCH V4 5/5] xen/arm: Add early printk support for SCIFA compatible UARTs
Date: Tue, 30 Apr 2019 14:04:21 +0300 [thread overview]
Message-ID: <864da0bc-0c5d-9ef8-f0dc-02d89dd34cab@gmail.com> (raw)
Message-ID: <20190430110421.575NclF8BEBrkdXkFlhjv_mSD8PBZBeYQd-Pqqk6dtM@z> (raw)
In-Reply-To: <c7ac1368-a3cc-0eb2-76ca-195665db5fff@arm.com>
On 29.04.19 17:30, Julien Grall wrote:
> Hi Oleksandr,
Hi, Julien
>> @@ -22,10 +22,13 @@
>> #ifdef EARLY_PRINTK_VERSION_NONE
>> #define STATUS_REG SCIF_SCFSR
>> #define TX_FIFO_REG SCIF_SCFTDR
>> +#elif EARLY_PRINTK_VERSION_A
>> +#define STATUS_REG SCIFA_SCASSR
>> +#define TX_FIFO_REG SCIFA_SCAFTDR
>> #endif
>> /*
>> - * SCIF UART wait UART to be ready to transmit
>> + * Wait UART to be ready to transmit
>
> This change and ...
>
>> * rb: register which contains the UART base address
>> * rc: scratch register
>> */
>> @@ -37,7 +40,7 @@
>> .endm
>> /*
>> - * SCIF UART transmit character
>> + * UART transmit character
>
> ... this one look like more a change for the previous than this one.
agree, will move to previous patch.
--
Regards,
Oleksandr Tyshchenko
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-04-30 11:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 14:59 [PATCH V4 0/5] Renesas Stout board support (R-Car Gen2) Oleksandr Tyshchenko
2019-04-17 14:59 ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-17 14:59 ` [PATCH V4 1/5] xen/arm: Clarify usage of earlyprintk for Lager board Oleksandr Tyshchenko
2019-04-17 14:59 ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-17 16:26 ` Julien Grall
2019-04-17 16:26 ` [Xen-devel] " Julien Grall
2019-04-17 14:59 ` [PATCH V4 2/5] xen/arm: drivers: scif: Extend driver to handle other interfaces Oleksandr Tyshchenko
2019-04-17 14:59 ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-29 12:51 ` Julien Grall
2019-04-29 12:51 ` [Xen-devel] " Julien Grall
2019-04-17 14:59 ` [PATCH V4 3/5] xen/arm: drivers: scif: Add support for SCIFA compatible UARTs Oleksandr Tyshchenko
2019-04-17 14:59 ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-29 14:22 ` Julien Grall
2019-04-29 14:22 ` [Xen-devel] " Julien Grall
2019-04-17 14:59 ` [PATCH V4 4/5] xen/arm: Extend SCIF early prink code to handle other interfaces Oleksandr Tyshchenko
2019-04-17 14:59 ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-29 14:29 ` Julien Grall
2019-04-29 14:29 ` [Xen-devel] " Julien Grall
2019-04-30 11:00 ` Oleksandr
2019-04-30 11:00 ` [Xen-devel] " Oleksandr
2019-05-07 15:58 ` Julien Grall
2019-05-07 15:58 ` [Xen-devel] " Julien Grall
2019-04-17 14:59 ` [PATCH V4 5/5] xen/arm: Add early printk support for SCIFA compatible UARTs Oleksandr Tyshchenko
2019-04-17 14:59 ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-29 14:30 ` Julien Grall
2019-04-29 14:30 ` [Xen-devel] " Julien Grall
2019-04-30 11:04 ` Oleksandr [this message]
2019-04-30 11:04 ` Oleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864da0bc-0c5d-9ef8-f0dc-02d89dd34cab@gmail.com \
--to=olekstysh@gmail.com \
--cc=julien.grall@arm.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.