From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Phil Elwell <phil@raspberrypi.com>,
Rob Herring <robh+dt@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <treding@nvidia.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: gpio-ranges property is now required
Date: Tue, 14 Dec 2021 15:21:39 +0100 [thread overview]
Message-ID: <8671ebd8-a853-7394-9864-0457514337e2@samsung.com> (raw)
In-Reply-To: <20211206092237.4105895-3-phil@raspberrypi.com>
Hi Phil,
On 06.12.2021 10:22, Phil Elwell wrote:
> Since [1], added in 5.7, the absence of a gpio-ranges property has
> prevented GPIOs from being restored to inputs when released.
> Add those properties for BCM283x and BCM2711 devices.
>
> [1] commit 2ab73c6d8323 ("gpio: Support GPIO controllers without
> pin-ranges")
>
> Fixes: 2ab73c6d8323 ("gpio: Support GPIO controllers without pin-ranges")
> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
This patch breaks today's linux-next (next-20211214) on RPi3 and RPi4.
Either there is something missing or wrong here. Booting stops after
following messages (on RPi4):
[ 3.186786] pinctrl-bcm2835 fe200000.gpio: could not add GPIO chip
[ 3.234513] pinctrl-bcm2835 fe200000.gpio: could not add GPIO chip
[ 3.276703] mmc0: SDHCI controller on fe340000.mmc [fe340000.mmc]
using ADMA
[ 3.287191] pinctrl-bcm2835 fe200000.gpio
> ---
> arch/arm/boot/dts/bcm2711.dtsi | 2 ++
> arch/arm/boot/dts/bcm283x.dtsi | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> index 9e01dbca4a011..dff18fc9a9065 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -582,6 +582,8 @@ &gpio {
> <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
>
> + gpio-ranges = <&gpio 0 0 58>;
> +
> gpclk0_gpio49: gpclk0_gpio49 {
> pin-gpclk {
> pins = "gpio49";
> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
> index a3e06b6809476..c113661a6668f 100644
> --- a/arch/arm/boot/dts/bcm283x.dtsi
> +++ b/arch/arm/boot/dts/bcm283x.dtsi
> @@ -126,6 +126,8 @@ gpio: gpio@7e200000 {
> interrupt-controller;
> #interrupt-cells = <2>;
>
> + gpio-ranges = <&gpio 0 0 54>;
> +
> /* Defines common pin muxing groups
> *
> * While each pin can have its mux selected
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2021-12-14 14:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 9:22 [PATCH v2 0/2] pinctrl: bcm2835: Fix gpio hogs and pin reinitialisation Phil Elwell
2021-12-06 9:22 ` [PATCH v2 1/2] pinctrl: bcm2835: Change init order for gpio hogs Phil Elwell
2021-12-07 18:32 ` Florian Fainelli
2021-12-09 23:24 ` Linus Walleij
2021-12-29 19:07 ` Stefan Wahren
2021-12-29 21:11 ` Florian Fainelli
2022-01-02 6:54 ` Linus Walleij
2022-01-02 11:02 ` Jan Kiszka
2022-01-02 12:33 ` Stefan Wahren
2022-01-02 15:12 ` Jan Kiszka
2022-01-02 15:16 ` Jan Kiszka
2022-01-04 17:04 ` Linus Walleij
2021-12-06 9:22 ` [PATCH v2 2/2] ARM: dts: gpio-ranges property is now required Phil Elwell
2021-12-06 10:33 ` Linus Walleij
2021-12-06 17:24 ` Florian Fainelli
2021-12-07 15:29 ` Linus Walleij
2021-12-10 11:12 ` nicolas saenz julienne
[not found] ` <CGME20211214142139eucas1p1c100b7fd4b8c8ce85bc03e1ce6b783db@eucas1p1.samsung.com>
2021-12-14 14:21 ` Marek Szyprowski [this message]
2021-12-14 14:32 ` Phil Elwell
2021-12-14 17:12 ` Florian Fainelli
2021-12-15 9:02 ` nicolas saenz julienne
2021-12-15 17:14 ` Florian Fainelli
2021-12-16 3:27 ` Linus Walleij
2021-12-16 3:28 ` Florian Fainelli
2021-12-16 3:31 ` Linus Walleij
2021-12-16 8:28 ` nicolas saenz julienne
2021-12-15 17:15 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8671ebd8-a853-7394-9864-0457514337e2@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.