All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Phil Elwell <phil@raspberrypi.com>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-gpio@vger.kernel.org,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH v2 1/2] pinctrl: bcm2835: Change init order for gpio hogs
Date: Wed, 29 Dec 2021 20:07:13 +0100	[thread overview]
Message-ID: <95851343-2887-1e04-9598-e8c8ae74a99a@i2se.com> (raw)
In-Reply-To: <CACRpkdZ95bCJVDo4tCXsMnsXax4+ZydoLS7AsM-yzMjXbONk=w@mail.gmail.com>

Am 10.12.21 um 00:24 schrieb Linus Walleij:
> On Mon, Dec 6, 2021 at 10:22 AM Phil Elwell <phil@raspberrypi.com> wrote:
>
>> ...and gpio-ranges
>>
>> pinctrl-bcm2835 is a combined pinctrl/gpio driver. Currently the gpio
>> side is registered first, but this breaks gpio hogs (which are
>> configured during gpiochip_add_data). Part of the hog initialisation
>> is a call to pinctrl_gpio_request, and since the pinctrl driver hasn't
>> yet been registered this results in an -EPROBE_DEFER from which it can
>> never recover.
>>
>> Change the initialisation sequence to register the pinctrl driver
>> first.
>>
>> This also solves a similar problem with the gpio-ranges property, which
>> is required in order for released pins to be returned to inputs.
>>
>> Fixes: 73345a18d464b ("pinctrl: bcm2835: Pass irqchip when adding gpiochip")
>> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
> This patch (1/2) applied for fixes.

Unfortunately this change breaks all GPIO LEDs at least on the Raspberry
Pi 3 Plus (Linux 5.16-rc7, multi_v7_defconfig). The ACT LED for instance
stays in the last state instead of the configured heartbeat behavior.
Also there are no GPIO LEDs in /sys/class/leds/ directory.

After reverting this change everything is back to normal.

Best regards

>
> Yours,
> Linus Walleij
>
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel


  reply	other threads:[~2021-12-29 19:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06  9:22 [PATCH v2 0/2] pinctrl: bcm2835: Fix gpio hogs and pin reinitialisation Phil Elwell
2021-12-06  9:22 ` [PATCH v2 1/2] pinctrl: bcm2835: Change init order for gpio hogs Phil Elwell
2021-12-07 18:32   ` Florian Fainelli
2021-12-09 23:24   ` Linus Walleij
2021-12-29 19:07     ` Stefan Wahren [this message]
2021-12-29 21:11       ` Florian Fainelli
2022-01-02  6:54       ` Linus Walleij
2022-01-02 11:02         ` Jan Kiszka
2022-01-02 12:33           ` Stefan Wahren
2022-01-02 15:12             ` Jan Kiszka
2022-01-02 15:16               ` Jan Kiszka
2022-01-04 17:04                 ` Linus Walleij
2021-12-06  9:22 ` [PATCH v2 2/2] ARM: dts: gpio-ranges property is now required Phil Elwell
2021-12-06 10:33   ` Linus Walleij
2021-12-06 17:24     ` Florian Fainelli
2021-12-07 15:29       ` Linus Walleij
2021-12-10 11:12     ` nicolas saenz julienne
     [not found]   ` <CGME20211214142139eucas1p1c100b7fd4b8c8ce85bc03e1ce6b783db@eucas1p1.samsung.com>
2021-12-14 14:21     ` Marek Szyprowski
2021-12-14 14:32       ` Phil Elwell
2021-12-14 17:12         ` Florian Fainelli
2021-12-15  9:02           ` nicolas saenz julienne
2021-12-15 17:14             ` Florian Fainelli
2021-12-16  3:27               ` Linus Walleij
2021-12-16  3:28                 ` Florian Fainelli
2021-12-16  3:31                   ` Linus Walleij
2021-12-16  8:28                     ` nicolas saenz julienne
2021-12-15 17:15   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95851343-2887-1e04-9598-e8c8ae74a99a@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nsaenz@kernel.org \
    --cc=phil@raspberrypi.com \
    --cc=robh+dt@kernel.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.