All of lore.kernel.org
 help / color / mirror / Atom feed
* e2p_blocks_count () vs. ext2fs_blocks_count ()
@ 2011-08-22  3:25 Ivan Shmakov
  2011-08-22 16:33 ` Ted Ts'o
  0 siblings, 1 reply; 3+ messages in thread
From: Ivan Shmakov @ 2011-08-22  3:25 UTC (permalink / raw)
  To: linux-ext4

	Apparently, e2p_blocks_count (), a ‘static’ function in
	lib/e2p/ls.c, duplicates the public ext2fs_blocks_count () one
	(lib/ext2fs/blknum.c) as of d4c0d8e5.  The same holds for
	e2p_r_blocks_count () and e2p_free_blocks_count ().

	The code is, as it seems, exactly the same.

	I wonder, isn't there a problem?

	TIA.

-- 
FSF associate member #7257	Coming soon: Software Freedom Day
http://mail.sf-day.org/lists/listinfo/ planning-ru (ru), sfd-discuss (en)

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: e2p_blocks_count () vs. ext2fs_blocks_count ()
  2011-08-22  3:25 e2p_blocks_count () vs. ext2fs_blocks_count () Ivan Shmakov
@ 2011-08-22 16:33 ` Ted Ts'o
  2011-08-22 16:48   ` Ivan Shmakov
  0 siblings, 1 reply; 3+ messages in thread
From: Ted Ts'o @ 2011-08-22 16:33 UTC (permalink / raw)
  To: Ivan Shmakov; +Cc: linux-ext4

On Mon, Aug 22, 2011 at 10:25:19AM +0700, Ivan Shmakov wrote:
> 	Apparently, e2p_blocks_count (), a ‘static’ function in
> 	lib/e2p/ls.c, duplicates the public ext2fs_blocks_count () one
> 	(lib/ext2fs/blknum.c) as of d4c0d8e5.  The same holds for
> 	e2p_r_blocks_count () and e2p_free_blocks_count ().
> 
> 	The code is, as it seems, exactly the same.
> 
> 	I wonder, isn't there a problem?

That's deliberate; the goal was to make libe2p not dependent on
libext2fs, so that programs such as lsattr don't need to pull in
libext2fs.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: e2p_blocks_count () vs. ext2fs_blocks_count ()
  2011-08-22 16:33 ` Ted Ts'o
@ 2011-08-22 16:48   ` Ivan Shmakov
  0 siblings, 0 replies; 3+ messages in thread
From: Ivan Shmakov @ 2011-08-22 16:48 UTC (permalink / raw)
  To: linux-ext4

>>>>> Ted Ts'o <tytso@mit.edu> writes:
>>>>> On Mon, Aug 22, 2011 at 10:25:19AM +0700, Ivan Shmakov wrote:

 >> Apparently, e2p_blocks_count (), a ‘static’ function in
 >> lib/e2p/ls.c, duplicates the public ext2fs_blocks_count () one
 >> (lib/ext2fs/blknum.c) as of d4c0d8e5.  The same holds for
 >> e2p_r_blocks_count () and e2p_free_blocks_count ().

 >> The code is, as it seems, exactly the same.

 >> I wonder, isn't there a problem?

 > That's deliberate; the goal was to make libe2p not dependent on
 > libext2fs, so that programs such as lsattr don't need to pull in
 > libext2fs.

	ACK.  Thanks.

-- 
FSF associate member #7257	Coming soon: Software Freedom Day
http://mail.sf-day.org/lists/listinfo/ planning-ru (ru), sfd-discuss (en)

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-22 16:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-22  3:25 e2p_blocks_count () vs. ext2fs_blocks_count () Ivan Shmakov
2011-08-22 16:33 ` Ted Ts'o
2011-08-22 16:48   ` Ivan Shmakov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.