From: Abhinav Kumar <quic_abhinavk@quicinc.com> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run> Cc: kernel test robot <lkp@intel.com>, David Airlie <airlied@linux.ie>, <linux-arm-msm@vger.kernel.org>, <dri-devel@lists.freedesktop.org>, "Bjorn Andersson" <bjorn.andersson@linaro.org>, Daniel Vetter <daniel@ffwll.ch>, Stephen Boyd <swboyd@chromium.org>, <freedreno@lists.freedesktop.org> Subject: Re: [Freedreno] [PATCH] drm/msm/dpu: remove NULL-ness check in dpu_hw_intr_destroy Date: Sat, 7 May 2022 11:04:28 -0700 [thread overview] Message-ID: <86b5d7a2-ec98-f359-6054-6abb5323b256@quicinc.com> (raw) In-Reply-To: <20220507114009.1696278-1-dmitry.baryshkov@linaro.org> On 5/7/2022 4:40 AM, Dmitry Baryshkov wrote: > There is no need to check that kfree() argument is not NULL. Remove > extra check and call kfree() unconditionally. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > index fa4f99034a08..915250b7f122 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > @@ -433,8 +433,7 @@ struct dpu_hw_intr *dpu_hw_intr_init(void __iomem *addr, > > void dpu_hw_intr_destroy(struct dpu_hw_intr *intr) > { > - if (intr) > - kfree(intr); > + kfree(intr); > } > > int dpu_core_irq_register_callback(struct dpu_kms *dpu_kms, int irq_idx,
WARNING: multiple messages have this Message-ID (diff)
From: Abhinav Kumar <quic_abhinavk@quicinc.com> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run> Cc: kernel test robot <lkp@intel.com>, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Andersson <bjorn.andersson@linaro.org>, Stephen Boyd <swboyd@chromium.org>, freedreno@lists.freedesktop.org Subject: Re: [Freedreno] [PATCH] drm/msm/dpu: remove NULL-ness check in dpu_hw_intr_destroy Date: Sat, 7 May 2022 11:04:28 -0700 [thread overview] Message-ID: <86b5d7a2-ec98-f359-6054-6abb5323b256@quicinc.com> (raw) In-Reply-To: <20220507114009.1696278-1-dmitry.baryshkov@linaro.org> On 5/7/2022 4:40 AM, Dmitry Baryshkov wrote: > There is no need to check that kfree() argument is not NULL. Remove > extra check and call kfree() unconditionally. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > index fa4f99034a08..915250b7f122 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > @@ -433,8 +433,7 @@ struct dpu_hw_intr *dpu_hw_intr_init(void __iomem *addr, > > void dpu_hw_intr_destroy(struct dpu_hw_intr *intr) > { > - if (intr) > - kfree(intr); > + kfree(intr); > } > > int dpu_core_irq_register_callback(struct dpu_kms *dpu_kms, int irq_idx,
next prev parent reply other threads:[~2022-05-07 18:04 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-07 11:40 [PATCH] drm/msm/dpu: remove NULL-ness check in dpu_hw_intr_destroy Dmitry Baryshkov 2022-05-07 11:40 ` Dmitry Baryshkov 2022-05-07 18:04 ` Abhinav Kumar [this message] 2022-05-07 18:04 ` [Freedreno] " Abhinav Kumar 2022-05-12 0:52 ` Stephen Boyd 2022-05-12 0:52 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=86b5d7a2-ec98-f359-6054-6abb5323b256@quicinc.com \ --to=quic_abhinavk@quicinc.com \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=lkp@intel.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.