From: Maximilian Luz <luzmaximilian@gmail.com>
To: jaschultzms@gmail.com
Cc: benjamin.tissoires@redhat.com, biju.das.jz@bp.renesas.com,
bjorn.andersson@linaro.org, catalin.marinas@arm.com,
corbet@lwn.net, devicetree@vger.kernel.org, dmanti@microsoft.com,
dmitry.baryshkov@linaro.org, dmitry.torokhov@gmail.com,
geert+renesas@glider.be, jaschultz@microsoft.com,
jikos@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
marcel.ziswiler@toradex.com, robh+dt@kernel.org,
shawnguo@kernel.org, vkoul@kernel.org, will@kernel.org
Subject: Re: [PATCH v5 0/6] Add spi-hid, transport for HID over SPI bus
Date: Tue, 9 Aug 2022 02:53:26 +0200 [thread overview]
Message-ID: <86b63b7b-afda-d7f4-7bfa-175085d5a8ef@gmail.com> (raw)
In-Reply-To: <20220707165902.3184-1-jaschultzMS@gmail.com>
On 8/7/22 09:58, Jarrett Schultz <jaschultzms@gmail.com> wrote:
> Surface Duo devices use a touch digitizer that communicates to the main
> SoC via SPI and presents itself as a HID device. This patch's goal is to
> add the spi-hid transport driver to drivers/hid. The driver follows the
> publically available HID Over SPI Protocol Specification version 1.0.
As far as I can tell based on the downstream code you provide in [1],
your proposed driver (and v1.0 spec) is incompatible with the version
used on current Surface devices (Surface Duo 1 and 2, Surface Pro X, and
I assume some AMD/x86 based devices on which you also use spi-hid for the
digitizer). On those, SPI_HID_SUPPORTED_VERSION is 0x0100 whereas it is
0x0300 for the driver proposed here, along with at least some protocol
struct changes.
Do you have any plans on supporting those devices (i.e. protocol version
0x0100) at some point?
Regards,
Max
[1]: https://github.com/microsoft/surface-duo-oss-kernel.msm-5..4/tree/surfaceduo2/11/2022.108.8/drivers/hid/spi-hid
WARNING: multiple messages have this Message-ID (diff)
From: Maximilian Luz <luzmaximilian@gmail.com>
To: jaschultzms@gmail.com
Cc: benjamin.tissoires@redhat.com, biju.das.jz@bp.renesas.com,
bjorn.andersson@linaro.org, catalin.marinas@arm.com,
corbet@lwn.net, devicetree@vger.kernel.org, dmanti@microsoft.com,
dmitry.baryshkov@linaro.org, dmitry.torokhov@gmail.com,
geert+renesas@glider.be, jaschultz@microsoft.com,
jikos@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
marcel.ziswiler@toradex.com, robh+dt@kernel.org,
shawnguo@kernel.org, vkoul@kernel.org, will@kernel.org
Subject: Re: [PATCH v5 0/6] Add spi-hid, transport for HID over SPI bus
Date: Tue, 9 Aug 2022 02:53:26 +0200 [thread overview]
Message-ID: <86b63b7b-afda-d7f4-7bfa-175085d5a8ef@gmail.com> (raw)
In-Reply-To: <20220707165902.3184-1-jaschultzMS@gmail.com>
On 8/7/22 09:58, Jarrett Schultz <jaschultzms@gmail.com> wrote:
> Surface Duo devices use a touch digitizer that communicates to the main
> SoC via SPI and presents itself as a HID device. This patch's goal is to
> add the spi-hid transport driver to drivers/hid. The driver follows the
> publically available HID Over SPI Protocol Specification version 1.0.
As far as I can tell based on the downstream code you provide in [1],
your proposed driver (and v1.0 spec) is incompatible with the version
used on current Surface devices (Surface Duo 1 and 2, Surface Pro X, and
I assume some AMD/x86 based devices on which you also use spi-hid for the
digitizer). On those, SPI_HID_SUPPORTED_VERSION is 0x0100 whereas it is
0x0300 for the driver proposed here, along with at least some protocol
struct changes.
Do you have any plans on supporting those devices (i.e. protocol version
0x0100) at some point?
Regards,
Max
[1]: https://github.com/microsoft/surface-duo-oss-kernel.msm-5..4/tree/surfaceduo2/11/2022.108.8/drivers/hid/spi-hid
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-09 0:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 16:58 [PATCH v5 0/6] Add spi-hid, transport for HID over SPI bus Jarrett Schultz
2022-07-07 16:58 ` Jarrett Schultz
2022-07-07 16:58 ` [PATCH v5 1/6] HID: Add BUS_SPI support when printing out device info in hid_connect() Jarrett Schultz
2022-07-07 16:58 ` Jarrett Schultz
2022-07-07 16:58 ` [PATCH v5 2/6] HID: define HID_SPI_DEVICE macro in hid.h Jarrett Schultz
2022-07-07 16:58 ` Jarrett Schultz
2022-07-07 16:58 ` [PATCH v5 3/6] dt-bindings: input: Document Microsoft G6 Touch Digitizer Jarrett Schultz
2022-07-07 16:58 ` Jarrett Schultz
2022-07-11 22:43 ` Rob Herring
2022-07-11 22:43 ` Rob Herring
2022-07-07 16:59 ` [PATCH v5 4/6] Documentation: Correction in HID output_report callback description Jarrett Schultz
2022-07-07 16:59 ` Jarrett Schultz
2022-07-07 16:59 ` [PATCH v5 5/6] HID: add spi-hid, transport driver for HID over SPI bus Jarrett Schultz
2022-07-07 16:59 ` Jarrett Schultz
2022-07-07 20:51 ` Randy Dunlap
2022-07-07 20:51 ` Randy Dunlap
2022-07-12 0:54 ` kernel test robot
2022-07-12 0:54 ` kernel test robot
2022-07-07 16:59 ` [PATCH v5 6/6] Enable building drivers/hid/spi-hid as a module Jarrett Schultz
2022-07-07 16:59 ` Jarrett Schultz
2022-08-09 0:53 ` Maximilian Luz [this message]
2022-08-09 0:53 ` [PATCH v5 0/6] Add spi-hid, transport for HID over SPI bus Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86b63b7b-afda-d7f4-7bfa-175085d5a8ef@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dmanti@microsoft.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jaschultz@microsoft.com \
--cc=jaschultzms@gmail.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.