All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Yi Zhang <yi.zhang@redhat.com>, osandov@osandov.com
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	sagi@grimberg.me
Subject: Re: [PATCH V3 blktests 5/5] common/multipath-over-rdma: allow to set use_siw
Date: Thu, 26 Nov 2020 08:31:27 -0800	[thread overview]
Message-ID: <86b955bf-6714-0739-3601-d290db8cf04e@acm.org> (raw)
In-Reply-To: <20201126083532.27509-6-yi.zhang@redhat.com>

On 11/26/20 12:35 AM, Yi Zhang wrote:
> With this change, we can change to use siw for nvme-rdma/nvmeof-mp/srp
> testing from cmdline:
> 
> $ use_siw=1 nvme-trtype=rdma ./check nvme/
> $ use_siw=1 ./check nvmeof-mp/
> $ use_siw=1 ./check srp/
> 
> Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
> ---
>  common/multipath-over-rdma | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/multipath-over-rdma b/common/multipath-over-rdma
> index ba6fa0d..b12dec3 100644
> --- a/common/multipath-over-rdma
> +++ b/common/multipath-over-rdma
> @@ -12,7 +12,7 @@ filesystem_type=ext4
>  fio_aux_path=/tmp/fio-state-files
>  memtotal=$(sed -n 's/^MemTotal:[[:blank:]]*\([0-9]*\)[[:blank:]]*kB$/\1/p' /proc/meminfo)
>  max_ramdisk_size=$((1<<25))
> -use_siw=
> +use_siw=${use_siw:-""}
>  ramdisk_size=$((memtotal*(1024/16)))  # in bytes
>  if [ $ramdisk_size -gt $max_ramdisk_size ]; then
>  	ramdisk_size=$max_ramdisk_size

Reviewed-by: Bart Van Assche <bvanassche@acm.org>




WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Yi Zhang <yi.zhang@redhat.com>, osandov@osandov.com
Cc: linux-block@vger.kernel.org, sagi@grimberg.me,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH V3 blktests 5/5] common/multipath-over-rdma: allow to set use_siw
Date: Thu, 26 Nov 2020 08:31:27 -0800	[thread overview]
Message-ID: <86b955bf-6714-0739-3601-d290db8cf04e@acm.org> (raw)
In-Reply-To: <20201126083532.27509-6-yi.zhang@redhat.com>

On 11/26/20 12:35 AM, Yi Zhang wrote:
> With this change, we can change to use siw for nvme-rdma/nvmeof-mp/srp
> testing from cmdline:
> 
> $ use_siw=1 nvme-trtype=rdma ./check nvme/
> $ use_siw=1 ./check nvmeof-mp/
> $ use_siw=1 ./check srp/
> 
> Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
> ---
>  common/multipath-over-rdma | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/multipath-over-rdma b/common/multipath-over-rdma
> index ba6fa0d..b12dec3 100644
> --- a/common/multipath-over-rdma
> +++ b/common/multipath-over-rdma
> @@ -12,7 +12,7 @@ filesystem_type=ext4
>  fio_aux_path=/tmp/fio-state-files
>  memtotal=$(sed -n 's/^MemTotal:[[:blank:]]*\([0-9]*\)[[:blank:]]*kB$/\1/p' /proc/meminfo)
>  max_ramdisk_size=$((1<<25))
> -use_siw=
> +use_siw=${use_siw:-""}
>  ramdisk_size=$((memtotal*(1024/16)))  # in bytes
>  if [ $ramdisk_size -gt $max_ramdisk_size ]; then
>  	ramdisk_size=$max_ramdisk_size

Reviewed-by: Bart Van Assche <bvanassche@acm.org>




_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-11-26 16:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26  8:35 [PATCH V3 blktests 0/5] nvmeof-mp/srp/nvme-rdma misc fix and enhancement Yi Zhang
2020-11-26  8:35 ` Yi Zhang
2020-11-26  8:35 ` [PATCH V3 blktests 1/5] tests/srp/rc: update the ib_srpt module name Yi Zhang
2020-11-26  8:35   ` Yi Zhang
2020-11-26  8:35 ` [PATCH V3 blktests 2/5] tests/nvmeof-mp/rc: run nvmeof-mp tests if we set multipath=N Yi Zhang
2020-11-26  8:35   ` Yi Zhang
2020-11-26  8:35 ` [PATCH V3 blktests 3/5] nvmeof-mp/012, srp/012: fix the scheduler list Yi Zhang
2020-11-26  8:35   ` Yi Zhang
2020-11-26 16:29   ` Bart Van Assche
2020-11-26 16:29     ` Bart Van Assche
2020-11-26  8:35 ` [PATCH V3 blktests 4/5] common/rc: _have_iproute2 fix for "ip -V" change Yi Zhang
2020-11-26  8:35   ` Yi Zhang
2020-11-26 16:30   ` Bart Van Assche
2020-11-26 16:30     ` Bart Van Assche
2020-11-26  8:35 ` [PATCH V3 blktests 5/5] common/multipath-over-rdma: allow to set use_siw Yi Zhang
2020-11-26  8:35   ` Yi Zhang
2020-11-26 16:31   ` Bart Van Assche [this message]
2020-11-26 16:31     ` Bart Van Assche
2021-01-04 22:48 ` [PATCH V3 blktests 0/5] nvmeof-mp/srp/nvme-rdma misc fix and enhancement Omar Sandoval
2021-01-04 22:48   ` Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86b955bf-6714-0739-3601-d290db8cf04e@acm.org \
    --to=bvanassche@acm.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=osandov@osandov.com \
    --cc=sagi@grimberg.me \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.