* [PATCH v2] platform/x86: thinkpad_acpi: Fix inconsistent indenting
@ 2021-05-24 6:23 Jiapeng Chong
2021-05-25 12:46 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-05-24 6:23 UTC (permalink / raw)
To: hmh
Cc: hdegoede, mgross, jdelvare, linux, ibm-acpi-devel,
platform-driver-x86, linux-kernel, linux-hwmon, Jiapeng Chong
Eliminate the follow smatch warning:
drivers/platform/x86/thinkpad_acpi.c:7942 volume_write() warn:
inconsistent indenting.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
Changes in v2:
-For the follow advice: https://lore.kernel.org/patchwork/patch/1434215/
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index dd60c93..b7fec1b 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -7938,7 +7938,7 @@ static int volume_write(char *buf)
continue;
} else if (sscanf(cmd, "level %u", &l) == 1 &&
l >= 0 && l <= TP_EC_VOLUME_MAX) {
- new_level = l;
+ new_level = l;
continue;
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] platform/x86: thinkpad_acpi: Fix inconsistent indenting
2021-05-24 6:23 [PATCH v2] platform/x86: thinkpad_acpi: Fix inconsistent indenting Jiapeng Chong
@ 2021-05-25 12:46 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-05-25 12:46 UTC (permalink / raw)
To: Jiapeng Chong, hmh
Cc: mgross, jdelvare, linux, ibm-acpi-devel, platform-driver-x86,
linux-kernel, linux-hwmon
Hi,
On 5/24/21 8:23 AM, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> drivers/platform/x86/thinkpad_acpi.c:7942 volume_write() warn:
> inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> Changes in v2:
> -For the follow advice: https://lore.kernel.org/patchwork/patch/1434215/
>
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index dd60c93..b7fec1b 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -7938,7 +7938,7 @@ static int volume_write(char *buf)
> continue;
> } else if (sscanf(cmd, "level %u", &l) == 1 &&
> l >= 0 && l <= TP_EC_VOLUME_MAX) {
> - new_level = l;
> + new_level = l;
> continue;
> }
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-25 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 6:23 [PATCH v2] platform/x86: thinkpad_acpi: Fix inconsistent indenting Jiapeng Chong
2021-05-25 12:46 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.