* [PATCH] ath11k: removing the ath11k debugfs dir properly
@ 2020-09-23 18:25 ` Karthikeyan Kathirvel
0 siblings, 0 replies; 6+ messages in thread
From: Karthikeyan Kathirvel @ 2020-09-23 18:25 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless, Karthikeyan Kathirvel
ath11k_debug_pdev_destroy was not called for proper cleaning of debug
files when destroying the pdev, this results in not removing the ath11k
directory in debugfs folder even after rmmod of ath11k. So when next
time doing insmod of ath11k prevents creating another ath11k directory,
hence causing ipq8074_2 to get created in parent dir of debugfs.
Signed-off-by: Karthikeyan Kathirvel <kathirve@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/debug.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath11k/debug.c b/drivers/net/wireless/ath/ath11k/debug.c
index 0ba234a..c4759bb 100644
--- a/drivers/net/wireless/ath/ath11k/debug.c
+++ b/drivers/net/wireless/ath/ath11k/debug.c
@@ -973,6 +973,7 @@ void ath11k_debug_soc_destroy(struct ath11k_base *ab)
{
debugfs_remove_recursive(ab->debugfs_soc);
ab->debugfs_soc = NULL;
+ ath11k_debug_pdev_destroy(ab);
}
void ath11k_debug_fw_stats_init(struct ath11k *ar)
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ath11k: removing the ath11k debugfs dir properly
@ 2020-09-23 18:25 ` Karthikeyan Kathirvel
0 siblings, 0 replies; 6+ messages in thread
From: Karthikeyan Kathirvel @ 2020-09-23 18:25 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless, Karthikeyan Kathirvel
ath11k_debug_pdev_destroy was not called for proper cleaning of debug
files when destroying the pdev, this results in not removing the ath11k
directory in debugfs folder even after rmmod of ath11k. So when next
time doing insmod of ath11k prevents creating another ath11k directory,
hence causing ipq8074_2 to get created in parent dir of debugfs.
Signed-off-by: Karthikeyan Kathirvel <kathirve@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/debug.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath11k/debug.c b/drivers/net/wireless/ath/ath11k/debug.c
index 0ba234a..c4759bb 100644
--- a/drivers/net/wireless/ath/ath11k/debug.c
+++ b/drivers/net/wireless/ath/ath11k/debug.c
@@ -973,6 +973,7 @@ void ath11k_debug_soc_destroy(struct ath11k_base *ab)
{
debugfs_remove_recursive(ab->debugfs_soc);
ab->debugfs_soc = NULL;
+ ath11k_debug_pdev_destroy(ab);
}
void ath11k_debug_fw_stats_init(struct ath11k *ar)
--
2.7.4
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: removing the ath11k debugfs dir properly
2020-09-23 18:25 ` Karthikeyan Kathirvel
(?)
@ 2020-09-24 16:16 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-09-24 16:16 UTC (permalink / raw)
To: Karthikeyan Kathirvel; +Cc: ath11k, linux-wireless, Karthikeyan Kathirvel
Karthikeyan Kathirvel <kathirve@codeaurora.org> wrote:
> ath11k_debug_pdev_destroy was not called for proper cleaning of debug
> files when destroying the pdev, this results in not removing the ath11k
> directory in debugfs folder even after rmmod of ath11k. So when next
> time doing insmod of ath11k prevents creating another ath11k directory,
> hence causing ipq8074_2 to get created in parent dir of debugfs.
>
> Signed-off-by: Karthikeyan Kathirvel <kathirve@codeaurora.org>
Fails to apply, please rebase. Also Tested-on missing.
error: patch failed: drivers/net/wireless/ath/ath11k/debug.c:973
error: drivers/net/wireless/ath/ath11k/debug.c: patch does not apply
stg import: Diff does not apply cleanly
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/11795461/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: removing the ath11k debugfs dir properly
2020-09-23 18:25 ` Karthikeyan Kathirvel
(?)
(?)
@ 2020-09-24 16:16 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-09-24 16:16 UTC (permalink / raw)
To: Karthikeyan Kathirvel; +Cc: linux-wireless, ath11k
Karthikeyan Kathirvel <kathirve@codeaurora.org> wrote:
> ath11k_debug_pdev_destroy was not called for proper cleaning of debug
> files when destroying the pdev, this results in not removing the ath11k
> directory in debugfs folder even after rmmod of ath11k. So when next
> time doing insmod of ath11k prevents creating another ath11k directory,
> hence causing ipq8074_2 to get created in parent dir of debugfs.
>
> Signed-off-by: Karthikeyan Kathirvel <kathirve@codeaurora.org>
Fails to apply, please rebase. Also Tested-on missing.
error: patch failed: drivers/net/wireless/ath/ath11k/debug.c:973
error: drivers/net/wireless/ath/ath11k/debug.c: patch does not apply
stg import: Diff does not apply cleanly
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/11795461/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: removing the ath11k debugfs dir properly
[not found] ` <20200924161623.ED696C433F1@smtp.codeaurora.org>
@ 2020-09-29 19:21 ` kathirve
0 siblings, 0 replies; 6+ messages in thread
From: kathirve @ 2020-09-29 19:21 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath11k, linux-wireless
Please ignore this patch
Thanks
Karthikeyan
On 2020-09-24 21:46, Kalle Valo wrote:
> Karthikeyan Kathirvel <kathirve@codeaurora.org> wrote:
>
>> ath11k_debug_pdev_destroy was not called for proper cleaning of debug
>> files when destroying the pdev, this results in not removing the
>> ath11k
>> directory in debugfs folder even after rmmod of ath11k. So when next
>> time doing insmod of ath11k prevents creating another ath11k
>> directory,
>> hence causing ipq8074_2 to get created in parent dir of debugfs.
>>
>> Signed-off-by: Karthikeyan Kathirvel <kathirve@codeaurora.org>
>
> Fails to apply, please rebase. Also Tested-on missing.
>
> error: patch failed: drivers/net/wireless/ath/ath11k/debug.c:973
> error: drivers/net/wireless/ath/ath11k/debug.c: patch does not apply
> stg import: Diff does not apply cleanly
>
> Patch set to Changes Requested.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: removing the ath11k debugfs dir properly
@ 2020-09-29 19:21 ` kathirve
0 siblings, 0 replies; 6+ messages in thread
From: kathirve @ 2020-09-29 19:21 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, ath11k
Please ignore this patch
Thanks
Karthikeyan
On 2020-09-24 21:46, Kalle Valo wrote:
> Karthikeyan Kathirvel <kathirve@codeaurora.org> wrote:
>
>> ath11k_debug_pdev_destroy was not called for proper cleaning of debug
>> files when destroying the pdev, this results in not removing the
>> ath11k
>> directory in debugfs folder even after rmmod of ath11k. So when next
>> time doing insmod of ath11k prevents creating another ath11k
>> directory,
>> hence causing ipq8074_2 to get created in parent dir of debugfs.
>>
>> Signed-off-by: Karthikeyan Kathirvel <kathirve@codeaurora.org>
>
> Fails to apply, please rebase. Also Tested-on missing.
>
> error: patch failed: drivers/net/wireless/ath/ath11k/debug.c:973
> error: drivers/net/wireless/ath/ath11k/debug.c: patch does not apply
> stg import: Diff does not apply cleanly
>
> Patch set to Changes Requested.
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-29 19:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 18:25 [PATCH] ath11k: removing the ath11k debugfs dir properly Karthikeyan Kathirvel
2020-09-23 18:25 ` Karthikeyan Kathirvel
2020-09-24 16:16 ` Kalle Valo
2020-09-24 16:16 ` Kalle Valo
[not found] ` <20200924161623.ED696C433F1@smtp.codeaurora.org>
2020-09-29 19:21 ` kathirve
2020-09-29 19:21 ` kathirve
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.