* [PATCH] irqchip: gpcv2: remove unnecessary functions
@ 2018-05-23 6:23 Anson Huang
2018-05-23 7:22 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Anson Huang @ 2018-05-23 6:23 UTC (permalink / raw)
To: tglx, jason, marc.zyngier; +Cc: Linux-imx, linux-kernel
GPC is in always-on domain, it never lost its
content during suspend/resume, so no need to
do save/restore for it during suspend/resume.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/irqchip/irq-imx-gpcv2.c | 41 -----------------------------------------
1 file changed, 41 deletions(-)
diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
index 4760307..e6025d9 100644
--- a/drivers/irqchip/irq-imx-gpcv2.c
+++ b/drivers/irqchip/irq-imx-gpcv2.c
@@ -28,46 +28,6 @@ struct gpcv2_irqchip_data {
static struct gpcv2_irqchip_data *imx_gpcv2_instance;
-static int gpcv2_wakeup_source_save(void)
-{
- struct gpcv2_irqchip_data *cd;
- void __iomem *reg;
- int i;
-
- cd = imx_gpcv2_instance;
- if (!cd)
- return 0;
-
- for (i = 0; i < IMR_NUM; i++) {
- reg = cd->gpc_base + cd->cpu2wakeup + i * 4;
- cd->saved_irq_mask[i] = readl_relaxed(reg);
- writel_relaxed(cd->wakeup_sources[i], reg);
- }
-
- return 0;
-}
-
-static void gpcv2_wakeup_source_restore(void)
-{
- struct gpcv2_irqchip_data *cd;
- void __iomem *reg;
- int i;
-
- cd = imx_gpcv2_instance;
- if (!cd)
- return;
-
- for (i = 0; i < IMR_NUM; i++) {
- reg = cd->gpc_base + cd->cpu2wakeup + i * 4;
- writel_relaxed(cd->saved_irq_mask[i], reg);
- }
-}
-
-static struct syscore_ops imx_gpcv2_syscore_ops = {
- .suspend = gpcv2_wakeup_source_save,
- .resume = gpcv2_wakeup_source_restore,
-};
-
static int imx_gpcv2_irq_set_wake(struct irq_data *d, unsigned int on)
{
struct gpcv2_irqchip_data *cd = d->chip_data;
@@ -252,7 +212,6 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
writel_relaxed(~0x1, cd->gpc_base + cd->cpu2wakeup);
imx_gpcv2_instance = cd;
- register_syscore_ops(&imx_gpcv2_syscore_ops);
/*
* Clear the OF_POPULATED flag set in of_irq_init so that
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip: gpcv2: remove unnecessary functions
2018-05-23 6:23 [PATCH] irqchip: gpcv2: remove unnecessary functions Anson Huang
@ 2018-05-23 7:22 ` Marc Zyngier
2018-05-23 7:35 ` Anson Huang
0 siblings, 1 reply; 3+ messages in thread
From: Marc Zyngier @ 2018-05-23 7:22 UTC (permalink / raw)
To: Anson Huang; +Cc: tglx, jason, Linux-imx, linux-kernel
On Wed, 23 May 2018 07:23:00 +0100,
Anson Huang wrote:
>
> GPC is in always-on domain, it never lost its
> content during suspend/resume, so no need to
> do save/restore for it during suspend/resume.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/irqchip/irq-imx-gpcv2.c | 41 -----------------------------------------
> 1 file changed, 41 deletions(-)
>
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 4760307..e6025d9 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -28,46 +28,6 @@ struct gpcv2_irqchip_data {
>
> static struct gpcv2_irqchip_data *imx_gpcv2_instance;
>
> -static int gpcv2_wakeup_source_save(void)
> -{
> - struct gpcv2_irqchip_data *cd;
> - void __iomem *reg;
> - int i;
> -
> - cd = imx_gpcv2_instance;
> - if (!cd)
> - return 0;
> -
> - for (i = 0; i < IMR_NUM; i++) {
> - reg = cd->gpc_base + cd->cpu2wakeup + i * 4;
> - cd->saved_irq_mask[i] = readl_relaxed(reg);
> - writel_relaxed(cd->wakeup_sources[i], reg);
> - }
If you're removing that code, what's the purpose of keeping
saved_irq_mask?
Also, who is now programming the wake-up_source? For good or bad
reasons, this drivers uses the save/restore hooks to program the
wake-up state. Removing this code seem to simply kill the feature.
What am I missing?
Thanks,
M.
--
Jazz is not dead, it just smell funny.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] irqchip: gpcv2: remove unnecessary functions
2018-05-23 7:22 ` Marc Zyngier
@ 2018-05-23 7:35 ` Anson Huang
0 siblings, 0 replies; 3+ messages in thread
From: Anson Huang @ 2018-05-23 7:35 UTC (permalink / raw)
To: Marc Zyngier; +Cc: tglx, jason, dl-linux-imx, linux-kernel
Hi, Marc
Anson Huang
Best Regards!
> -----Original Message-----
> From: Marc Zyngier [mailto:marc.zyngier@arm.com]
> Sent: Wednesday, May 23, 2018 3:23 PM
> To: Anson Huang <anson.huang@nxp.com>
> Cc: tglx@linutronix.de; jason@lakedaemon.net; dl-linux-imx
> <linux-imx@nxp.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] irqchip: gpcv2: remove unnecessary functions
>
> On Wed, 23 May 2018 07:23:00 +0100,
> Anson Huang wrote:
> >
> > GPC is in always-on domain, it never lost its content during
> > suspend/resume, so no need to do save/restore for it during
> > suspend/resume.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > drivers/irqchip/irq-imx-gpcv2.c | 41
> > -----------------------------------------
> > 1 file changed, 41 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-imx-gpcv2.c
> > b/drivers/irqchip/irq-imx-gpcv2.c index 4760307..e6025d9 100644
> > --- a/drivers/irqchip/irq-imx-gpcv2.c
> > +++ b/drivers/irqchip/irq-imx-gpcv2.c
> > @@ -28,46 +28,6 @@ struct gpcv2_irqchip_data {
> >
> > static struct gpcv2_irqchip_data *imx_gpcv2_instance;
> >
> > -static int gpcv2_wakeup_source_save(void) -{
> > - struct gpcv2_irqchip_data *cd;
> > - void __iomem *reg;
> > - int i;
> > -
> > - cd = imx_gpcv2_instance;
> > - if (!cd)
> > - return 0;
> > -
> > - for (i = 0; i < IMR_NUM; i++) {
> > - reg = cd->gpc_base + cd->cpu2wakeup + i * 4;
> > - cd->saved_irq_mask[i] = readl_relaxed(reg);
> > - writel_relaxed(cd->wakeup_sources[i], reg);
> > - }
>
> If you're removing that code, what's the purpose of keeping saved_irq_mask?
>
> Also, who is now programming the wake-up_source? For good or bad reasons,
> this drivers uses the save/restore hooks to program the wake-up state.
> Removing this code seem to simply kill the feature.
>
> What am I missing?
>
> Thanks,
I made a mistake here, forgot to program the wakeup source into GPC IMR register
In imx_gpcv2_irq_set_wake function.
And I think we can remove the saved_irq_mask as well, will do it in V2.
The wake-up source is programmed by module driver calling "enable_irq_wake" if
device wakeup capability is enabled, and I miss to program into GPC IMR register. Will
fix it later. Thanks.
Anson.
>
> M.
>
> --
> Jazz is not dead, it just smell funny.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-23 7:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-23 6:23 [PATCH] irqchip: gpcv2: remove unnecessary functions Anson Huang
2018-05-23 7:22 ` Marc Zyngier
2018-05-23 7:35 ` Anson Huang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.