* [PATCH -next] irqchip: orion: use of_address_count() helper
@ 2022-10-27 7:16 Yang Yingliang
2022-10-27 8:56 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Yang Yingliang @ 2022-10-27 7:16 UTC (permalink / raw)
To: linux-kernel; +Cc: tglx, maz
After commit 16988c742968 ("of/address: introduce of_address_count() helper"),
Use of_address_count() to instead of open-coding it, it's no functional change.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/irqchip/irq-orion.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-orion.c b/drivers/irqchip/irq-orion.c
index 17c2c7a07f10..4e4e874e09a8 100644
--- a/drivers/irqchip/irq-orion.c
+++ b/drivers/irqchip/irq-orion.c
@@ -57,8 +57,7 @@ static int __init orion_irq_init(struct device_node *np,
struct resource r;
/* count number of irq chips by valid reg addresses */
- while (of_address_to_resource(np, num_chips, &r) == 0)
- num_chips++;
+ num_chips = of_address_count(np);
orion_irq_domain = irq_domain_add_linear(np,
num_chips * ORION_IRQS_PER_CHIP,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] irqchip: orion: use of_address_count() helper
2022-10-27 7:16 [PATCH -next] irqchip: orion: use of_address_count() helper Yang Yingliang
@ 2022-10-27 8:56 ` Marc Zyngier
0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2022-10-27 8:56 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, tglx
On Thu, 27 Oct 2022 08:16:14 +0100,
Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> After commit 16988c742968 ("of/address: introduce of_address_count() helper"),
> Use of_address_count() to instead of open-coding it, it's no functional change.
$ git grep of_address_count| wc -l
0
Sorry, but I'm not taking patches for stuff that isn't in Linus'
tree. This sort of changes should be part of a series. Consider
reposting this once we reach 6.2-rc1.
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] irqchip: orion: use of_address_count() helper
@ 2023-07-26 3:07 Yang Yingliang
0 siblings, 0 replies; 3+ messages in thread
From: Yang Yingliang @ 2023-07-26 3:07 UTC (permalink / raw)
To: linux-kernel; +Cc: tglx, maz, yangyingliang
After commit 16988c742968 ("of/address: introduce of_address_count() helper"),
Use of_address_count() to instead of open-coding it, it's no functional change.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/irqchip/irq-orion.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-orion.c b/drivers/irqchip/irq-orion.c
index 17c2c7a07f10..4e4e874e09a8 100644
--- a/drivers/irqchip/irq-orion.c
+++ b/drivers/irqchip/irq-orion.c
@@ -57,8 +57,7 @@ static int __init orion_irq_init(struct device_node *np,
struct resource r;
/* count number of irq chips by valid reg addresses */
- while (of_address_to_resource(np, num_chips, &r) == 0)
- num_chips++;
+ num_chips = of_address_count(np);
orion_irq_domain = irq_domain_add_linear(np,
num_chips * ORION_IRQS_PER_CHIP,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-26 3:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-27 7:16 [PATCH -next] irqchip: orion: use of_address_count() helper Yang Yingliang
2022-10-27 8:56 ` Marc Zyngier
2023-07-26 3:07 Yang Yingliang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.