All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.de>,
	Michal Marek <mmarek@suse.com>,
	"intel-gfx\@lists.freedesktop..."
	<intel-gfx@lists.freedesktop.org>,
	Robert Lemaire <rlemaire@suse.com>
Subject: Re: [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort
Date: Thu, 12 Jan 2012 09:33:34 -0800	[thread overview]
Message-ID: <86ty404yhd.fsf@sumi.keithp.com> (raw)
In-Reply-To: <20120110054519.GA27257@localhost>

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

On Tue, 10 Jan 2012 13:45:19 +0800, Wu Fengguang <fengguang.wu@intel.com> wrote:

> @@ -5943,6 +5947,7 @@ static void ironlake_write_eld(struct dr
>  	if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) {
>  		DRM_DEBUG_DRIVER("ELD: DisplayPort detected\n");
>  		eld[5] |= (1 << 2);	/* Conn_Type, 0x1 = DisplayPort */
> +		I915_WRITE(aud_config, AUD_CONFIG_N_VALUE_INDEX); /* 0x1 = DP */
>  	}

Do we need to clear this bit in the HDMI case? Or do we just trust the
BIOS to either leave this bit zero or set it correctly?

-- 
keith.packard@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Keith Packard <keithp@keithp.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.de>,
	Michal Marek <mmarek@suse.com>,
	"intel-gfx@lists.freedesktop..."
	<intel-gfx@lists.freedesktop.org>,
	Robert Lemaire <rlemaire@suse.com>
Subject: Re: [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort
Date: Thu, 12 Jan 2012 09:33:34 -0800	[thread overview]
Message-ID: <86ty404yhd.fsf@sumi.keithp.com> (raw)
In-Reply-To: <20120110054519.GA27257@localhost>

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

On Tue, 10 Jan 2012 13:45:19 +0800, Wu Fengguang <fengguang.wu@intel.com> wrote:

> @@ -5943,6 +5947,7 @@ static void ironlake_write_eld(struct dr
>  	if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) {
>  		DRM_DEBUG_DRIVER("ELD: DisplayPort detected\n");
>  		eld[5] |= (1 << 2);	/* Conn_Type, 0x1 = DisplayPort */
> +		I915_WRITE(aud_config, AUD_CONFIG_N_VALUE_INDEX); /* 0x1 = DP */
>  	}

Do we need to clear this bit in the HDMI case? Or do we just trust the
BIOS to either leave this bit zero or set it correctly?

-- 
keith.packard@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]

  reply	other threads:[~2012-01-12 17:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-09 13:17 [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort Wu Fengguang
2012-01-09 13:17 ` Wu Fengguang
2012-01-09 17:22 ` Keith Packard
2012-01-09 17:22   ` Keith Packard
2012-01-10  5:45   ` Wu Fengguang
2012-01-12 17:33     ` Keith Packard [this message]
2012-01-12 17:33       ` Keith Packard
2012-01-16  8:02       ` Wu Fengguang
2012-01-16  8:02         ` Wu Fengguang
2012-01-16 20:26         ` [Intel-gfx] " Daniel Vetter
2012-01-16 20:26           ` Daniel Vetter
2012-01-16 20:44           ` [Intel-gfx] " Keith Packard
2012-01-16 20:44             ` Keith Packard
2012-01-16 23:08             ` Wu Fengguang
2012-01-16 23:15               ` Keith Packard
2012-01-16 23:15                 ` Keith Packard
2012-01-17 10:22               ` [Intel-gfx] " Daniel Vetter
2012-01-29  4:44                 ` [PATCH][rebased] " Wu Fengguang
2012-01-29  4:44                   ` Wu Fengguang
2012-01-29 12:12                   ` Daniel Vetter
2012-01-29 12:12                     ` Daniel Vetter
2012-01-29 13:23                     ` Wu Fengguang
2012-01-29 13:23                       ` Wu Fengguang
2012-01-29 15:14                       ` Daniel Vetter
2012-01-29 15:14                         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ty404yhd.fsf@sumi.keithp.com \
    --to=keithp@keithp.com \
    --cc=fengguang.wu@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=rlemaire@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.