[PATCH 0/1] Document keyctl(KEYCTL_PKEY_QUERY) arguments correctly

[PATCH 0/1] Document keyctl(KEYCTL_PKEY_QUERY) arguments correctly

[Ben Boeckel]

From: Ben Boeckel <mathstuf@gmail.com>

This is the way the code parses the arguments and libkeyutils calls the
syscall.

Note on the email split: I'm still in the process of migrating emails
for various usages hence the email From mismatch here (I've migrated my
list subscription, but not my general contribution email).

Ben Boeckel (1):
  Documentation: security: core.rst: add missing argument

 Documentation/security/keys/core.rst | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)


base-commit: 12bf0b632ed090358cbf03e323e5342212d0b2e4
-- 
2.25.4

[PATCH 0/1] Document keyctl(KEYCTL_PKEY_QUERY) arguments correctly

[Ben Boeckel]

From: Ben Boeckel <mathstuf@gmail.com>

This is the way the code parses the arguments and libkeyutils calls the
syscall.

Note on the email split: I'm still in the process of migrating emails
for various usages hence the email From mismatch here (I've migrated my
list subscription, but not my general contribution email).

Ben Boeckel (1):
  Documentation: security: core.rst: add missing argument

 Documentation/security/keys/core.rst | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)


base-commit: 12bf0b632ed090358cbf03e323e5342212d0b2e4
-- 
2.25.4

[PATCH 1/1] Documentation: security: core.rst: add missing argument

[Ben Boeckel]

From: Ben Boeckel <mathstuf@gmail.com>

This argument was just never documented in the first place.

Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
---
 Documentation/security/keys/core.rst | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/security/keys/core.rst b/Documentation/security/keys/core.rst
index d9b0b859018b..c26b9e7d47c2 100644
--- a/Documentation/security/keys/core.rst
+++ b/Documentation/security/keys/core.rst
@@ -920,10 +920,14 @@ The keyctl syscall functions are:
 
 	long keyctl(KEYCTL_PKEY_QUERY,
 		    key_serial_t key_id, unsigned long reserved,
+		    const char* params,
 		    struct keyctl_pkey_query *info);
 
-     Get information about an asymmetric key.  The information is returned in
-     the keyctl_pkey_query struct::
+     Get information about an asymmetric key.  Specific algorithms and
+     encodings may be queried by using the ``params`` argument.  This is a
+     string containing a space- or tab-separated string of key-value pairs.
+     Currently supported keys include ``enc`` and ``hash``.  The information
+     is returned in the keyctl_pkey_query struct::
 
 	__u32	supported_ops;
 	__u32	key_size;
-- 
2.25.4

[PATCH 1/1] Documentation: security: core.rst: add missing argument

[Ben Boeckel]

From: Ben Boeckel <mathstuf@gmail.com>

This argument was just never documented in the first place.

Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
---
 Documentation/security/keys/core.rst | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/security/keys/core.rst b/Documentation/security/keys/core.rst
index d9b0b859018b..c26b9e7d47c2 100644
--- a/Documentation/security/keys/core.rst
+++ b/Documentation/security/keys/core.rst
@@ -920,10 +920,14 @@ The keyctl syscall functions are:
 
 	long keyctl(KEYCTL_PKEY_QUERY,
 		    key_serial_t key_id, unsigned long reserved,
+		    const char* params,
 		    struct keyctl_pkey_query *info);
 
-     Get information about an asymmetric key.  The information is returned in
-     the keyctl_pkey_query struct::
+     Get information about an asymmetric key.  Specific algorithms and
+     encodings may be queried by using the ``params`` argument.  This is a
+     string containing a space- or tab-separated string of key-value pairs.
+     Currently supported keys include ``enc`` and ``hash``.  The information
+     is returned in the keyctl_pkey_query struct::
 
 	__u32	supported_ops;
 	__u32	key_size;
-- 
2.25.4

Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

[Jarkko Sakkinen]

On Fri, 2020-05-15 at 20:39 -0400, Ben Boeckel wrote:
> From: Ben Boeckel <mathstuf@gmail.com>
> 
> This argument was just never documented in the first place.
> 
> Signed-off-by: Ben Boeckel <mathstuf@gmail.com>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

[Jarkko Sakkinen]

On Fri, 2020-05-15 at 20:39 -0400, Ben Boeckel wrote:
> From: Ben Boeckel <mathstuf@gmail.com>
> 
> This argument was just never documented in the first place.
> 
> Signed-off-by: Ben Boeckel <mathstuf@gmail.com>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

[Jonathan Corbet]

On Fri, 15 May 2020 20:39:17 -0400
Ben Boeckel <me@benboeckel.net> wrote:

> From: Ben Boeckel <mathstuf@gmail.com>
> 
> This argument was just never documented in the first place.
> 
> Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
> ---
>  Documentation/security/keys/core.rst | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks.

jon

Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

[Jonathan Corbet]

On Fri, 15 May 2020 20:39:17 -0400
Ben Boeckel <me@benboeckel.net> wrote:

> From: Ben Boeckel <mathstuf@gmail.com>
> 
> This argument was just never documented in the first place.
> 
> Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
> ---
>  Documentation/security/keys/core.rst | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks.

jon

Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

[Jonathan Corbet]

On Mon, 25 May 2020 10:33:10 -0600
Jonathan Corbet <corbet@lwn.net> wrote:

> On Fri, 15 May 2020 20:39:17 -0400
> Ben Boeckel <me@benboeckel.net> wrote:
> 
> > From: Ben Boeckel <mathstuf@gmail.com>
> > 
> > This argument was just never documented in the first place.
> > 
> > Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
> > ---
> >  Documentation/security/keys/core.rst | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)  
> 
> Applied, thanks.

...or not...looks like David got there first.  Sorry for the noise.

jon

Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

[Jonathan Corbet]

On Mon, 25 May 2020 10:33:10 -0600
Jonathan Corbet <corbet@lwn.net> wrote:

> On Fri, 15 May 2020 20:39:17 -0400
> Ben Boeckel <me@benboeckel.net> wrote:
> 
> > From: Ben Boeckel <mathstuf@gmail.com>
> > 
> > This argument was just never documented in the first place.
> > 
> > Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
> > ---
> >  Documentation/security/keys/core.rst | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)  
> 
> Applied, thanks.

...or not...looks like David got there first.  Sorry for the noise.

jon

Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

[David Howells]

Jonathan Corbet <corbet@lwn.net> wrote:

> Applied, thanks.

Ah - I've applied it to my keys-next branch.

David

Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

[David Howells]

Jonathan Corbet <corbet@lwn.net> wrote:

> Applied, thanks.

Ah - I've applied it to my keys-next branch.

David

Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

[David Howells]

Ben Boeckel <me@benboeckel.net> wrote:

>  	long keyctl(KEYCTL_PKEY_QUERY,
>  		    key_serial_t key_id, unsigned long reserved,
> +		    const char* params,
>  		    struct keyctl_pkey_query *info);

"const char *params".  I fixed that and applied it.

David

Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

[David Howells]

Ben Boeckel <me@benboeckel.net> wrote:

>  	long keyctl(KEYCTL_PKEY_QUERY,
>  		    key_serial_t key_id, unsigned long reserved,
> +		    const char* params,
>  		    struct keyctl_pkey_query *info);

"const char *params".  I fixed that and applied it.

David