All of lore.kernel.org
 help / color / mirror / Atom feed
* mSHEC r33 release
@ 2015-01-23 14:30 Miyamae, Takeshi
  2015-01-23 14:39 ` Loic Dachary
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Miyamae, Takeshi @ 2015-01-23 14:30 UTC (permalink / raw)
  To: Loic Dachary
  Cc: Ceph Development, Shiozawa, Kensuke, Nakao, Takanori,
	Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com),
	Kaga, Yoshihiro, Kawaguchi, Shotaro

Hi Loic,

We have released mSHEC r33 just now.

https://github.com/t-miyamae/ceph

NOTABLE CHANGES
  - ensure thread safety
  - support generator matrix cache (added ErasureCodeShecTableCache.cc)
  - refer to the shared jerasure 2.0 library
  - improve verification of return code in test codes
  - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)

LIMITATION
  - There are still lots of minor problems in test codes.
    We will fix it by 1/26(mon).

Best regards,
Takeshi Miyamae


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: mSHEC r33 release
  2015-01-23 14:30 mSHEC r33 release Miyamae, Takeshi
@ 2015-01-23 14:39 ` Loic Dachary
  2015-01-24  9:09   ` Miyamae, Takeshi
  2015-01-23 20:51 ` Loic Dachary
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 11+ messages in thread
From: Loic Dachary @ 2015-01-23 14:39 UTC (permalink / raw)
  To: Miyamae, Takeshi
  Cc: Ceph Development, Shiozawa, Kensuke, Nakao, Takanori,
	Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com),
	Kaga, Yoshihiro, Kawaguchi, Shotaro

[-- Attachment #1: Type: text/plain, Size: 910 bytes --]

Thanks, I'll take a look. Could you please create a pull request against the master branch ? When you do so, it will be convenient if you submit from a branch that has a descriptive name such as wip-mSHEC or something similar.

Cheers

On 23/01/2015 15:30, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> We have released mSHEC r33 just now.
> 
> https://github.com/t-miyamae/ceph
> 
> NOTABLE CHANGES
>   - ensure thread safety
>   - support generator matrix cache (added ErasureCodeShecTableCache.cc)
>   - refer to the shared jerasure 2.0 library
>   - improve verification of return code in test codes
>   - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)
> 
> LIMITATION
>   - There are still lots of minor problems in test codes.
>     We will fix it by 1/26(mon).
> 
> Best regards,
> Takeshi Miyamae
> 


-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: mSHEC r33 release
  2015-01-23 14:30 mSHEC r33 release Miyamae, Takeshi
  2015-01-23 14:39 ` Loic Dachary
@ 2015-01-23 20:51 ` Loic Dachary
  2015-01-23 23:39 ` Loic Dachary
  2015-01-23 23:59 ` Loic Dachary
  3 siblings, 0 replies; 11+ messages in thread
From: Loic Dachary @ 2015-01-23 20:51 UTC (permalink / raw)
  To: Miyamae, Takeshi
  Cc: Ceph Development, Shiozawa, Kensuke, Nakao, Takanori,
	Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com),
	Kaga, Yoshihiro, Kawaguchi, Shotaro

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

Hi,

There seems to be a file missing:

make unittest_erasure_code_shec364
  CXX      test/erasure-code/unittest_erasure_code_shec364-TestErasureCodeShec364.o
test/erasure-code/TestErasureCodeShec364.cc:21:35: fatal error: test/erasure-code/csv.h: No such file or directory
 #include "test/erasure-code/csv.h"

Cheers

On 23/01/2015 15:30, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> We have released mSHEC r33 just now.
> 
> https://github.com/t-miyamae/ceph
> 
> NOTABLE CHANGES
>   - ensure thread safety
>   - support generator matrix cache (added ErasureCodeShecTableCache.cc)
>   - refer to the shared jerasure 2.0 library
>   - improve verification of return code in test codes
>   - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)
> 
> LIMITATION
>   - There are still lots of minor problems in test codes.
>     We will fix it by 1/26(mon).
> 
> Best regards,
> Takeshi Miyamae
> 
> N�����r��y���b�X��ǧv�^�)޺{.n�+���z�]z���{ay�\x1dʇڙ�,j\a��f���h���z�\x1e�w���\f���j:+v���w�j�m����\a����zZ+�����ݢj"��!tml=
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: mSHEC r33 release
  2015-01-23 14:30 mSHEC r33 release Miyamae, Takeshi
  2015-01-23 14:39 ` Loic Dachary
  2015-01-23 20:51 ` Loic Dachary
@ 2015-01-23 23:39 ` Loic Dachary
  2015-01-24  8:13   ` Miyamae, Takeshi
  2015-01-23 23:59 ` Loic Dachary
  3 siblings, 1 reply; 11+ messages in thread
From: Loic Dachary @ 2015-01-23 23:39 UTC (permalink / raw)
  To: Miyamae, Takeshi
  Cc: Ceph Development, Shiozawa, Kensuke, Nakao, Takanori,
	Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com),
	Kaga, Yoshihiro, Kawaguchi, Shotaro

[-- Attachment #1: Type: text/plain, Size: 1890 bytes --]

Hi,

Since the SHEC plugin depends on the jerasure plugin, it would be simpler if it loaded it instead of including it. The main problem with the current inclusion is that it does not compile any SIMD acceleration code and loses the benefit of optimization when the CPU can provide it. 

There are two ways out of this 

a) add to the SHEC plugin the same selection that jerasure has (in the Makefile and with something like http://workbench.dachary.org/ceph/ceph/blob/master/src/erasure-code/jerasure/ErasureCodePluginSelectJerasure.cc

b) compile jerasure as a convenience library that can be included by both the jerasure and SHEC plugin.

The LRC plugin loads the jerasure plugin but the SHEC plugin cannot do the same because the standard API at http://workbench.dachary.org/ceph/ceph/blob/master/src/erasure-code/ErasureCodeInterface.h is not enough.

Note that this is not a blocker for the inclusion of the plugin and can be done afterwards.

Cheers

On 23/01/2015 15:30, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> We have released mSHEC r33 just now.
> 
> https://github.com/t-miyamae/ceph
> 
> NOTABLE CHANGES
>   - ensure thread safety
>   - support generator matrix cache (added ErasureCodeShecTableCache.cc)
>   - refer to the shared jerasure 2.0 library
>   - improve verification of return code in test codes
>   - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)
> 
> LIMITATION
>   - There are still lots of minor problems in test codes.
>     We will fix it by 1/26(mon).
> 
> Best regards,
> Takeshi Miyamae
> 
> N�����r��y���b�X��ǧv�^�)޺{.n�+���z�]z���{ay�\x1dʇڙ�,j\a��f���h���z�\x1e�w���\f���j:+v���w�j�m����\a����zZ+�����ݢj"��!tml=
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: mSHEC r33 release
  2015-01-23 14:30 mSHEC r33 release Miyamae, Takeshi
                   ` (2 preceding siblings ...)
  2015-01-23 23:39 ` Loic Dachary
@ 2015-01-23 23:59 ` Loic Dachary
  3 siblings, 0 replies; 11+ messages in thread
From: Loic Dachary @ 2015-01-23 23:59 UTC (permalink / raw)
  To: Miyamae, Takeshi
  Cc: Ceph Development, Shiozawa, Kensuke, Nakao, Takanori,
	Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com),
	Kaga, Yoshihiro, Kawaguchi, Shotaro

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

Hi,

I see the following error when running make check http://paste2.org/dNChVpL1 . Does it ring a bell ?

Cheers

On 23/01/2015 15:30, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> We have released mSHEC r33 just now.
> 
> https://github.com/t-miyamae/ceph
> 
> NOTABLE CHANGES
>   - ensure thread safety
>   - support generator matrix cache (added ErasureCodeShecTableCache.cc)
>   - refer to the shared jerasure 2.0 library
>   - improve verification of return code in test codes
>   - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)
> 
> LIMITATION
>   - There are still lots of minor problems in test codes.
>     We will fix it by 1/26(mon).
> 
> Best regards,
> Takeshi Miyamae
> 
> N�����r��y���b�X��ǧv�^�)޺{.n�+���z�]z���{ay�\x1dʇڙ�,j\a��f���h���z�\x1e�w���\f���j:+v���w�j�m����\a����zZ+�����ݢj"��!tml=
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: mSHEC r33 release
  2015-01-23 23:39 ` Loic Dachary
@ 2015-01-24  8:13   ` Miyamae, Takeshi
  2015-01-24 16:21     ` Loic Dachary
  0 siblings, 1 reply; 11+ messages in thread
From: Miyamae, Takeshi @ 2015-01-24  8:13 UTC (permalink / raw)
  To: Loic Dachary
  Cc: Ceph Development, Shiozawa, Kensuke, Nakao, Takanori,
	Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com),
	Kaga, Yoshihiro, Kawaguchi, Shotaro

Hi Loic,

Thank you for your advice and information.
Both approaches are attractive and we have started to consider which one to take.
However, I'm afraid that we might not have enough time to implement and test it
until the first release of Hammer.

Best regards,
Takeshi Miyamae

-----Original Message-----
From: Loic Dachary [mailto:loic@dachary.org] 
Sent: Saturday, January 24, 2015 8:40 AM
To: Miyamae, Takeshi/宮前 剛
Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗
Subject: Re: mSHEC r33 release

Hi,

Since the SHEC plugin depends on the jerasure plugin, it would be simpler if it loaded it instead of including it. The main problem with the current inclusion is that it does not compile any SIMD acceleration code and loses the benefit of optimization when the CPU can provide it. 

There are two ways out of this 

a) add to the SHEC plugin the same selection that jerasure has (in the Makefile and with something like http://workbench.dachary.org/ceph/ceph/blob/master/src/erasure-code/jerasure/ErasureCodePluginSelectJerasure.cc

b) compile jerasure as a convenience library that can be included by both the jerasure and SHEC plugin.

The LRC plugin loads the jerasure plugin but the SHEC plugin cannot do the same because the standard API at http://workbench.dachary.org/ceph/ceph/blob/master/src/erasure-code/ErasureCodeInterface.h is not enough.

Note that this is not a blocker for the inclusion of the plugin and can be done afterwards.

Cheers

On 23/01/2015 15:30, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> We have released mSHEC r33 just now.
> 
> https://github.com/t-miyamae/ceph
> 
> NOTABLE CHANGES
>   - ensure thread safety
>   - support generator matrix cache (added ErasureCodeShecTableCache.cc)
>   - refer to the shared jerasure 2.0 library
>   - improve verification of return code in test codes
>   - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)
> 
> LIMITATION
>   - There are still lots of minor problems in test codes.
>     We will fix it by 1/26(mon).
> 
> Best regards,
> Takeshi Miyamae
> 
> N�����r��y���b�X��ǧv�^�)޺{.n�+���z�]z���{ay�\x1dʇڙ�,j\r��f���h���z�\x1e�w���
���j:+v���w�j�m����\r����zZ+�����ݢj"��!tml=
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: mSHEC r33 release
  2015-01-23 14:39 ` Loic Dachary
@ 2015-01-24  9:09   ` Miyamae, Takeshi
  2015-01-24 16:20     ` Loic Dachary
  0 siblings, 1 reply; 11+ messages in thread
From: Miyamae, Takeshi @ 2015-01-24  9:09 UTC (permalink / raw)
  To: Loic Dachary
  Cc: Ceph Development, Shiozawa, Kensuke, Nakao, Takanori,
	Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com),
	Kaga, Yoshihiro, Kawaguchi, Shotaro

Hi Loic,

I have created a pull request of wip-mSHEC.

wip-mSHEC pull request #3484
https://github.com/ceph/ceph/pull/3484

Besides, we changed the name of our fork repository.
https://github.com/t-miyamae/wip-mSHEC

I'm not sure that it was done correctly because I am a beginner.
Would you check it, please?

Best regards,
Takeshi Miyamae

-----Original Message-----
From: Loic Dachary [mailto:loic@dachary.org] 
Sent: Friday, January 23, 2015 11:40 PM
To: Miyamae, Takeshi/宮前 剛
Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗
Subject: Re: mSHEC r33 release

Thanks, I'll take a look. Could you please create a pull request against the master branch ? When you do so, it will be convenient if you submit from a branch that has a descriptive name such as wip-mSHEC or something similar.

Cheers

On 23/01/2015 15:30, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> We have released mSHEC r33 just now.
> 
> https://github.com/t-miyamae/ceph
> 
> NOTABLE CHANGES
>   - ensure thread safety
>   - support generator matrix cache (added ErasureCodeShecTableCache.cc)
>   - refer to the shared jerasure 2.0 library
>   - improve verification of return code in test codes
>   - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)
> 
> LIMITATION
>   - There are still lots of minor problems in test codes.
>     We will fix it by 1/26(mon).
> 
> Best regards,
> Takeshi Miyamae
> 


-- 
Loïc Dachary, Artisan Logiciel Libre


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: mSHEC r33 release
  2015-01-24  9:09   ` Miyamae, Takeshi
@ 2015-01-24 16:20     ` Loic Dachary
  2015-01-26  2:21       ` Miyamae, Takeshi
  0 siblings, 1 reply; 11+ messages in thread
From: Loic Dachary @ 2015-01-24 16:20 UTC (permalink / raw)
  To: Miyamae, Takeshi
  Cc: Ceph Development, Shiozawa, Kensuke, Nakao, Takanori,
	Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com),
	Kaga, Yoshihiro, Kawaguchi, Shotaro

[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]

Hi,

On 24/01/2015 10:09, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> I have created a pull request of wip-mSHEC.
> 
> wip-mSHEC pull request #3484
> https://github.com/ceph/ceph/pull/3484
> 
> Besides, we changed the name of our fork repository.
> https://github.com/t-miyamae/wip-mSHEC
> 
> I'm not sure that it was done correctly because I am a beginner.
> Would you check it, please?

It looks like the branch from which you created the pull request still is master and not wip-mSHEC. That's not a problem. It only really becomes a problem if you have more than one pull request going on.

Cheers

> 
> Best regards,
> Takeshi Miyamae
> 
> -----Original Message-----
> From: Loic Dachary [mailto:loic@dachary.org] 
> Sent: Friday, January 23, 2015 11:40 PM
> To: Miyamae, Takeshi/宮前 剛
> Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗
> Subject: Re: mSHEC r33 release
> 
> Thanks, I'll take a look. Could you please create a pull request against the master branch ? When you do so, it will be convenient if you submit from a branch that has a descriptive name such as wip-mSHEC or something similar.
> 
> Cheers
> 
> On 23/01/2015 15:30, Miyamae, Takeshi wrote:
>> Hi Loic,
>>
>> We have released mSHEC r33 just now.
>>
>> https://github.com/t-miyamae/ceph
>>
>> NOTABLE CHANGES
>>   - ensure thread safety
>>   - support generator matrix cache (added ErasureCodeShecTableCache.cc)
>>   - refer to the shared jerasure 2.0 library
>>   - improve verification of return code in test codes
>>   - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)
>>
>> LIMITATION
>>   - There are still lots of minor problems in test codes.
>>     We will fix it by 1/26(mon).
>>
>> Best regards,
>> Takeshi Miyamae
>>
> 
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: mSHEC r33 release
  2015-01-24  8:13   ` Miyamae, Takeshi
@ 2015-01-24 16:21     ` Loic Dachary
  0 siblings, 0 replies; 11+ messages in thread
From: Loic Dachary @ 2015-01-24 16:21 UTC (permalink / raw)
  To: Miyamae, Takeshi
  Cc: Ceph Development, Shiozawa, Kensuke, Nakao, Takanori,
	Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com),
	Kaga, Yoshihiro, Kawaguchi, Shotaro

[-- Attachment #1: Type: text/plain, Size: 2736 bytes --]



On 24/01/2015 09:13, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> Thank you for your advice and information.
> Both approaches are attractive and we have started to consider which one to take.
> However, I'm afraid that we might not have enough time to implement and test it
> until the first release of Hammer.

Ok, no problem.

> 
> Best regards,
> Takeshi Miyamae
> 
> -----Original Message-----
> From: Loic Dachary [mailto:loic@dachary.org] 
> Sent: Saturday, January 24, 2015 8:40 AM
> To: Miyamae, Takeshi/宮前 剛
> Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗
> Subject: Re: mSHEC r33 release
> 
> Hi,
> 
> Since the SHEC plugin depends on the jerasure plugin, it would be simpler if it loaded it instead of including it. The main problem with the current inclusion is that it does not compile any SIMD acceleration code and loses the benefit of optimization when the CPU can provide it. 
> 
> There are two ways out of this 
> 
> a) add to the SHEC plugin the same selection that jerasure has (in the Makefile and with something like http://workbench.dachary.org/ceph/ceph/blob/master/src/erasure-code/jerasure/ErasureCodePluginSelectJerasure.cc
> 
> b) compile jerasure as a convenience library that can be included by both the jerasure and SHEC plugin.
> 
> The LRC plugin loads the jerasure plugin but the SHEC plugin cannot do the same because the standard API at http://workbench.dachary.org/ceph/ceph/blob/master/src/erasure-code/ErasureCodeInterface.h is not enough.
> 
> Note that this is not a blocker for the inclusion of the plugin and can be done afterwards.
> 
> Cheers
> 
> On 23/01/2015 15:30, Miyamae, Takeshi wrote:
>> Hi Loic,
>>
>> We have released mSHEC r33 just now.
>>
>> https://github.com/t-miyamae/ceph
>>
>> NOTABLE CHANGES
>>   - ensure thread safety
>>   - support generator matrix cache (added ErasureCodeShecTableCache.cc)
>>   - refer to the shared jerasure 2.0 library
>>   - improve verification of return code in test codes
>>   - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)
>>
>> LIMITATION
>>   - There are still lots of minor problems in test codes.
>>     We will fix it by 1/26(mon).
>>
>> Best regards,
>> Takeshi Miyamae
>>
>> N�����r��y���b�X��ǧv�^�)޺{.n�+���z�]z���{ay�\x1dʇڙ�,j
> ��f���h���z�\x1e�w���
> ���j:+v���w�j�m����
> ����zZ+�����ݢj"��!tml=
>>
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: mSHEC r33 release
  2015-01-24 16:20     ` Loic Dachary
@ 2015-01-26  2:21       ` Miyamae, Takeshi
  2015-01-26  2:43         ` Miyamae, Takeshi
  0 siblings, 1 reply; 11+ messages in thread
From: Miyamae, Takeshi @ 2015-01-26  2:21 UTC (permalink / raw)
  To: Loic Dachary
  Cc: Ceph Development, Shiozawa, Kensuke, Nakao, Takanori,
	Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com),
	Kaga, Yoshihiro, Kawaguchi, Shotaro

Hi Loic,

> It looks like the branch from which you created the pull request still is master and not wip-mSHEC. 
> That's not a problem. It only really becomes a problem if you have more than one pull request going on.

I'm sorry that I didn't have such a common sense.
We recreated the pull request from wip-mSHEC branch.

wip-mSHEC : multiple Shingled Erasure Code #3488
https://github.com/ceph/ceph/pull/3488

Could you change the branch you will pull from?
If it were difficult or not good for the reason of logging comment already written, pulling from master branch would also be OK for us and I would remove the latter pull request.

Best regards,
Takeshi Miyamae

-----Original Message-----
From: Loic Dachary [mailto:loic@dachary.org] 
Sent: Sunday, January 25, 2015 1:20 AM
To: Miyamae, Takeshi/宮前 剛
Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗
Subject: Re: mSHEC r33 release

Hi,

On 24/01/2015 10:09, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> I have created a pull request of wip-mSHEC.
> 
> wip-mSHEC pull request #3484
> https://github.com/ceph/ceph/pull/3484
> 
> Besides, we changed the name of our fork repository.
> https://github.com/t-miyamae/wip-mSHEC
> 
> I'm not sure that it was done correctly because I am a beginner.
> Would you check it, please?

It looks like the branch from which you created the pull request still is master and not wip-mSHEC. That's not a problem. It only really becomes a problem if you have more than one pull request going on.

Cheers

> 
> Best regards,
> Takeshi Miyamae
> 
> -----Original Message-----
> From: Loic Dachary [mailto:loic@dachary.org] 
> Sent: Friday, January 23, 2015 11:40 PM
> To: Miyamae, Takeshi/宮前 剛
> Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗
> Subject: Re: mSHEC r33 release
> 
> Thanks, I'll take a look. Could you please create a pull request against the master branch ? When you do so, it will be convenient if you submit from a branch that has a descriptive name such as wip-mSHEC or something similar.
> 
> Cheers
> 
> On 23/01/2015 15:30, Miyamae, Takeshi wrote:
>> Hi Loic,
>>
>> We have released mSHEC r33 just now.
>>
>> https://github.com/t-miyamae/ceph
>>
>> NOTABLE CHANGES
>>   - ensure thread safety
>>   - support generator matrix cache (added ErasureCodeShecTableCache.cc)
>>   - refer to the shared jerasure 2.0 library
>>   - improve verification of return code in test codes
>>   - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)
>>
>> LIMITATION
>>   - There are still lots of minor problems in test codes.
>>     We will fix it by 1/26(mon).
>>
>> Best regards,
>> Takeshi Miyamae
>>
> 
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: mSHEC r33 release
  2015-01-26  2:21       ` Miyamae, Takeshi
@ 2015-01-26  2:43         ` Miyamae, Takeshi
  0 siblings, 0 replies; 11+ messages in thread
From: Miyamae, Takeshi @ 2015-01-26  2:43 UTC (permalink / raw)
  To: Miyamae, Takeshi, Loic Dachary
  Cc: Ceph Development, Shiozawa, Kensuke, Nakao, Takanori,
	Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com),
	Kaga, Yoshihiro, Kawaguchi, Shotaro

Hi Loic

> We recreated the pull request from wip-mSHEC branch.

I'm sorry. I had thought twice and judged it would not be better to change the branch.
I'd close our 2nd pull request and delete wip-mSHEC branch.

Only #3484 is alive as our mSHEC pull request at this moment.

wip-mSHEC : multiple Shingled Erasure Code #3484
https://github.com/ceph/ceph/pull/3484

Best regareds,
Takeshi Miyamae

-----Original Message-----
From: ceph-devel-owner@vger.kernel.org [mailto:ceph-devel-owner@vger.kernel.org] On Behalf Of Miyamae, Takeshi
Sent: Monday, January 26, 2015 11:22 AM
To: Loic Dachary
Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗
Subject: RE: mSHEC r33 release

Hi Loic,

> It looks like the branch from which you created the pull request still is master and not wip-mSHEC. 
> That's not a problem. It only really becomes a problem if you have more than one pull request going on.

I'm sorry that I didn't have such a common sense.
We recreated the pull request from wip-mSHEC branch.

wip-mSHEC : multiple Shingled Erasure Code #3488
https://github.com/ceph/ceph/pull/3488

Could you change the branch you will pull from?
If it were difficult or not good for the reason of logging comment already written, pulling from master branch would also be OK for us and I would remove the latter pull request.

Best regards,
Takeshi Miyamae

-----Original Message-----
From: Loic Dachary [mailto:loic@dachary.org] 
Sent: Sunday, January 25, 2015 1:20 AM
To: Miyamae, Takeshi/宮前 剛
Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗
Subject: Re: mSHEC r33 release

Hi,

On 24/01/2015 10:09, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> I have created a pull request of wip-mSHEC.
> 
> wip-mSHEC pull request #3484
> https://github.com/ceph/ceph/pull/3484
> 
> Besides, we changed the name of our fork repository.
> https://github.com/t-miyamae/wip-mSHEC
> 
> I'm not sure that it was done correctly because I am a beginner.
> Would you check it, please?

It looks like the branch from which you created the pull request still is master and not wip-mSHEC. That's not a problem. It only really becomes a problem if you have more than one pull request going on.

Cheers

> 
> Best regards,
> Takeshi Miyamae
> 
> -----Original Message-----
> From: Loic Dachary [mailto:loic@dachary.org] 
> Sent: Friday, January 23, 2015 11:40 PM
> To: Miyamae, Takeshi/宮前 剛
> Cc: Ceph Development; Shiozawa, Kensuke/塩沢 賢輔; Nakao, Takanori/中尾 鷹詔; Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com); Kaga, Yoshihiro/加賀 芳宏; Kawaguchi, Shotaro/川口 翔太朗
> Subject: Re: mSHEC r33 release
> 
> Thanks, I'll take a look. Could you please create a pull request against the master branch ? When you do so, it will be convenient if you submit from a branch that has a descriptive name such as wip-mSHEC or something similar.
> 
> Cheers
> 
> On 23/01/2015 15:30, Miyamae, Takeshi wrote:
>> Hi Loic,
>>
>> We have released mSHEC r33 just now.
>>
>> https://github.com/t-miyamae/ceph
>>
>> NOTABLE CHANGES
>>   - ensure thread safety
>>   - support generator matrix cache (added ErasureCodeShecTableCache.cc)
>>   - refer to the shared jerasure 2.0 library
>>   - improve verification of return code in test codes
>>   - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)
>>
>> LIMITATION
>>   - There are still lots of minor problems in test codes.
>>     We will fix it by 1/26(mon).
>>
>> Best regards,
>> Takeshi Miyamae
>>
> 
> 

-- 
Loïc Dachary, Artisan Logiciel Libre

\x04�{.n�+�������+%��lzwm��b�맲��r��yǩ�ׯzX��\x17��ܨ}���Ơz�&j:+v���\r����zZ+��+zf���h���~����i���z�\x1e�w���?����&�)ߢ^[f

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2015-01-26  2:43 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-23 14:30 mSHEC r33 release Miyamae, Takeshi
2015-01-23 14:39 ` Loic Dachary
2015-01-24  9:09   ` Miyamae, Takeshi
2015-01-24 16:20     ` Loic Dachary
2015-01-26  2:21       ` Miyamae, Takeshi
2015-01-26  2:43         ` Miyamae, Takeshi
2015-01-23 20:51 ` Loic Dachary
2015-01-23 23:39 ` Loic Dachary
2015-01-24  8:13   ` Miyamae, Takeshi
2015-01-24 16:21     ` Loic Dachary
2015-01-23 23:59 ` Loic Dachary

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.