* [PATCH v2] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs
@ 2022-05-16 8:23 Thomas Huth
2022-05-16 8:26 ` Daniel P. Berrangé
2022-05-27 13:54 ` Alex Bennée
0 siblings, 2 replies; 5+ messages in thread
From: Thomas Huth @ 2022-05-16 8:23 UTC (permalink / raw)
To: qemu-devel, John Snow
Cc: Alex Bennée, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Beraldo Leal,
Daniel P . Berrangé
The 'check-patch' and 'check-dco' jobs only need Python and git for
checking the patches, so it's not really necessary to use a container
here that has all the other build dependencies installed. By using a
lightweight Alpine container, we can improve the runtime here quite a
bit, cutting it down from ca. 1:30 minutes to ca. 45 seconds.
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
v2: Use python:alpine for even quicker execution
.gitlab-ci.d/static_checks.yml | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/.gitlab-ci.d/static_checks.yml b/.gitlab-ci.d/static_checks.yml
index 5e955540d3..94858e3272 100644
--- a/.gitlab-ci.d/static_checks.yml
+++ b/.gitlab-ci.d/static_checks.yml
@@ -1,12 +1,13 @@
check-patch:
stage: build
- image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
- needs:
- job: amd64-centos8-container
+ image: python:3.10-alpine
+ needs: []
script:
- .gitlab-ci.d/check-patch.py
variables:
GIT_DEPTH: 1000
+ before_script:
+ - apk -U add git perl
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project"'
when: never
@@ -15,12 +16,13 @@ check-patch:
check-dco:
stage: build
- image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
- needs:
- job: amd64-centos8-container
+ image: python:3.10-alpine
+ needs: []
script: .gitlab-ci.d/check-dco.py
variables:
GIT_DEPTH: 1000
+ before_script:
+ - apk -U add git
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
when: never
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs
2022-05-16 8:23 [PATCH v2] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs Thomas Huth
@ 2022-05-16 8:26 ` Daniel P. Berrangé
2022-05-17 23:36 ` John Snow
2022-05-27 13:54 ` Alex Bennée
1 sibling, 1 reply; 5+ messages in thread
From: Daniel P. Berrangé @ 2022-05-16 8:26 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, John Snow, Alex Bennée,
Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Beraldo Leal
On Mon, May 16, 2022 at 10:23:10AM +0200, Thomas Huth wrote:
> The 'check-patch' and 'check-dco' jobs only need Python and git for
> checking the patches, so it's not really necessary to use a container
> here that has all the other build dependencies installed. By using a
> lightweight Alpine container, we can improve the runtime here quite a
> bit, cutting it down from ca. 1:30 minutes to ca. 45 seconds.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: Use python:alpine for even quicker execution
>
> .gitlab-ci.d/static_checks.yml | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs
2022-05-16 8:26 ` Daniel P. Berrangé
@ 2022-05-17 23:36 ` John Snow
0 siblings, 0 replies; 5+ messages in thread
From: John Snow @ 2022-05-17 23:36 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: Thomas Huth, qemu-devel, Alex Bennée,
Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Beraldo Leal
On Mon, May 16, 2022 at 4:26 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Mon, May 16, 2022 at 10:23:10AM +0200, Thomas Huth wrote:
> > The 'check-patch' and 'check-dco' jobs only need Python and git for
> > checking the patches, so it's not really necessary to use a container
> > here that has all the other build dependencies installed. By using a
> > lightweight Alpine container, we can improve the runtime here quite a
> > bit, cutting it down from ca. 1:30 minutes to ca. 45 seconds.
> >
> > Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > v2: Use python:alpine for even quicker execution
> >
> > .gitlab-ci.d/static_checks.yml | 14 ++++++++------
> > 1 file changed, 8 insertions(+), 6 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
Looks good.
Sorry for fooling you with my python container -- I am using it to
ensure a very wide spectrum of version compatibility.
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs
2022-05-16 8:23 [PATCH v2] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs Thomas Huth
2022-05-16 8:26 ` Daniel P. Berrangé
@ 2022-05-27 13:54 ` Alex Bennée
2022-05-27 14:32 ` Alex Bennée
1 sibling, 1 reply; 5+ messages in thread
From: Alex Bennée @ 2022-05-27 13:54 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, John Snow, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Beraldo Leal,
Daniel P . Berrangé
Thomas Huth <thuth@redhat.com> writes:
> The 'check-patch' and 'check-dco' jobs only need Python and git for
> checking the patches, so it's not really necessary to use a container
> here that has all the other build dependencies installed. By using a
> lightweight Alpine container, we can improve the runtime here quite a
> bit, cutting it down from ca. 1:30 minutes to ca. 45 seconds.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Queued to testing/next, thanks.
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs
2022-05-27 13:54 ` Alex Bennée
@ 2022-05-27 14:32 ` Alex Bennée
0 siblings, 0 replies; 5+ messages in thread
From: Alex Bennée @ 2022-05-27 14:32 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, John Snow, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Beraldo Leal,
Daniel P . Berrangé
Alex Bennée <alex.bennee@linaro.org> writes:
> Thomas Huth <thuth@redhat.com> writes:
>
>> The 'check-patch' and 'check-dco' jobs only need Python and git for
>> checking the patches, so it's not really necessary to use a container
>> here that has all the other build dependencies installed. By using a
>> lightweight Alpine container, we can improve the runtime here quite a
>> bit, cutting it down from ca. 1:30 minutes to ca. 45 seconds.
>>
>> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Queued to testing/next, thanks.
And it didn't apply because it was already merged - sorry about that ;-)
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-27 14:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 8:23 [PATCH v2] gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs Thomas Huth
2022-05-16 8:26 ` Daniel P. Berrangé
2022-05-17 23:36 ` John Snow
2022-05-27 13:54 ` Alex Bennée
2022-05-27 14:32 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.