All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: clearfog-gt-8k: add wlan_disable signal hog
@ 2019-02-26  6:46 ` Baruch Siach
  0 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2019-02-26  6:46 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth
  Cc: Mark Rutland, devicetree, Baruch Siach, Thomas Schreiber,
	Rob Herring, linux-arm-kernel

From: Thomas Schreiber <tschreibe@gmail.com>

There is currently no DT binding for GPIO rfkill signals. To make
mini-PCIe attached WiFi devices work, use gpio-hog to hold the
wlan_disable signal de-asserted.

Signed-off-by: Thomas Schreiber <tschreibe@gmail.com>
[baruch: add pinctrl node; rename tag]
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 .../boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
index 2468762283a5..9143aa13ceb1 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
@@ -226,6 +226,11 @@
 		marvell,function = "gpio";
 	};
 
+	cp0_wlan_disable_pins: wlan-disable-pins {
+		marvell,pins = "mpp51";
+		marvell,function = "gpio";
+	};
+
 	cp0_sdhci_pins: sdhci-pins {
 		marvell,pins = "mpp55", "mpp56", "mpp57", "mpp58", "mpp59",
 			       "mpp60", "mpp61";
@@ -235,7 +240,7 @@
 
 &cp0_pcie0 {
 	pinctrl-names = "default";
-	pinctrl-0 = <&cp0_pci0_reset_pins>;
+	pinctrl-0 = <&cp0_pci0_reset_pins &cp0_wlan_disable_pins>;
 	reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
@@ -253,6 +258,12 @@
 		output-low;
 	};
 
+	wlan_disable {
+		gpio-hog;
+		gpios = <19 GPIO_ACTIVE_LOW>;
+		output-low;
+	};
+
 	lte_disable {
 		gpio-hog;
 		gpios = <21 GPIO_ACTIVE_LOW>;
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: clearfog-gt-8k: add wlan_disable signal hog
@ 2019-02-26  6:46 ` Baruch Siach
  0 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2019-02-26  6:46 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth
  Cc: Mark Rutland, devicetree, Baruch Siach, Thomas Schreiber,
	Rob Herring, linux-arm-kernel

From: Thomas Schreiber <tschreibe@gmail.com>

There is currently no DT binding for GPIO rfkill signals. To make
mini-PCIe attached WiFi devices work, use gpio-hog to hold the
wlan_disable signal de-asserted.

Signed-off-by: Thomas Schreiber <tschreibe@gmail.com>
[baruch: add pinctrl node; rename tag]
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 .../boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
index 2468762283a5..9143aa13ceb1 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
@@ -226,6 +226,11 @@
 		marvell,function = "gpio";
 	};
 
+	cp0_wlan_disable_pins: wlan-disable-pins {
+		marvell,pins = "mpp51";
+		marvell,function = "gpio";
+	};
+
 	cp0_sdhci_pins: sdhci-pins {
 		marvell,pins = "mpp55", "mpp56", "mpp57", "mpp58", "mpp59",
 			       "mpp60", "mpp61";
@@ -235,7 +240,7 @@
 
 &cp0_pcie0 {
 	pinctrl-names = "default";
-	pinctrl-0 = <&cp0_pci0_reset_pins>;
+	pinctrl-0 = <&cp0_pci0_reset_pins &cp0_wlan_disable_pins>;
 	reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
@@ -253,6 +258,12 @@
 		output-low;
 	};
 
+	wlan_disable {
+		gpio-hog;
+		gpios = <19 GPIO_ACTIVE_LOW>;
+		output-low;
+	};
+
 	lte_disable {
 		gpio-hog;
 		gpios = <21 GPIO_ACTIVE_LOW>;
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: clearfog-gt-8k: add wlan_disable signal hog
  2019-02-26  6:46 ` Baruch Siach
@ 2019-04-21 17:25   ` Gregory CLEMENT
  -1 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2019-04-21 17:25 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth
  Cc: Mark Rutland, devicetree, Baruch Siach, Thomas Schreiber,
	Rob Herring, linux-arm-kernel

Hi Baruch,

> From: Thomas Schreiber <tschreibe@gmail.com>
>
> There is currently no DT binding for GPIO rfkill signals. To make
> mini-PCIe attached WiFi devices work, use gpio-hog to hold the
> wlan_disable signal de-asserted.
>
> Signed-off-by: Thomas Schreiber <tschreibe@gmail.com>
> [baruch: add pinctrl node; rename tag]
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Applied on mvebu/dt64

Thanks,

Gregory

> ---
>  .../boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> index 2468762283a5..9143aa13ceb1 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> @@ -226,6 +226,11 @@
>  		marvell,function = "gpio";
>  	};
>  
> +	cp0_wlan_disable_pins: wlan-disable-pins {
> +		marvell,pins = "mpp51";
> +		marvell,function = "gpio";
> +	};
> +
>  	cp0_sdhci_pins: sdhci-pins {
>  		marvell,pins = "mpp55", "mpp56", "mpp57", "mpp58", "mpp59",
>  			       "mpp60", "mpp61";
> @@ -235,7 +240,7 @@
>  
>  &cp0_pcie0 {
>  	pinctrl-names = "default";
> -	pinctrl-0 = <&cp0_pci0_reset_pins>;
> +	pinctrl-0 = <&cp0_pci0_reset_pins &cp0_wlan_disable_pins>;
>  	reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
>  	status = "okay";
>  };
> @@ -253,6 +258,12 @@
>  		output-low;
>  	};
>  
> +	wlan_disable {
> +		gpio-hog;
> +		gpios = <19 GPIO_ACTIVE_LOW>;
> +		output-low;
> +	};
> +
>  	lte_disable {
>  		gpio-hog;
>  		gpios = <21 GPIO_ACTIVE_LOW>;
> -- 
> 2.20.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: clearfog-gt-8k: add wlan_disable signal hog
@ 2019-04-21 17:25   ` Gregory CLEMENT
  0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2019-04-21 17:25 UTC (permalink / raw)
  To: Baruch Siach, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth
  Cc: Mark Rutland, devicetree, Baruch Siach, Thomas Schreiber,
	Rob Herring, linux-arm-kernel

Hi Baruch,

> From: Thomas Schreiber <tschreibe@gmail.com>
>
> There is currently no DT binding for GPIO rfkill signals. To make
> mini-PCIe attached WiFi devices work, use gpio-hog to hold the
> wlan_disable signal de-asserted.
>
> Signed-off-by: Thomas Schreiber <tschreibe@gmail.com>
> [baruch: add pinctrl node; rename tag]
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Applied on mvebu/dt64

Thanks,

Gregory

> ---
>  .../boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> index 2468762283a5..9143aa13ceb1 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> @@ -226,6 +226,11 @@
>  		marvell,function = "gpio";
>  	};
>  
> +	cp0_wlan_disable_pins: wlan-disable-pins {
> +		marvell,pins = "mpp51";
> +		marvell,function = "gpio";
> +	};
> +
>  	cp0_sdhci_pins: sdhci-pins {
>  		marvell,pins = "mpp55", "mpp56", "mpp57", "mpp58", "mpp59",
>  			       "mpp60", "mpp61";
> @@ -235,7 +240,7 @@
>  
>  &cp0_pcie0 {
>  	pinctrl-names = "default";
> -	pinctrl-0 = <&cp0_pci0_reset_pins>;
> +	pinctrl-0 = <&cp0_pci0_reset_pins &cp0_wlan_disable_pins>;
>  	reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
>  	status = "okay";
>  };
> @@ -253,6 +258,12 @@
>  		output-low;
>  	};
>  
> +	wlan_disable {
> +		gpio-hog;
> +		gpios = <19 GPIO_ACTIVE_LOW>;
> +		output-low;
> +	};
> +
>  	lte_disable {
>  		gpio-hog;
>  		gpios = <21 GPIO_ACTIVE_LOW>;
> -- 
> 2.20.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-21 17:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26  6:46 [PATCH] arm64: dts: clearfog-gt-8k: add wlan_disable signal hog Baruch Siach
2019-02-26  6:46 ` Baruch Siach
2019-04-21 17:25 ` Gregory CLEMENT
2019-04-21 17:25   ` Gregory CLEMENT

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.