All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/gerbera: fix static build with curl and libidn2
@ 2019-03-08 21:52 Fabrice Fontaine
  2019-03-09 14:09 ` Thomas Petazzoni
  2019-03-25 21:21 ` Peter Korsgaard
  0 siblings, 2 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2019-03-08 21:52 UTC (permalink / raw)
  To: buildroot

Fixes:
 - http://autobuild.buildroot.org/results/be5893b507d22a23951efeea20c18642742cef5a

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...ix-static-build-with-curl-and-libidn.patch | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 package/gerbera/0001-CMakeLists.txt-fix-static-build-with-curl-and-libidn.patch

diff --git a/package/gerbera/0001-CMakeLists.txt-fix-static-build-with-curl-and-libidn.patch b/package/gerbera/0001-CMakeLists.txt-fix-static-build-with-curl-and-libidn.patch
new file mode 100644
index 0000000000..94f742c3f8
--- /dev/null
+++ b/package/gerbera/0001-CMakeLists.txt-fix-static-build-with-curl-and-libidn.patch
@@ -0,0 +1,41 @@
+From de0e7fe3b56cff79c11aedc89448814fab8d1877 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Fri, 8 Mar 2019 19:11:11 +0100
+Subject: [PATCH] MakeLists.txt: fix static build with curl and libidn2
+
+curl can be statically linked with libidn2, in this case, build fails:
+/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/m68k-buildroot-linux-uclibc/sysroot/usr/lib/libcurl.a(libcurl_la-url.o): In function `free_idnconverted_hostname.isra.1':
+url.c:(.text+0xf4): undefined reference to `idn2_free'
+
+To fix this issue, add a call to pkg_check_modules to retrieve any
+needed dependencies
+
+Fixes:
+ - http://autobuild.buildroot.org/results/be5893b507d22a23951efeea20c18642742cef5a
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: https://github.com/gerbera/gerbera/pull/429]
+---
+ CMakeLists.txt | 6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index d0eed230..e6b62c96 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -443,7 +443,11 @@ if(WITH_MYSQL)
+ endif()
+ 
+ if(WITH_CURL)
+-    find_package (CURL REQUIRED)
++    find_package(PkgConfig QUIET)
++    pkg_check_modules (CURL QUIET libcurl)
++    if (NOT CURL_FOUND)
++        find_package (CURL REQUIRED)
++    endif()
+     if (CURL_FOUND)
+         include_directories(${CURL_INCLUDE_DIRS})
+         target_link_libraries (gerbera ${CURL_LIBRARIES})
+-- 
+2.20.1
+
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/gerbera: fix static build with curl and libidn2
  2019-03-08 21:52 [Buildroot] [PATCH 1/1] package/gerbera: fix static build with curl and libidn2 Fabrice Fontaine
@ 2019-03-09 14:09 ` Thomas Petazzoni
  2019-03-09 15:04   ` Fabrice Fontaine
  2019-03-25 21:21 ` Peter Korsgaard
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-03-09 14:09 UTC (permalink / raw)
  To: buildroot

On Fri,  8 Mar 2019 22:52:00 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fixes:
>  - http://autobuild.buildroot.org/results/be5893b507d22a23951efeea20c18642742cef5a
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

As upstream replied in the pull request, the CMake FindCURL module
already uses pkg-config if available. Could you investigate what this
doesn't work as expected ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/gerbera: fix static build with curl and libidn2
  2019-03-09 14:09 ` Thomas Petazzoni
@ 2019-03-09 15:04   ` Fabrice Fontaine
  2019-03-15 10:14     ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2019-03-09 15:04 UTC (permalink / raw)
  To: buildroot

Dear Thomas,
Le sam. 9 mars 2019 ? 15:09, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> On Fri,  8 Mar 2019 22:52:00 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Fixes:
> >  - http://autobuild.buildroot.org/results/be5893b507d22a23951efeea20c18642742cef5a
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> As upstream replied in the pull request, the CMake FindCURL module
> already uses pkg-config if available. Could you investigate what this
> doesn't work as expected ?
Cmake does not use pkgconfig in FindCurl in any "official" versions
(including 3.13.4), they have added a call to pkgconfig only in
December 2018 with
https://github.com/Kitware/CMake/commit/fc5afbe97094d741b853b045d51351f3a370e87e#diff-62c4a3bc6680cd4945de9749af697a2a
I'll be a part of the upcoming 3.14.0.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/gerbera: fix static build with curl and libidn2
  2019-03-09 15:04   ` Fabrice Fontaine
@ 2019-03-15 10:14     ` Thomas Petazzoni
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2019-03-15 10:14 UTC (permalink / raw)
  To: buildroot

Hello,

On Sat, 9 Mar 2019 16:04:50 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> > As upstream replied in the pull request, the CMake FindCURL module
> > already uses pkg-config if available. Could you investigate what this
> > doesn't work as expected ?  
> Cmake does not use pkgconfig in FindCurl in any "official" versions
> (including 3.13.4), they have added a call to pkgconfig only in
> December 2018 with
> https://github.com/Kitware/CMake/commit/fc5afbe97094d741b853b045d51351f3a370e87e#diff-62c4a3bc6680cd4945de9749af697a2a
> I'll be a part of the upcoming 3.14.0.

Thanks for the additional explication!

I've applied the patch to master. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/gerbera: fix static build with curl and libidn2
  2019-03-08 21:52 [Buildroot] [PATCH 1/1] package/gerbera: fix static build with curl and libidn2 Fabrice Fontaine
  2019-03-09 14:09 ` Thomas Petazzoni
@ 2019-03-25 21:21 ` Peter Korsgaard
  1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2019-03-25 21:21 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fixes:
 >  - http://autobuild.buildroot.org/results/be5893b507d22a23951efeea20c18642742cef5a

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-03-25 21:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-08 21:52 [Buildroot] [PATCH 1/1] package/gerbera: fix static build with curl and libidn2 Fabrice Fontaine
2019-03-09 14:09 ` Thomas Petazzoni
2019-03-09 15:04   ` Fabrice Fontaine
2019-03-15 10:14     ` Thomas Petazzoni
2019-03-25 21:21 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.