All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <shuah@kernel.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Prakash Sangappa <prakash.sangappa@oracle.com>
Subject: Re: [PATCH 2/3] userfaultfd: selftest: Skip test if a feature isn't supported
Date: Mon, 30 Jul 2018 20:54:53 -0300	[thread overview]
Message-ID: <871sbkb7oy.fsf@morokweng.localdomain> (raw)
In-Reply-To: <20180725141148.GD25188@rapoport-lnx>


Mike Rapoport <rppt@linux.vnet.ibm.com> writes:

> Hi,
>
> On Tue, Jul 24, 2018 at 11:42:08PM -0300, Thiago Jung Bauermann wrote:
>> If userfaultfd runs on a system that doesn't support some feature it is
>> trying to test, it currently ends with error code 1 which indicates
>> test failure:
>> 
>>   # ./userfaultfd anon 10 10
>>   nr_pages: 160, nr_pages_per_cpu: 80
>>   bounces: 9, mode: rnd poll, userfaults: 7 59
>>   bounces: 8, mode: poll, userfaults: 0 0
>>   bounces: 7, mode: rnd racing ver, userfaults: 45 2
>>   bounces: 6, mode: racing ver, userfaults: 3 1
>>   bounces: 5, mode: rnd ver, userfaults: 55 32
>>   bounces: 4, mode: ver, userfaults: 69 0
>>   bounces: 3, mode: rnd racing, userfaults: 1 1
>>   bounces: 2, mode: racing, userfaults: 65 0
>>   bounces: 1, mode: rnd, userfaults: 44 1
>>   bounces: 0, mode:, userfaults: 3 2
>>   testing UFFDIO_ZEROPAGE: done.
>>   testing signal delivery: UFFDIO_API
>>   # echo $?
>>   1
>> 
>> Make the testcase return KSFT_SKIP instead, which is more accurate since it
>> is not a real test failure:
>> 
>>   # ./userfaultfd anon 10 10
>>   nr_pages: 160, nr_pages_per_cpu: 80
>>   bounces: 9, mode: rnd poll, userfaults: 3 0
>>   bounces: 8, mode: poll, userfaults: 6 1
>>   bounces: 7, mode: rnd racing ver, userfaults: 3 1
>>   bounces: 6, mode: racing ver, userfaults: 2 1
>>   bounces: 5, mode: rnd ver, userfaults: 2 1
>>   bounces: 4, mode: ver, userfaults: 3 47
>>   bounces: 3, mode: rnd racing, userfaults: 38 0
>>   bounces: 2, mode: racing, userfaults: 4 61
>>   bounces: 1, mode: rnd, userfaults: 16 6
>>   bounces: 0, mode:, userfaults: 55 25
>>   testing UFFDIO_ZEROPAGE: done.
>>   testing signal delivery: UFFDIO_API: Invalid argument
>>   # echo $?
>>   4
>> 
>> While at it, also improve the error message of the ioctl(UFFDIO_API) call.
>
> Can you please also make the test return KSFT_SKIP if userfaultfd(2) fails
> with ENOSYS?

Sure. v2 will have a separate patch implementing your suggestion.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center


WARNING: multiple messages have this Message-ID (diff)
From: bauerman at linux.ibm.com (Thiago Jung Bauermann)
Subject: [PATCH 2/3] userfaultfd: selftest: Skip test if a feature isn't supported
Date: Mon, 30 Jul 2018 20:54:53 -0300	[thread overview]
Message-ID: <871sbkb7oy.fsf@morokweng.localdomain> (raw)
In-Reply-To: <20180725141148.GD25188@rapoport-lnx>


Mike Rapoport <rppt at linux.vnet.ibm.com> writes:

> Hi,
>
> On Tue, Jul 24, 2018 at 11:42:08PM -0300, Thiago Jung Bauermann wrote:
>> If userfaultfd runs on a system that doesn't support some feature it is
>> trying to test, it currently ends with error code 1 which indicates
>> test failure:
>> 
>>   # ./userfaultfd anon 10 10
>>   nr_pages: 160, nr_pages_per_cpu: 80
>>   bounces: 9, mode: rnd poll, userfaults: 7 59
>>   bounces: 8, mode: poll, userfaults: 0 0
>>   bounces: 7, mode: rnd racing ver, userfaults: 45 2
>>   bounces: 6, mode: racing ver, userfaults: 3 1
>>   bounces: 5, mode: rnd ver, userfaults: 55 32
>>   bounces: 4, mode: ver, userfaults: 69 0
>>   bounces: 3, mode: rnd racing, userfaults: 1 1
>>   bounces: 2, mode: racing, userfaults: 65 0
>>   bounces: 1, mode: rnd, userfaults: 44 1
>>   bounces: 0, mode:, userfaults: 3 2
>>   testing UFFDIO_ZEROPAGE: done.
>>   testing signal delivery: UFFDIO_API
>>   # echo $?
>>   1
>> 
>> Make the testcase return KSFT_SKIP instead, which is more accurate since it
>> is not a real test failure:
>> 
>>   # ./userfaultfd anon 10 10
>>   nr_pages: 160, nr_pages_per_cpu: 80
>>   bounces: 9, mode: rnd poll, userfaults: 3 0
>>   bounces: 8, mode: poll, userfaults: 6 1
>>   bounces: 7, mode: rnd racing ver, userfaults: 3 1
>>   bounces: 6, mode: racing ver, userfaults: 2 1
>>   bounces: 5, mode: rnd ver, userfaults: 2 1
>>   bounces: 4, mode: ver, userfaults: 3 47
>>   bounces: 3, mode: rnd racing, userfaults: 38 0
>>   bounces: 2, mode: racing, userfaults: 4 61
>>   bounces: 1, mode: rnd, userfaults: 16 6
>>   bounces: 0, mode:, userfaults: 55 25
>>   testing UFFDIO_ZEROPAGE: done.
>>   testing signal delivery: UFFDIO_API: Invalid argument
>>   # echo $?
>>   4
>> 
>> While at it, also improve the error message of the ioctl(UFFDIO_API) call.
>
> Can you please also make the test return KSFT_SKIP if userfaultfd(2) fails
> with ENOSYS?

Sure. v2 will have a separate patch implementing your suggestion.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: bauerman@linux.ibm.com (Thiago Jung Bauermann)
Subject: [PATCH 2/3] userfaultfd: selftest: Skip test if a feature isn't supported
Date: Mon, 30 Jul 2018 20:54:53 -0300	[thread overview]
Message-ID: <871sbkb7oy.fsf@morokweng.localdomain> (raw)
Message-ID: <20180730235453.3BHmwp8HvJF2lO7DRS-S6_kknem1oXM6CYd52kE0zXQ@z> (raw)
In-Reply-To: <20180725141148.GD25188@rapoport-lnx>


Mike Rapoport <rppt at linux.vnet.ibm.com> writes:

> Hi,
>
> On Tue, Jul 24, 2018@11:42:08PM -0300, Thiago Jung Bauermann wrote:
>> If userfaultfd runs on a system that doesn't support some feature it is
>> trying to test, it currently ends with error code 1 which indicates
>> test failure:
>> 
>>   # ./userfaultfd anon 10 10
>>   nr_pages: 160, nr_pages_per_cpu: 80
>>   bounces: 9, mode: rnd poll, userfaults: 7 59
>>   bounces: 8, mode: poll, userfaults: 0 0
>>   bounces: 7, mode: rnd racing ver, userfaults: 45 2
>>   bounces: 6, mode: racing ver, userfaults: 3 1
>>   bounces: 5, mode: rnd ver, userfaults: 55 32
>>   bounces: 4, mode: ver, userfaults: 69 0
>>   bounces: 3, mode: rnd racing, userfaults: 1 1
>>   bounces: 2, mode: racing, userfaults: 65 0
>>   bounces: 1, mode: rnd, userfaults: 44 1
>>   bounces: 0, mode:, userfaults: 3 2
>>   testing UFFDIO_ZEROPAGE: done.
>>   testing signal delivery: UFFDIO_API
>>   # echo $?
>>   1
>> 
>> Make the testcase return KSFT_SKIP instead, which is more accurate since it
>> is not a real test failure:
>> 
>>   # ./userfaultfd anon 10 10
>>   nr_pages: 160, nr_pages_per_cpu: 80
>>   bounces: 9, mode: rnd poll, userfaults: 3 0
>>   bounces: 8, mode: poll, userfaults: 6 1
>>   bounces: 7, mode: rnd racing ver, userfaults: 3 1
>>   bounces: 6, mode: racing ver, userfaults: 2 1
>>   bounces: 5, mode: rnd ver, userfaults: 2 1
>>   bounces: 4, mode: ver, userfaults: 3 47
>>   bounces: 3, mode: rnd racing, userfaults: 38 0
>>   bounces: 2, mode: racing, userfaults: 4 61
>>   bounces: 1, mode: rnd, userfaults: 16 6
>>   bounces: 0, mode:, userfaults: 55 25
>>   testing UFFDIO_ZEROPAGE: done.
>>   testing signal delivery: UFFDIO_API: Invalid argument
>>   # echo $?
>>   4
>> 
>> While at it, also improve the error message of the ioctl(UFFDIO_API) call.
>
> Can you please also make the test return KSFT_SKIP if userfaultfd(2) fails
> with ENOSYS?

Sure. v2 will have a separate patch implementing your suggestion.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-07-30 23:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25  2:42 [PATCH 0/3] userfaultfd: selftest: Improve behavior with older kernels Thiago Jung Bauermann
2018-07-25  2:42 ` Thiago Jung Bauermann
2018-07-25  2:42 ` bauerman
2018-07-25  2:42 ` [PATCH 1/3] userfaultfd: selftest: Fix checking of userfaultfd_open() result Thiago Jung Bauermann
2018-07-25  2:42   ` Thiago Jung Bauermann
2018-07-25  2:42   ` bauerman
2018-07-25 13:59   ` Mike Rapoport
2018-07-25 13:59     ` Mike Rapoport
2018-07-25 13:59     ` rppt
2018-07-30 23:53     ` Thiago Jung Bauermann
2018-07-30 23:53       ` Thiago Jung Bauermann
2018-07-30 23:53       ` bauerman
2018-07-25  2:42 ` [PATCH 2/3] userfaultfd: selftest: Skip test if a feature isn't supported Thiago Jung Bauermann
2018-07-25  2:42   ` Thiago Jung Bauermann
2018-07-25  2:42   ` bauerman
2018-07-25 14:11   ` Mike Rapoport
2018-07-25 14:11     ` Mike Rapoport
2018-07-25 14:11     ` rppt
2018-07-30 23:54     ` Thiago Jung Bauermann [this message]
2018-07-30 23:54       ` Thiago Jung Bauermann
2018-07-30 23:54       ` bauerman
2018-07-25  2:42 ` [PATCH 3/3] userfaultfd: selftest: Report XFAIL if shmem doesn't support zeropage Thiago Jung Bauermann
2018-07-25  2:42   ` Thiago Jung Bauermann
2018-07-25  2:42   ` bauerman
2018-07-25 14:18   ` Mike Rapoport
2018-07-25 14:18     ` Mike Rapoport
2018-07-25 14:18     ` rppt
2018-07-31  0:01     ` Thiago Jung Bauermann
2018-07-31  0:01       ` Thiago Jung Bauermann
2018-07-31  0:01       ` bauerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871sbkb7oy.fsf@morokweng.localdomain \
    --to=bauerman@linux.ibm.com \
    --cc=aarcange@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=prakash.sangappa@oracle.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.