All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org,
	mark.rutland@arm.co, stefan.wahren@i2se.com,
	alsa-devel@alsa-project.org,
	linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Michael Zoran <mzoran@crowfest.net>
Subject: Re: [PATCH 2/4] sound: bcm2835-analog-audio: Add driver for bcm2835(Raspberry PI) headphone jack.
Date: Wed, 15 Mar 2017 17:01:10 -0700	[thread overview]
Message-ID: <871sty1455.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20170312063820.19313-2-mzoran@crowfest.net>


[-- Attachment #1.1: Type: text/plain, Size: 771 bytes --]

Michael Zoran <mzoran@crowfest.net> writes:

> Add driver for the bcm2835 analog/headphone jack which
> uses the PWM hardware to generate audio.
>
> Signed-off-by: Michael Zoran <mzoran@crowfest.net>

ALSA folks: is a driver like this acceptable?  In particular, I'm
wondering how you feel about the in-kernel munging of the audio buffers
to something appropriate for the PWM hardware, before we get into review
of driver details.

This driver isn't quite a replacement for the closed source driver in
the firmware (couple of notes: firmware seems to have some dithering of
the audio values in the sigma delta modulation process, and a priority
bump on the DMA because the PWM's fifo is tiny), but I'm definitely
interested in us having something like it in open source.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2017-03-16  0:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-12  6:38 [PATCH 1/4] dt-bindings: Document the dmas and dma-names properties for bcm2835-analog-audio Michael Zoran
     [not found] ` <20170312063820.19313-1-mzoran-O+n0w2l5AFbk1uMJSBkQmQ@public.gmane.org>
2017-03-12  6:38   ` [PATCH 2/4] sound: bcm2835-analog-audio: Add driver for bcm2835(Raspberry PI) headphone jack Michael Zoran
2017-03-16  0:01     ` Eric Anholt [this message]
2017-03-12  6:38   ` [PATCH 3/4] sound: arm: Add build system for bcm2835-analog-audio driver Michael Zoran
     [not found]     ` <20170312063820.19313-3-mzoran-O+n0w2l5AFbk1uMJSBkQmQ@public.gmane.org>
2017-03-14  7:15       ` [alsa-devel] " kbuild test robot
     [not found]         ` <201703141503.gyuLu0Kr%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-03-14  8:58           ` Michael Zoran
     [not found]             ` <1489481899.656.5.camel-O+n0w2l5AFbk1uMJSBkQmQ@public.gmane.org>
2017-03-14  9:13               ` Stefan Wahren
     [not found]                 ` <5a437138-bf9c-1e48-9fa6-82fac9b6e54c-eS4NqCHxEME@public.gmane.org>
2017-03-14  9:53                   ` Michael Zoran
2017-03-12  6:38   ` [PATCH 4/4] dts: bcm283x.dtsi: Add analog audio/headphone jack for bcm2835 Michael Zoran
     [not found]     ` <20170312063820.19313-4-mzoran-O+n0w2l5AFbk1uMJSBkQmQ@public.gmane.org>
2017-03-14  8:05       ` Stefan Wahren
     [not found]         ` <a5ae562f-6843-f137-6470-36c53cfd1799-eS4NqCHxEME@public.gmane.org>
2017-03-14  8:47           ` Michael Zoran
     [not found]             ` <1489481279.656.1.camel-O+n0w2l5AFbk1uMJSBkQmQ@public.gmane.org>
2017-03-14 10:07               ` Stefan Wahren
2017-03-14 10:18                 ` Michael Zoran
2017-03-20 16:50 ` [PATCH 1/4] dt-bindings: Document the dmas and dma-names properties for bcm2835-analog-audio Rob Herring
2017-03-20 17:07   ` [alsa-devel] " Michael Zoran
     [not found]     ` <1490029654.11105.7.camel-O+n0w2l5AFbk1uMJSBkQmQ@public.gmane.org>
2017-03-21 12:53       ` Rob Herring
2017-03-21 13:30         ` Michael Zoran
2017-03-21 17:59           ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871sty1455.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.co \
    --cc=mzoran@crowfest.net \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=stefan.wahren@i2se.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.