All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] strace: Disable for MIPS when using a uClibc toolchain
@ 2014-09-12 10:40 Vicente Olivert Riera
  2014-09-13 20:15 ` Peter Korsgaard
  2014-09-14 17:05 ` Waldemar Brodkorb
  0 siblings, 2 replies; 3+ messages in thread
From: Vicente Olivert Riera @ 2014-09-12 10:40 UTC (permalink / raw)
  To: buildroot

A change introduced in strace-4.9 makes it incompatible with MIPS
architecture when using a uClibc toolchain. This is the failure:

signal.c: In function 'printsiginfo':
signal.c:453:9: error: 'siginfo_t' has no member named 'si_timerid'
      sip->si_timerid, sip->si_overrun);
	 ^
signal.c:453:26: error: 'siginfo_t' has no member named 'si_overrun'
      sip->si_timerid, sip->si_overrun);

uClibc needs to be patched in order to fix this problem. In the meantime
we disable strace for MIPS when using a uClibc toolchain.

Fixes:

  http://autobuild.buildroot.net/results/91c/91c0413e755c365332bc15d1d69ab3d6160ae78c/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/strace/Config.in |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/package/strace/Config.in b/package/strace/Config.in
index ad8d308..bc521e0 100644
--- a/package/strace/Config.in
+++ b/package/strace/Config.in
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_STRACE
 	bool "strace"
 	depends on !BR2_nios2
+	depends on !((BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) \
+	             && BR2_TOOLCHAIN_USES_UCLIBC)
 	depends on BR2_LARGEFILE
 	help
 	  A useful diagnostic, instructional, and debugging tool.
@@ -11,3 +13,7 @@ config BR2_PACKAGE_STRACE
 
 comment "strace needs a toolchain w/ largefile"
 	depends on !BR2_LARGEFILE
+
+comment "strace is not supported on MIPS using a uClibc toolchain"
+	depends on (BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) && \
+	           BR2_TOOLCHAIN_USES_UCLIBC
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] strace: Disable for MIPS when using a uClibc toolchain
  2014-09-12 10:40 [Buildroot] [PATCH] strace: Disable for MIPS when using a uClibc toolchain Vicente Olivert Riera
@ 2014-09-13 20:15 ` Peter Korsgaard
  2014-09-14 17:05 ` Waldemar Brodkorb
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2014-09-13 20:15 UTC (permalink / raw)
  To: buildroot

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > A change introduced in strace-4.9 makes it incompatible with MIPS
 > architecture when using a uClibc toolchain. This is the failure:

 > signal.c: In function 'printsiginfo':
 > signal.c:453:9: error: 'siginfo_t' has no member named 'si_timerid'
 sip-> si_timerid, sip->si_overrun);
 > 	 ^
 > signal.c:453:26: error: 'siginfo_t' has no member named 'si_overrun'
 sip-> si_timerid, sip->si_overrun);

 > uClibc needs to be patched in order to fix this problem. In the meantime
 > we disable strace for MIPS when using a uClibc toolchain.

 > Fixes:

 >   http://autobuild.buildroot.net/results/91c/91c0413e755c365332bc15d1d69ab3d6160ae78c/

 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] strace: Disable for MIPS when using a uClibc toolchain
  2014-09-12 10:40 [Buildroot] [PATCH] strace: Disable for MIPS when using a uClibc toolchain Vicente Olivert Riera
  2014-09-13 20:15 ` Peter Korsgaard
@ 2014-09-14 17:05 ` Waldemar Brodkorb
  1 sibling, 0 replies; 3+ messages in thread
From: Waldemar Brodkorb @ 2014-09-14 17:05 UTC (permalink / raw)
  To: buildroot

Hi Vicente,
Vicente Olivert Riera wrote,

> A change introduced in strace-4.9 makes it incompatible with MIPS
> architecture when using a uClibc toolchain. This is the failure:
> 
> signal.c: In function 'printsiginfo':
> signal.c:453:9: error: 'siginfo_t' has no member named 'si_timerid'
>       sip->si_timerid, sip->si_overrun);
> 	 ^
> signal.c:453:26: error: 'siginfo_t' has no member named 'si_overrun'
>       sip->si_timerid, sip->si_overrun);
> 
> uClibc needs to be patched in order to fix this problem. In the meantime
> we disable strace for MIPS when using a uClibc toolchain.

Can you sent a patch to uClibc mailing list fixing this issue?
System without strace is had to debug.

best regards
 Waldemar

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-14 17:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-12 10:40 [Buildroot] [PATCH] strace: Disable for MIPS when using a uClibc toolchain Vicente Olivert Riera
2014-09-13 20:15 ` Peter Korsgaard
2014-09-14 17:05 ` Waldemar Brodkorb

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.