Re: [PATCH] sh: fixup section mismatch worning for intc_set_ack_handle()

Re: [PATCH] sh: fixup section mismatch worning for intc_set_ack_handle()

[Paul Mundt]

On Thu, Mar 22, 2012 at 10:36:29PM -0700, Kuninori Morimoto wrote:
> This patch fixup below warning
> 
> WARNING: drivers/built-in.o(.text+0x5d760):
> Section mismatch in reference from the function
> intc_set_ack_handle() to the function .init.text:intc_ack_data()
> The function intc_set_ack_handle()
> references the function __init intc_ack_data().
> This is often because intc_set_ack_handle lacks a __init
> annotation or the annotation of intc_ack_data is wrong.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Hmm, no. This is just papering over the problem. The real issue is that
intc_ack_data() is flagged __init when it shouldn't be. I'll fix it up,
thanks for reporting it.

Re: [PATCH] sh: fixup section mismatch worning for intc_set_ack_handle()

[Kuninori Morimoto]

Hi Paul

> > WARNING: drivers/built-in.o(.text+0x5d760):
> > Section mismatch in reference from the function
> > intc_set_ack_handle() to the function .init.text:intc_ack_data()
> > The function intc_set_ack_handle()
> > references the function __init intc_ack_data().
> > This is often because intc_set_ack_handle lacks a __init
> > annotation or the annotation of intc_ack_data is wrong.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Hmm, no. This is just papering over the problem. The real issue is that
> intc_ack_data() is flagged __init when it shouldn't be. I'll fix it up,
> thanks for reporting it.

OK. thank you.
please add

Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Best regards
---
Kuninori Morimoto