From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 1/5] xen/bitmap: fix bitmap_fill with zero-sized bitmap
Date: Mon, 6 May 2019 16:19:26 +0100 [thread overview]
Message-ID: <87233032-658b-1c91-36eb-a0de3475e2f9@citrix.com> (raw)
In-Reply-To: <e54979f9ce16c254c78e4a48e3e5c0eb223f6dac.1557154206.git-series.marmarek@invisiblethingslab.com>
On 06/05/2019 15:50, Marek Marczykowski-Górecki wrote:
> When bitmap_fill(..., 0) is called, do not try to write anything. Before
> this patch, it tried to write almost LONG_MAX, surely overwriting
> something.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
It looks like all other operations do cope correctly with nbits being 0.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [Xen-devel] [PATCH 1/5] xen/bitmap: fix bitmap_fill with zero-sized bitmap
Date: Mon, 6 May 2019 16:19:26 +0100 [thread overview]
Message-ID: <87233032-658b-1c91-36eb-a0de3475e2f9@citrix.com> (raw)
Message-ID: <20190506151926.zR7h0MFhDFkrehwBXcXHXD-f5dpvbaWkvYYp9BMgtA4@z> (raw)
In-Reply-To: <e54979f9ce16c254c78e4a48e3e5c0eb223f6dac.1557154206.git-series.marmarek@invisiblethingslab.com>
On 06/05/2019 15:50, Marek Marczykowski-Górecki wrote:
> When bitmap_fill(..., 0) is called, do not try to write anything. Before
> this patch, it tried to write almost LONG_MAX, surely overwriting
> something.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
It looks like all other operations do cope correctly with nbits being 0.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-06 15:19 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 14:50 [PATCH 0/5] Fixes for large framebuffer, placed above 4GB Marek Marczykowski-Górecki
2019-05-06 14:50 ` [Xen-devel] " Marek Marczykowski-Górecki
2019-05-06 14:50 ` [PATCH 1/5] xen/bitmap: fix bitmap_fill with zero-sized bitmap Marek Marczykowski-Górecki
2019-05-06 14:50 ` [Xen-devel] " Marek Marczykowski-Górecki
2019-05-06 15:19 ` Andrew Cooper [this message]
2019-05-06 15:19 ` Andrew Cooper
2019-05-07 8:10 ` Jan Beulich
2019-05-07 8:10 ` [Xen-devel] " Jan Beulich
2019-05-07 15:19 ` Marek Marczykowski
2019-05-07 15:19 ` [Xen-devel] " Marek Marczykowski
2019-05-06 14:50 ` [PATCH 2/5] drivers/video: drop unused limits Marek Marczykowski-Górecki
2019-05-06 14:50 ` [Xen-devel] " Marek Marczykowski-Górecki
2019-05-06 15:19 ` Andrew Cooper
2019-05-06 15:19 ` [Xen-devel] " Andrew Cooper
2019-05-07 8:52 ` Jan Beulich
2019-05-07 8:52 ` [Xen-devel] " Jan Beulich
2019-05-06 14:50 ` [PATCH 3/5] drivers/video: Drop framebuffer size constraints Marek Marczykowski-Górecki
2019-05-06 14:50 ` [Xen-devel] " Marek Marczykowski-Górecki
2019-05-06 15:09 ` Olaf Hering
2019-05-06 15:09 ` [Xen-devel] " Olaf Hering
2019-05-06 15:33 ` Andrew Cooper
2019-05-06 15:33 ` [Xen-devel] " Andrew Cooper
2019-05-07 8:55 ` Jan Beulich
2019-05-07 8:55 ` [Xen-devel] " Jan Beulich
2019-05-06 14:50 ` [PATCH 4/5] xen: fix handling framebuffer located above 4GB Marek Marczykowski-Górecki
2019-05-06 14:50 ` [Xen-devel] " Marek Marczykowski-Górecki
2019-05-06 15:15 ` Juergen Gross
2019-05-06 15:15 ` [Xen-devel] " Juergen Gross
2019-05-06 15:32 ` Marek Marczykowski-Górecki
2019-05-06 15:32 ` [Xen-devel] " Marek Marczykowski-Górecki
2019-05-07 5:07 ` Juergen Gross
2019-05-07 5:07 ` [Xen-devel] " Juergen Gross
2019-05-07 9:10 ` Jan Beulich
2019-05-07 9:10 ` [Xen-devel] " Jan Beulich
2019-05-07 15:38 ` Marek Marczykowski
2019-05-07 15:38 ` [Xen-devel] " Marek Marczykowski
2019-05-07 16:12 ` Jan Beulich
2019-05-07 16:12 ` [Xen-devel] " Jan Beulich
2019-05-07 16:43 ` Marek Marczykowski
2019-05-07 16:43 ` [Xen-devel] " Marek Marczykowski
2019-05-08 9:54 ` Jan Beulich
2019-05-08 9:54 ` [Xen-devel] " Jan Beulich
2019-05-08 12:06 ` Marek Marczykowski
2019-05-08 12:06 ` [Xen-devel] " Marek Marczykowski
2019-05-08 12:45 ` Jan Beulich
2019-05-08 12:45 ` [Xen-devel] " Jan Beulich
2019-05-06 15:28 ` Andrew Cooper
2019-05-06 15:28 ` [Xen-devel] " Andrew Cooper
2019-05-07 9:07 ` Jan Beulich
2019-05-07 9:07 ` [Xen-devel] " Jan Beulich
2019-05-09 0:22 ` Marek Marczykowski
2019-05-09 0:22 ` [Xen-devel] " Marek Marczykowski
2019-05-09 8:59 ` Jan Beulich
2019-05-09 8:59 ` [Xen-devel] " Jan Beulich
2019-05-06 14:50 ` [PATCH 5/5] drivers/video: use vlfb_info consistently Marek Marczykowski-Górecki
2019-05-06 14:50 ` [Xen-devel] " Marek Marczykowski-Górecki
2019-05-06 15:33 ` Andrew Cooper
2019-05-06 15:33 ` [Xen-devel] " Andrew Cooper
2019-05-06 15:37 ` [PATCH 0/5] Fixes for large framebuffer, placed above 4GB Andrew Cooper
2019-05-06 15:37 ` [Xen-devel] " Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87233032-658b-1c91-36eb-a0de3475e2f9@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=marmarek@invisiblethingslab.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.