All of lore.kernel.org
 help / color / mirror / Atom feed
From: "fugang.duan@freescale.com" <fugang.duan@freescale.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Grant Likely" <grant.likely@linaro.org>,
	"Henrik Rydberg" <rydberg@euromail.se>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Jingoo Han" <jg1.han@samsung.com>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Rob Landley" <rob@landley.net>,
	"Sachin Kamat" <sachin.kamat@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Simon Budig" <simon.budig@kernelconcepts.de>
Subject: RE: [PATCHv4 4/5] Input: edt-ft5x06: Ignore touchdown events
Date: Thu, 20 Mar 2014 05:22:01 +0000	[thread overview]
Message-ID: <872e4d7ea1ed455592b0bf828d69fb26@BLUPR03MB373.namprd03.prod.outlook.com> (raw)
In-Reply-To: <1395234563-11034-5-git-send-email-LW@KARO-electronics.de>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1554 bytes --]

From: Lothar Waßmann <LW@KARO-electronics.de>
Data: Wednesday, March 19, 2014 9:09 PM

>To: Dmitry Torokhov; Duan Fugang-B38611; Grant Likely; Henrik Rydberg; Ian
>Campbell; Jingoo Han; Kumar Gala; Mark Rutland; Pawel Moll; Rob Herring; Rob
>Landley; Sachin Kamat; devicetree@vger.kernel.org; linux-doc@vger.kernel.org;
>linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; Simon Budig; Lothar
>Waßmann
>Subject: [PATCHv4 4/5] Input: edt-ft5x06: Ignore touchdown events
>
>The chip may report invalid coordinates on touchdown events, so don't report
>the initial touchdown event.
>
>Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
>---
> drivers/input/touchscreen/edt-ft5x06.c |    4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/input/touchscreen/edt-ft5x06.c
>b/drivers/input/touchscreen/edt-ft5x06.c
>index 27dccfc..af736e4 100644
>--- a/drivers/input/touchscreen/edt-ft5x06.c
>+++ b/drivers/input/touchscreen/edt-ft5x06.c
>@@ -175,6 +175,10 @@ static irqreturn_t edt_ft5x06_ts_isr(int irq, void *dev_id)
> 		if (type == TOUCH_EVENT_RESERVED)
> 			continue;
>
>+		/* ignore TOUCH_DOWN events, might have bogus coordinates */
>+		if (type == TOUCH_EVENT_DOWN)
>+			continue;
>+
> 		x = ((buf[0] << 8) | buf[1]) & 0x0fff;
> 		y = ((buf[2] << 8) | buf[3]) & 0x0fff;
> 		id = (buf[2] >> 4) & 0x0f;
>--
>1.7.10.4
>
>

Acked-by: Fugang Duan <B38611@freescale.com>
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

WARNING: multiple messages have this Message-ID (diff)
From: "fugang.duan@freescale.com" <fugang.duan@freescale.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Grant Likely" <grant.likely@linaro.org>,
	"Henrik Rydberg" <rydberg@euromail.se>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Jingoo Han" <jg1.han@samsung.com>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Rob Landley" <rob@landley.net>,
	"Sachin Kamat" <sachin.kamat@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Simon Budig" <simon.budig@kernelconcepts.de>
Subject: RE: [PATCHv4 4/5] Input: edt-ft5x06: Ignore touchdown events
Date: Thu, 20 Mar 2014 05:22:01 +0000	[thread overview]
Message-ID: <872e4d7ea1ed455592b0bf828d69fb26@BLUPR03MB373.namprd03.prod.outlook.com> (raw)
In-Reply-To: <1395234563-11034-5-git-send-email-LW@KARO-electronics.de>

From: Lothar Waßmann <LW@KARO-electronics.de>
Data: Wednesday, March 19, 2014 9:09 PM

>To: Dmitry Torokhov; Duan Fugang-B38611; Grant Likely; Henrik Rydberg; Ian
>Campbell; Jingoo Han; Kumar Gala; Mark Rutland; Pawel Moll; Rob Herring; Rob
>Landley; Sachin Kamat; devicetree@vger.kernel.org; linux-doc@vger.kernel.org;
>linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; Simon Budig; Lothar
>Waßmann
>Subject: [PATCHv4 4/5] Input: edt-ft5x06: Ignore touchdown events
>
>The chip may report invalid coordinates on touchdown events, so don't report
>the initial touchdown event.
>
>Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
>---
> drivers/input/touchscreen/edt-ft5x06.c |    4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/input/touchscreen/edt-ft5x06.c
>b/drivers/input/touchscreen/edt-ft5x06.c
>index 27dccfc..af736e4 100644
>--- a/drivers/input/touchscreen/edt-ft5x06.c
>+++ b/drivers/input/touchscreen/edt-ft5x06.c
>@@ -175,6 +175,10 @@ static irqreturn_t edt_ft5x06_ts_isr(int irq, void *dev_id)
> 		if (type == TOUCH_EVENT_RESERVED)
> 			continue;
>
>+		/* ignore TOUCH_DOWN events, might have bogus coordinates */
>+		if (type == TOUCH_EVENT_DOWN)
>+			continue;
>+
> 		x = ((buf[0] << 8) | buf[1]) & 0x0fff;
> 		y = ((buf[2] << 8) | buf[3]) & 0x0fff;
> 		id = (buf[2] >> 4) & 0x0f;
>--
>1.7.10.4
>
>

Acked-by: Fugang Duan <B38611@freescale.com>

  reply	other threads:[~2014-03-20  5:23 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 13:09 Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-03-19 13:09 ` [PATCHv4 1/5] Input: edt-ft5x06: several cleanups; no functional change Lothar Waßmann
2014-03-20  2:42   ` fugang.duan
2014-03-20  2:42     ` fugang.duan-KZfg59tc24xl57MIdRCFDg
2014-03-19 13:09 ` [PATCHv4 2/5] Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-03-20  5:19   ` fugang.duan
2014-03-20  5:19     ` fugang.duan
2014-03-20 11:44     ` Lothar Waßmann
2014-03-20  9:37   ` Mark Rutland
2014-03-20  9:37     ` Mark Rutland
2014-03-20 11:18     ` Simon Budig
2014-03-20 11:18       ` Simon Budig
2014-03-20 13:19       ` Mark Rutland
2014-03-20 11:40     ` Lothar Waßmann
2014-03-20 11:48       ` Simon Budig
2014-03-20 12:05         ` Lothar Waßmann
2014-03-20 13:21       ` Mark Rutland
2014-03-19 13:09 ` [PATCHv4 3/5] Input: edt-ft5x06: Adjust delays to conform datasheet Lothar Waßmann
2014-03-19 13:09 ` [PATCHv4 4/5] Input: edt-ft5x06: Ignore touchdown events Lothar Waßmann
2014-03-20  5:22   ` fugang.duan [this message]
2014-03-20  5:22     ` fugang.duan
2014-03-19 13:09 ` [PATCHv4 5/5] Input: edt-ft5x06: Add support for M09 firmware version Lothar Waßmann
2014-03-19 13:09   ` Lothar Waßmann
2014-03-20 13:44 ` [PATCHv5 0/5] Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-03-20 13:44   ` [PATCHv5 1/5] Input: edt-ft5x06: several cleanups; no functional change Lothar Waßmann
2014-03-20 13:44   ` [PATCHv5 2/5] Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-03-20 13:44     ` Lothar Waßmann
2014-03-20 13:44   ` [PATCHv5 3/5] Input: edt-ft5x06: Adjust delays to conform datasheet Lothar Waßmann
2014-03-20 13:44     ` Lothar Waßmann
2014-03-20 13:44   ` [PATCHv5 4/5] Input: edt-ft5x06: Ignore touchdown events Lothar Waßmann
2014-03-20 13:44   ` [PATCHv5 5/5] Input: edt-ft5x06: Add support for M09 firmware version Lothar Waßmann
2014-03-20 14:15     ` Daniel Wagener
2014-03-24 15:11   ` [PATCHv6 0/5] Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-03-24 15:11     ` [PATCHv6 1/5] Input: edt-ft5x06: several cleanups; no functional change Lothar Waßmann
2014-03-24 15:11     ` [PATCHv6 2/5] Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-03-28 16:26       ` Dmitry Torokhov
2014-03-24 15:11     ` [PATCHv6 3/5] Input: edt-ft5x06: Adjust delays to conform datasheet Lothar Waßmann
2014-03-24 15:11       ` Lothar Waßmann
2014-03-24 15:11     ` [PATCHv6 4/5] Input: edt-ft5x06: Ignore touchdown events Lothar Waßmann
2014-03-24 15:11       ` Lothar Waßmann
2014-03-24 15:11     ` [PATCHv6 5/5] Input: edt-ft5x06: Add support for M09 firmware version Lothar Waßmann
2014-03-28 16:31     ` [PATCHv6 0/5] Input: edt-ft5x06: Add DT support Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=872e4d7ea1ed455592b0bf828d69fb26@BLUPR03MB373.namprd03.prod.outlook.com \
    --to=fugang.duan@freescale.com \
    --cc=LW@KARO-electronics.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jg1.han@samsung.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob@landley.net \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@euromail.se \
    --cc=sachin.kamat@linaro.org \
    --cc=simon.budig@kernelconcepts.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.