All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] docs: zswap: fix shell command format
@ 2024-03-19 11:42 Weiji Wang
  2024-03-29 14:58 ` Jonathan Corbet
  0 siblings, 1 reply; 3+ messages in thread
From: Weiji Wang @ 2024-03-19 11:42 UTC (permalink / raw)
  To: linux-doc; +Cc: Weiji Wang

Format the shell commands as code block to keep the documentation in the
same style
Fixes: 501a06fe8e4c ("zswap: memcontrol: implement zswap writeback disabling")
Fixes: b5ba474f3f51 ("zswap: shrink zswap pool based on memory pressure")
Signed-off-by: Weiji Wang <nebclllo0444@gmail.com>
---
 Documentation/admin-guide/mm/zswap.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/mm/zswap.rst b/Documentation/admin-guide/mm/zswap.rst
index b42132969e31..13632671adae 100644
--- a/Documentation/admin-guide/mm/zswap.rst
+++ b/Documentation/admin-guide/mm/zswap.rst
@@ -155,7 +155,7 @@ Setting this parameter to 100 will disable the hysteresis.
 
 Some users cannot tolerate the swapping that comes with zswap store failures
 and zswap writebacks. Swapping can be disabled entirely (without disabling
-zswap itself) on a cgroup-basis as follows:
+zswap itself) on a cgroup-basis as follows::
 
 	echo 0 > /sys/fs/cgroup/<cgroup-name>/memory.zswap.writeback
 
@@ -166,7 +166,7 @@ writeback (because the same pages might be rejected again and again).
 When there is a sizable amount of cold memory residing in the zswap pool, it
 can be advantageous to proactively write these cold pages to swap and reclaim
 the memory for other use cases. By default, the zswap shrinker is disabled.
-User can enable it as follows:
+User can enable it as follows::
 
   echo Y > /sys/module/zswap/parameters/shrinker_enabled
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: zswap: fix shell command format
  2024-03-19 11:42 [PATCH] docs: zswap: fix shell command format Weiji Wang
@ 2024-03-29 14:58 ` Jonathan Corbet
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2024-03-29 14:58 UTC (permalink / raw)
  To: Weiji Wang, linux-doc; +Cc: Weiji Wang

Weiji Wang <nebclllo0444@gmail.com> writes:

> Format the shell commands as code block to keep the documentation in the
> same style
> Fixes: 501a06fe8e4c ("zswap: memcontrol: implement zswap writeback disabling")
> Fixes: b5ba474f3f51 ("zswap: shrink zswap pool based on memory pressure")
> Signed-off-by: Weiji Wang <nebclllo0444@gmail.com>
> ---
>  Documentation/admin-guide/mm/zswap.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] docs: zswap: fix shell command format
  2024-03-19  7:51 [PATCH] format shell command as code block Jonathan Corbet
@ 2024-03-19 11:35 ` Weiji Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Weiji Wang @ 2024-03-19 11:35 UTC (permalink / raw)
  To: corbet; +Cc: linux-doc

> The *idea* of the change is fine, but there are a couple of problems
> here.  I can't take a patch without a signed-off-by line, so you'll need
> to resubmit with that.

I will resubmit after correcting the format later. Sorry for any
inconvenience.

> Why three colons?  "as follows::" will do what you want.

I see. I will also edit that.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-29 14:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-19 11:42 [PATCH] docs: zswap: fix shell command format Weiji Wang
2024-03-29 14:58 ` Jonathan Corbet
  -- strict thread matches above, loose matches on Subject: below --
2024-03-19  7:51 [PATCH] format shell command as code block Jonathan Corbet
2024-03-19 11:35 ` [PATCH] docs: zswap: fix shell command format Weiji Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.