* [PATCH] MAINTAINERS: Add entry for rdma migration
@ 2023-09-25 13:34 Peter Xu
2023-09-25 13:55 ` Markus Armbruster
2023-09-26 8:56 ` Zhijian Li (Fujitsu)
0 siblings, 2 replies; 5+ messages in thread
From: Peter Xu @ 2023-09-25 13:34 UTC (permalink / raw)
To: qemu-devel
Cc: peterx, Daniel P . Berrangé,
Juan Quintela, Markus Armbruster, Zhijian Li, Fabiano Rosas
It's not obvious to many that RDMA migration is in Odd Fixes stage for a
long time. Add an explicit sub entry for it (besides migration, which
already covers the rdma files) to be clear on that, meanwhile add Zhijian
as Reviewer, so Zhijian can see the patches and review when he still has
the bandwidth.
Cc: Daniel P. Berrangé <berrange@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Zhijian Li (Fujitsu) <lizhijian@fujitsu.com>
Cc: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
MAINTAINERS | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 355b1960ce..f6b21da753 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3217,6 +3217,11 @@ F: qapi/migration.json
F: tests/migration/
F: util/userfaultfd.c
+RDMA Migration
+R: Li Zhijian <lizhijian@fujitsu.com>
+S: Odd Fixes
+F: migration/rdma*
+
Migration dirty limit and dirty page rate
M: Hyman Huang <yong.huang@smartx.com>
S: Maintained
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add entry for rdma migration
2023-09-25 13:34 [PATCH] MAINTAINERS: Add entry for rdma migration Peter Xu
@ 2023-09-25 13:55 ` Markus Armbruster
2023-09-26 17:01 ` Peter Xu
2023-09-26 8:56 ` Zhijian Li (Fujitsu)
1 sibling, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2023-09-25 13:55 UTC (permalink / raw)
To: Peter Xu
Cc: qemu-devel, Daniel P . Berrangé,
Juan Quintela, Zhijian Li, Fabiano Rosas
Peter Xu <peterx@redhat.com> writes:
> It's not obvious to many that RDMA migration is in Odd Fixes stage for a
> long time. Add an explicit sub entry for it (besides migration, which
> already covers the rdma files) to be clear on that, meanwhile add Zhijian
> as Reviewer, so Zhijian can see the patches and review when he still has
> the bandwidth.
>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Zhijian Li (Fujitsu) <lizhijian@fujitsu.com>
> Cc: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> MAINTAINERS | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 355b1960ce..f6b21da753 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3217,6 +3217,11 @@ F: qapi/migration.json
> F: tests/migration/
> F: util/userfaultfd.c
>
> +RDMA Migration
> +R: Li Zhijian <lizhijian@fujitsu.com>
> +S: Odd Fixes
> +F: migration/rdma*
> +
> Migration dirty limit and dirty page rate
> M: Hyman Huang <yong.huang@smartx.com>
> S: Maintained
Hmm...
$ scripts/get_maintainer.pl --status -f migration/rdma.cLi Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
Juan Quintela <quintela@redhat.com> (maintainer:Migration)
Peter Xu <peterx@redhat.com> (reviewer:Migration)
Leonardo Bras <leobras@redhat.com> (reviewer:Migration)
qemu-devel@nongnu.org (open list:All patches CC here)
Odd Fixes
Maintained
Contradictory status. Do we care?
To avoid, try something like the appended patch. With that one:
$ scripts/get_maintainer.pl --status -f migration/rdma.c
Juan Quintela <quintela@redhat.com> (odd fixer:RDMA Migration)
Li Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
Peter Xu <peterx@redhat.com> (reviewer:RDMA Migration)
Leonardo Bras <leobras@redhat.com> (reviewer:RDMA Migration)
qemu-devel@nongnu.org (open list:All patches CC here)
Odd Fixes
diff --git a/MAINTAINERS b/MAINTAINERS
index 355b1960ce..3e80857eab 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3216,6 +3216,15 @@ F: docs/devel/migration.rst
F: qapi/migration.json
F: tests/migration/
F: util/userfaultfd.c
+X: migration/rdma*
+
+RDMA Migration
+M: Juan Quintela <quintela@redhat.com>
+R: Li Zhijian <lizhijian@fujitsu.com>
+R: Peter Xu <peterx@redhat.com>
+R: Leonardo Bras <leobras@redhat.com>
+S: Odd Fixes
+F: migration/rdma*
Migration dirty limit and dirty page rate
M: Hyman Huang <yong.huang@smartx.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add entry for rdma migration
2023-09-25 13:34 [PATCH] MAINTAINERS: Add entry for rdma migration Peter Xu
2023-09-25 13:55 ` Markus Armbruster
@ 2023-09-26 8:56 ` Zhijian Li (Fujitsu)
1 sibling, 0 replies; 5+ messages in thread
From: Zhijian Li (Fujitsu) @ 2023-09-26 8:56 UTC (permalink / raw)
To: Peter Xu, qemu-devel
Cc: Daniel P . Berrangé,
Juan Quintela, Markus Armbruster, Fabiano Rosas
On 25/09/2023 21:34, Peter Xu wrote:
> It's not obvious to many that RDMA migration is in Odd Fixes stage for a
> long time. Add an explicit sub entry for it (besides migration, which
> already covers the rdma files) to be clear on that, meanwhile add Zhijian
> as Reviewer, so Zhijian can see the patches and review when he still has
> the bandwidth.
Feel free to add my Acked tag. thanks.
Acked-by: Li Zhijian <lizhijian@fujitsu.com>
>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Zhijian Li (Fujitsu) <lizhijian@fujitsu.com>
> Cc: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> MAINTAINERS | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 355b1960ce..f6b21da753 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3217,6 +3217,11 @@ F: qapi/migration.json
> F: tests/migration/
> F: util/userfaultfd.c
>
> +RDMA Migration
> +R: Li Zhijian <lizhijian@fujitsu.com>
> +S: Odd Fixes
> +F: migration/rdma*
> +> Migration dirty limit and dirty page rate
> M: Hyman Huang <yong.huang@smartx.com>
> S: Maintained
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add entry for rdma migration
2023-09-25 13:55 ` Markus Armbruster
@ 2023-09-26 17:01 ` Peter Xu
2023-10-03 12:57 ` Juan Quintela
0 siblings, 1 reply; 5+ messages in thread
From: Peter Xu @ 2023-09-26 17:01 UTC (permalink / raw)
To: Markus Armbruster
Cc: qemu-devel, Daniel P . Berrangé,
Juan Quintela, Zhijian Li, Fabiano Rosas
On Mon, Sep 25, 2023 at 03:55:08PM +0200, Markus Armbruster wrote:
> Peter Xu <peterx@redhat.com> writes:
>
> > It's not obvious to many that RDMA migration is in Odd Fixes stage for a
> > long time. Add an explicit sub entry for it (besides migration, which
> > already covers the rdma files) to be clear on that, meanwhile add Zhijian
> > as Reviewer, so Zhijian can see the patches and review when he still has
> > the bandwidth.
> >
> > Cc: Daniel P. Berrangé <berrange@redhat.com>
> > Cc: Juan Quintela <quintela@redhat.com>
> > Cc: Markus Armbruster <armbru@redhat.com>
> > Cc: Zhijian Li (Fujitsu) <lizhijian@fujitsu.com>
> > Cc: Fabiano Rosas <farosas@suse.de>
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> > MAINTAINERS | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 355b1960ce..f6b21da753 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3217,6 +3217,11 @@ F: qapi/migration.json
> > F: tests/migration/
> > F: util/userfaultfd.c
> >
> > +RDMA Migration
> > +R: Li Zhijian <lizhijian@fujitsu.com>
> > +S: Odd Fixes
> > +F: migration/rdma*
> > +
> > Migration dirty limit and dirty page rate
> > M: Hyman Huang <yong.huang@smartx.com>
> > S: Maintained
>
> Hmm...
>
> $ scripts/get_maintainer.pl --status -f migration/rdma.cLi Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
> Juan Quintela <quintela@redhat.com> (maintainer:Migration)
> Peter Xu <peterx@redhat.com> (reviewer:Migration)
> Leonardo Bras <leobras@redhat.com> (reviewer:Migration)
> qemu-devel@nongnu.org (open list:All patches CC here)
> Odd Fixes
> Maintained
>
> Contradictory status. Do we care?
Not a problem to me, but if you or anyone thinks that's better, please feel
free to post another patch to replace this one with Zhijian's ACK attached.
>
> To avoid, try something like the appended patch. With that one:
>
> $ scripts/get_maintainer.pl --status -f migration/rdma.c
> Juan Quintela <quintela@redhat.com> (odd fixer:RDMA Migration)
> Li Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
> Peter Xu <peterx@redhat.com> (reviewer:RDMA Migration)
> Leonardo Bras <leobras@redhat.com> (reviewer:RDMA Migration)
> qemu-devel@nongnu.org (open list:All patches CC here)
> Odd Fixes
>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 355b1960ce..3e80857eab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3216,6 +3216,15 @@ F: docs/devel/migration.rst
> F: qapi/migration.json
> F: tests/migration/
> F: util/userfaultfd.c
> +X: migration/rdma*
> +
> +RDMA Migration
> +M: Juan Quintela <quintela@redhat.com>
> +R: Li Zhijian <lizhijian@fujitsu.com>
> +R: Peter Xu <peterx@redhat.com>
> +R: Leonardo Bras <leobras@redhat.com>
> +S: Odd Fixes
> +F: migration/rdma*
It's slightly a pity we need to copy the lines, and I think this may not be
the only place where we have >1 entries pointing to the same file.
>
> Migration dirty limit and dirty page rate
> M: Hyman Huang <yong.huang@smartx.com>
>
Thanks,
--
Peter Xu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add entry for rdma migration
2023-09-26 17:01 ` Peter Xu
@ 2023-10-03 12:57 ` Juan Quintela
0 siblings, 0 replies; 5+ messages in thread
From: Juan Quintela @ 2023-10-03 12:57 UTC (permalink / raw)
To: Peter Xu
Cc: Markus Armbruster, qemu-devel, Daniel P . Berrangé,
Zhijian Li, Fabiano Rosas
Peter Xu <peterx@redhat.com> wrote:
> On Mon, Sep 25, 2023 at 03:55:08PM +0200, Markus Armbruster wrote:
>> Peter Xu <peterx@redhat.com> writes:
>>
>> > It's not obvious to many that RDMA migration is in Odd Fixes stage for a
>> > long time. Add an explicit sub entry for it (besides migration, which
>> > already covers the rdma files) to be clear on that, meanwhile add Zhijian
>> > as Reviewer, so Zhijian can see the patches and review when he still has
>> > the bandwidth.
>> >
>> > Cc: Daniel P. Berrangé <berrange@redhat.com>
>> > Cc: Juan Quintela <quintela@redhat.com>
>> > Cc: Markus Armbruster <armbru@redhat.com>
>> > Cc: Zhijian Li (Fujitsu) <lizhijian@fujitsu.com>
>> > Cc: Fabiano Rosas <farosas@suse.de>
>> > Signed-off-by: Peter Xu <peterx@redhat.com>
>> > ---
>> > MAINTAINERS | 5 +++++
>> > 1 file changed, 5 insertions(+)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 355b1960ce..f6b21da753 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -3217,6 +3217,11 @@ F: qapi/migration.json
>> > F: tests/migration/
>> > F: util/userfaultfd.c
>> >
>> > +RDMA Migration
>> > +R: Li Zhijian <lizhijian@fujitsu.com>
>> > +S: Odd Fixes
>> > +F: migration/rdma*
>> > +
>> > Migration dirty limit and dirty page rate
>> > M: Hyman Huang <yong.huang@smartx.com>
>> > S: Maintained
>>
>> Hmm...
>>
>> $ scripts/get_maintainer.pl --status -f migration/rdma.cLi Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
>> Juan Quintela <quintela@redhat.com> (maintainer:Migration)
>> Peter Xu <peterx@redhat.com> (reviewer:Migration)
>> Leonardo Bras <leobras@redhat.com> (reviewer:Migration)
>> qemu-devel@nongnu.org (open list:All patches CC here)
>> Odd Fixes
>> Maintained
>>
>> Contradictory status. Do we care?
>
> Not a problem to me, but if you or anyone thinks that's better, please feel
> free to post another patch to replace this one with Zhijian's ACK attached.
Sending Markus version with Zhijian ACK.
>>
>> To avoid, try something like the appended patch. With that one:
>>
>> $ scripts/get_maintainer.pl --status -f migration/rdma.c
>> Juan Quintela <quintela@redhat.com> (odd fixer:RDMA Migration)
>> Li Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
>> Peter Xu <peterx@redhat.com> (reviewer:RDMA Migration)
>> Leonardo Bras <leobras@redhat.com> (reviewer:RDMA Migration)
>> qemu-devel@nongnu.org (open list:All patches CC here)
>> Odd Fixes
>>
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 355b1960ce..3e80857eab 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3216,6 +3216,15 @@ F: docs/devel/migration.rst
>> F: qapi/migration.json
>> F: tests/migration/
>> F: util/userfaultfd.c
>> +X: migration/rdma*
>> +
>> +RDMA Migration
>> +M: Juan Quintela <quintela@redhat.com>
>> +R: Li Zhijian <lizhijian@fujitsu.com>
>> +R: Peter Xu <peterx@redhat.com>
>> +R: Leonardo Bras <leobras@redhat.com>
>> +S: Odd Fixes
>> +F: migration/rdma*
>
> It's slightly a pity we need to copy the lines, and I think this may not be
> the only place where we have >1 entries pointing to the same file.
>
>>
>> Migration dirty limit and dirty page rate
>> M: Hyman Huang <yong.huang@smartx.com>
>>
>
> Thanks,
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-03 12:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-25 13:34 [PATCH] MAINTAINERS: Add entry for rdma migration Peter Xu
2023-09-25 13:55 ` Markus Armbruster
2023-09-26 17:01 ` Peter Xu
2023-10-03 12:57 ` Juan Quintela
2023-09-26 8:56 ` Zhijian Li (Fujitsu)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.