All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/qemu: add qemu host tools
@ 2022-05-30 15:16 Thomas Devoogdt
  2022-06-20 19:39 ` Arnout Vandecappelle
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Devoogdt @ 2022-05-30 15:16 UTC (permalink / raw)
  To: buildroot; +Cc: Romain Naour, Thomas Devoogdt

From: Thomas Devoogdt <thomas.devoogdt@gmail.com>

Allow host tools e.g. qemu-img to be built.
Similar to the BR2_PACKAGE_QEMU_TOOLS option.

Signed-off-by: Thomas Devoogdt <thomas.devoogdt@gmail.com>
---
 package/qemu/Config.in.host | 6 ++++++
 package/qemu/qemu.mk        | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host
index f9cdb9b703..2aa6991263 100644
--- a/package/qemu/Config.in.host
+++ b/package/qemu/Config.in.host
@@ -102,4 +102,10 @@ config BR2_PACKAGE_HOST_QEMU_USB
 	help
 	  Enables USB passthrough support from guest to host.
 
+config BR2_PACKAGE_HOST_QEMU_TOOLS
+	bool "Enable tools"
+	help
+	  Say 'y' here to include tools packaged with QEMU
+	  (e.g. qemu-img).
+
 endif
diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 1bcffc2340..9623068c93 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -348,6 +348,12 @@ else
 HOST_QEMU_OPTS += --disable-libusb
 endif
 
+ifeq ($(BR2_PACKAGE_HOST_QEMU_TOOLS),y)
+HOST_QEMU_OPTS += --enable-tools
+else
+HOST_QEMU_OPTS += --disable-tools
+endif
+
 # Override CPP, as it expects to be able to call it like it'd
 # call the compiler.
 define HOST_QEMU_CONFIGURE_CMDS
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/qemu: add qemu host tools
  2022-05-30 15:16 [Buildroot] [PATCH 1/1] package/qemu: add qemu host tools Thomas Devoogdt
@ 2022-06-20 19:39 ` Arnout Vandecappelle
  2022-06-21  8:34   ` Thomas Devoogdt
  0 siblings, 1 reply; 7+ messages in thread
From: Arnout Vandecappelle @ 2022-06-20 19:39 UTC (permalink / raw)
  To: Thomas Devoogdt, buildroot; +Cc: Romain Naour, Thomas Devoogdt

  Hi Thomas,

On 30/05/2022 17:16, Thomas Devoogdt wrote:
> From: Thomas Devoogdt <thomas.devoogdt@gmail.com>
> 
> Allow host tools e.g. qemu-img to be built.
> Similar to the BR2_PACKAGE_QEMU_TOOLS option.
> 
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@gmail.com>
> ---
>   package/qemu/Config.in.host | 6 ++++++
>   package/qemu/qemu.mk        | 6 ++++++
>   2 files changed, 12 insertions(+)
> 
> diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host
> index f9cdb9b703..2aa6991263 100644
> --- a/package/qemu/Config.in.host
> +++ b/package/qemu/Config.in.host
> @@ -102,4 +102,10 @@ config BR2_PACKAGE_HOST_QEMU_USB
>   	help
>   	  Enables USB passthrough support from guest to host.
>   
> +config BR2_PACKAGE_HOST_QEMU_TOOLS
> +	bool "Enable tools"
> +	help
> +	  Say 'y' here to include tools packaged with QEMU
> +	  (e.g. qemu-img).

  For host packages, there's no rootfs size constraint, so there is normally no 
reason to have sub-options. Only if it would dramatically increase the build 
time, it's worth to make an option for this feature.

  In other words: simply do --enable-tools unconditionally.

  Regards,
  Arnout

> +
>   endif
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 1bcffc2340..9623068c93 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -348,6 +348,12 @@ else
>   HOST_QEMU_OPTS += --disable-libusb
>   endif
>   
> +ifeq ($(BR2_PACKAGE_HOST_QEMU_TOOLS),y)
> +HOST_QEMU_OPTS += --enable-tools
> +else
> +HOST_QEMU_OPTS += --disable-tools
> +endif
> +
>   # Override CPP, as it expects to be able to call it like it'd
>   # call the compiler.
>   define HOST_QEMU_CONFIGURE_CMDS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/qemu: add qemu host tools
  2022-06-20 19:39 ` Arnout Vandecappelle
@ 2022-06-21  8:34   ` Thomas Devoogdt
  2022-06-27 20:43     ` Peter Korsgaard
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Devoogdt @ 2022-06-21  8:34 UTC (permalink / raw)
  To: Arnout Vandecappelle; +Cc: Thomas Devoogdt, Romain Naour, buildroot


[-- Attachment #1.1: Type: text/plain, Size: 2190 bytes --]

Hi,

I did not find a way to update this series (using git send-email), should I
send my mail to something else than buildroot@buildroot.org?
Anyway, a new patch can be found here:
https://patchwork.ozlabs.org/project/buildroot/patch/20220621083027.2587218-1-thomas@devoogdt.com/

Kind regards,

Thomas Devoogdt

Op ma 20 jun. 2022 om 21:40 schreef Arnout Vandecappelle <arnout@mind.be>:

>   Hi Thomas,
>
> On 30/05/2022 17:16, Thomas Devoogdt wrote:
> > From: Thomas Devoogdt <thomas.devoogdt@gmail.com>
> >
> > Allow host tools e.g. qemu-img to be built.
> > Similar to the BR2_PACKAGE_QEMU_TOOLS option.
> >
> > Signed-off-by: Thomas Devoogdt <thomas.devoogdt@gmail.com>
> > ---
> >   package/qemu/Config.in.host | 6 ++++++
> >   package/qemu/qemu.mk        | 6 ++++++
> >   2 files changed, 12 insertions(+)
> >
> > diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host
> > index f9cdb9b703..2aa6991263 100644
> > --- a/package/qemu/Config.in.host
> > +++ b/package/qemu/Config.in.host
> > @@ -102,4 +102,10 @@ config BR2_PACKAGE_HOST_QEMU_USB
> >       help
> >         Enables USB passthrough support from guest to host.
> >
> > +config BR2_PACKAGE_HOST_QEMU_TOOLS
> > +     bool "Enable tools"
> > +     help
> > +       Say 'y' here to include tools packaged with QEMU
> > +       (e.g. qemu-img).
>
>   For host packages, there's no rootfs size constraint, so there is
> normally no
> reason to have sub-options. Only if it would dramatically increase the
> build
> time, it's worth to make an option for this feature.
>
>   In other words: simply do --enable-tools unconditionally.
>
>   Regards,
>   Arnout
>
> > +
> >   endif
> > diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> > index 1bcffc2340..9623068c93 100644
> > --- a/package/qemu/qemu.mk
> > +++ b/package/qemu/qemu.mk
> > @@ -348,6 +348,12 @@ else
> >   HOST_QEMU_OPTS += --disable-libusb
> >   endif
> >
> > +ifeq ($(BR2_PACKAGE_HOST_QEMU_TOOLS),y)
> > +HOST_QEMU_OPTS += --enable-tools
> > +else
> > +HOST_QEMU_OPTS += --disable-tools
> > +endif
> > +
> >   # Override CPP, as it expects to be able to call it like it'd
> >   # call the compiler.
> >   define HOST_QEMU_CONFIGURE_CMDS
>

[-- Attachment #1.2: Type: text/html, Size: 3546 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/qemu: add qemu host tools
  2022-06-21  8:34   ` Thomas Devoogdt
@ 2022-06-27 20:43     ` Peter Korsgaard
  0 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2022-06-27 20:43 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: Romain Naour, buildroot

>>>>> "Thomas" == Thomas Devoogdt <thomas@devoogdt.com> writes:

 > Hi,
 > I did not find a way to update this series (using git send-email), should I
 > send my mail to something else than buildroot@buildroot.org?
 > Anyway, a new patch can be found here:
 > https://patchwork.ozlabs.org/project/buildroot/patch/20220621083027.2587218-1-thomas@devoogdt.com/

Simple send a v2 patch (git send-email -v2 ..) and login to patchwork to
mark your v1 patch as superseeded, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/qemu: add qemu host tools
  2022-06-21  8:30 Thomas Devoogdt
  2022-06-21 19:40 ` Thomas Huth
@ 2022-06-27 20:13 ` Arnout Vandecappelle
  1 sibling, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2022-06-27 20:13 UTC (permalink / raw)
  To: Thomas Devoogdt, buildroot; +Cc: Romain Naour, Thomas Devoogdt



On 21/06/2022 10:30, Thomas Devoogdt wrote:
> From: Thomas Devoogdt <thomas.devoogdt@gmail.com>
> 
> Always build host qemu-tools e.g. qemu-img.
> https://qemu.readthedocs.io/en/latest/tools/index.html
> 
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/qemu/qemu.mk | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 290186ec4e..9e1bec3836 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -390,6 +390,7 @@ define HOST_QEMU_CONFIGURE_CMDS
>   		--disable-vnc-jpeg \
>   		--disable-vnc-png \
>   		--disable-vnc-sasl \
> +		--enable-tools \
>   		$(HOST_QEMU_OPTS)
>   endef
>   
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/qemu: add qemu host tools
  2022-06-21  8:30 Thomas Devoogdt
@ 2022-06-21 19:40 ` Thomas Huth
  2022-06-27 20:13 ` Arnout Vandecappelle
  1 sibling, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2022-06-21 19:40 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: Romain Naour, Thomas Devoogdt, buildroot

Am Tue, 21 Jun 2022 10:30:27 +0200
schrieb Thomas Devoogdt <thomas@devoogdt.com>:

> From: Thomas Devoogdt <thomas.devoogdt@gmail.com>
> 
> Always build host qemu-tools e.g. qemu-img.
> https://qemu.readthedocs.io/en/latest/tools/index.html
> 
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@gmail.com>
> ---
>  package/qemu/qemu.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 290186ec4e..9e1bec3836 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -390,6 +390,7 @@ define HOST_QEMU_CONFIGURE_CMDS
>  		--disable-vnc-jpeg \
>  		--disable-vnc-png \
>  		--disable-vnc-sasl \
> +		--enable-tools \
>  		$(HOST_QEMU_OPTS)
>  endef
>  

Reviewed-by: Thomas Huth <huth@tuxfamily.org>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/qemu: add qemu host tools
@ 2022-06-21  8:30 Thomas Devoogdt
  2022-06-21 19:40 ` Thomas Huth
  2022-06-27 20:13 ` Arnout Vandecappelle
  0 siblings, 2 replies; 7+ messages in thread
From: Thomas Devoogdt @ 2022-06-21  8:30 UTC (permalink / raw)
  To: buildroot; +Cc: Romain Naour, Thomas Devoogdt

From: Thomas Devoogdt <thomas.devoogdt@gmail.com>

Always build host qemu-tools e.g. qemu-img.
https://qemu.readthedocs.io/en/latest/tools/index.html

Signed-off-by: Thomas Devoogdt <thomas.devoogdt@gmail.com>
---
 package/qemu/qemu.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 290186ec4e..9e1bec3836 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -390,6 +390,7 @@ define HOST_QEMU_CONFIGURE_CMDS
 		--disable-vnc-jpeg \
 		--disable-vnc-png \
 		--disable-vnc-sasl \
+		--enable-tools \
 		$(HOST_QEMU_OPTS)
 endef
 
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-06-27 20:43 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-30 15:16 [Buildroot] [PATCH 1/1] package/qemu: add qemu host tools Thomas Devoogdt
2022-06-20 19:39 ` Arnout Vandecappelle
2022-06-21  8:34   ` Thomas Devoogdt
2022-06-27 20:43     ` Peter Korsgaard
2022-06-21  8:30 Thomas Devoogdt
2022-06-21 19:40 ` Thomas Huth
2022-06-27 20:13 ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.