* [Buildroot] [PATCH 1/2] package/jack1: libsamplerate is optional, not mandatory
@ 2022-03-20 21:18 Fabrice Fontaine
2022-03-20 21:18 ` [Buildroot] [PATCH 2/2] package/jack1: libsndfile " Fabrice Fontaine
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2022-03-20 21:18 UTC (permalink / raw)
To: buildroot; +Cc: Adam Heinrich, Fabrice Fontaine
libsamplerate is only needed to build the NetJack backend and internal
client
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/jack1/Config.in | 1 -
package/jack1/jack1.mk | 6 +++++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/package/jack1/Config.in b/package/jack1/Config.in
index 1c67f10332..625afdf8c1 100644
--- a/package/jack1/Config.in
+++ b/package/jack1/Config.in
@@ -10,7 +10,6 @@ config BR2_PACKAGE_JACK1
select BR2_PACKAGE_ALSA_LIB_RAWMIDI
select BR2_PACKAGE_ALSA_LIB_SEQ
select BR2_PACKAGE_BERKELEYDB
- select BR2_PACKAGE_LIBSAMPLERATE
select BR2_PACKAGE_LIBSNDFILE
help
JACK Audio Connection Kit (JACK 1 implementation).
diff --git a/package/jack1/jack1.mk b/package/jack1/jack1.mk
index 311f7c9ba0..39183826a4 100644
--- a/package/jack1/jack1.mk
+++ b/package/jack1/jack1.mk
@@ -11,7 +11,11 @@ JACK1_LICENSE = GPL-2.0+ (jack server), LGPL-2.1+ (jack library)
JACK1_LICENSE_FILES = COPYING COPYING.GPL COPYING.LGPL
JACK1_INSTALL_STAGING = YES
-JACK1_DEPENDENCIES = host-pkgconf alsa-lib berkeleydb libsamplerate libsndfile
+JACK1_DEPENDENCIES = host-pkgconf alsa-lib berkeleydb libsndfile
+
+ifeq ($(BR2_PACKAGE_LIBSAMPLERATE),y)
+JACK1_DEPENDENCIES += libsamplerate
+endif
ifeq ($(BR2_PACKAGE_READLINE),y)
JACK1_DEPENDENCIES += readline
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] package/jack1: libsndfile is optional, not mandatory
2022-03-20 21:18 [Buildroot] [PATCH 1/2] package/jack1: libsamplerate is optional, not mandatory Fabrice Fontaine
@ 2022-03-20 21:18 ` Fabrice Fontaine
2022-03-31 6:23 ` Peter Korsgaard
2022-03-27 15:58 ` [Buildroot] [PATCH 1/2] package/jack1: libsamplerate " Arnout Vandecappelle
2022-03-31 6:22 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2022-03-20 21:18 UTC (permalink / raw)
To: buildroot; +Cc: Adam Heinrich, Fabrice Fontaine
libsndfile is only needed to build jackrec example client
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/jack1/Config.in | 1 -
package/jack1/jack1.mk | 6 +++++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/package/jack1/Config.in b/package/jack1/Config.in
index 625afdf8c1..5b3116e2f1 100644
--- a/package/jack1/Config.in
+++ b/package/jack1/Config.in
@@ -10,7 +10,6 @@ config BR2_PACKAGE_JACK1
select BR2_PACKAGE_ALSA_LIB_RAWMIDI
select BR2_PACKAGE_ALSA_LIB_SEQ
select BR2_PACKAGE_BERKELEYDB
- select BR2_PACKAGE_LIBSNDFILE
help
JACK Audio Connection Kit (JACK 1 implementation).
diff --git a/package/jack1/jack1.mk b/package/jack1/jack1.mk
index 39183826a4..6dca56001f 100644
--- a/package/jack1/jack1.mk
+++ b/package/jack1/jack1.mk
@@ -11,12 +11,16 @@ JACK1_LICENSE = GPL-2.0+ (jack server), LGPL-2.1+ (jack library)
JACK1_LICENSE_FILES = COPYING COPYING.GPL COPYING.LGPL
JACK1_INSTALL_STAGING = YES
-JACK1_DEPENDENCIES = host-pkgconf alsa-lib berkeleydb libsndfile
+JACK1_DEPENDENCIES = host-pkgconf alsa-lib berkeleydb
ifeq ($(BR2_PACKAGE_LIBSAMPLERATE),y)
JACK1_DEPENDENCIES += libsamplerate
endif
+ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
+JACK1_DEPENDENCIES += libsndfile
+endif
+
ifeq ($(BR2_PACKAGE_READLINE),y)
JACK1_DEPENDENCIES += readline
endif
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/jack1: libsamplerate is optional, not mandatory
2022-03-20 21:18 [Buildroot] [PATCH 1/2] package/jack1: libsamplerate is optional, not mandatory Fabrice Fontaine
2022-03-20 21:18 ` [Buildroot] [PATCH 2/2] package/jack1: libsndfile " Fabrice Fontaine
@ 2022-03-27 15:58 ` Arnout Vandecappelle
2022-03-31 6:22 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2022-03-27 15:58 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot; +Cc: Adam Heinrich
On 20/03/2022 22:18, Fabrice Fontaine wrote:
> libsamplerate is only needed to build the NetJack backend and internal
> client
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied both to master, thanks.
Regards,
Arnout
> ---
> package/jack1/Config.in | 1 -
> package/jack1/jack1.mk | 6 +++++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/package/jack1/Config.in b/package/jack1/Config.in
> index 1c67f10332..625afdf8c1 100644
> --- a/package/jack1/Config.in
> +++ b/package/jack1/Config.in
> @@ -10,7 +10,6 @@ config BR2_PACKAGE_JACK1
> select BR2_PACKAGE_ALSA_LIB_RAWMIDI
> select BR2_PACKAGE_ALSA_LIB_SEQ
> select BR2_PACKAGE_BERKELEYDB
> - select BR2_PACKAGE_LIBSAMPLERATE
> select BR2_PACKAGE_LIBSNDFILE
> help
> JACK Audio Connection Kit (JACK 1 implementation).
> diff --git a/package/jack1/jack1.mk b/package/jack1/jack1.mk
> index 311f7c9ba0..39183826a4 100644
> --- a/package/jack1/jack1.mk
> +++ b/package/jack1/jack1.mk
> @@ -11,7 +11,11 @@ JACK1_LICENSE = GPL-2.0+ (jack server), LGPL-2.1+ (jack library)
> JACK1_LICENSE_FILES = COPYING COPYING.GPL COPYING.LGPL
> JACK1_INSTALL_STAGING = YES
>
> -JACK1_DEPENDENCIES = host-pkgconf alsa-lib berkeleydb libsamplerate libsndfile
> +JACK1_DEPENDENCIES = host-pkgconf alsa-lib berkeleydb libsndfile
> +
> +ifeq ($(BR2_PACKAGE_LIBSAMPLERATE),y)
> +JACK1_DEPENDENCIES += libsamplerate
> +endif
>
> ifeq ($(BR2_PACKAGE_READLINE),y)
> JACK1_DEPENDENCIES += readline
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/jack1: libsamplerate is optional, not mandatory
2022-03-20 21:18 [Buildroot] [PATCH 1/2] package/jack1: libsamplerate is optional, not mandatory Fabrice Fontaine
2022-03-20 21:18 ` [Buildroot] [PATCH 2/2] package/jack1: libsndfile " Fabrice Fontaine
2022-03-27 15:58 ` [Buildroot] [PATCH 1/2] package/jack1: libsamplerate " Arnout Vandecappelle
@ 2022-03-31 6:22 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-03-31 6:22 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Adam Heinrich, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> libsamplerate is only needed to build the NetJack backend and internal
> client
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/jack1: libsndfile is optional, not mandatory
2022-03-20 21:18 ` [Buildroot] [PATCH 2/2] package/jack1: libsndfile " Fabrice Fontaine
@ 2022-03-31 6:23 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-03-31 6:23 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Adam Heinrich, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> libsndfile is only needed to build jackrec example client
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-31 6:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-20 21:18 [Buildroot] [PATCH 1/2] package/jack1: libsamplerate is optional, not mandatory Fabrice Fontaine
2022-03-20 21:18 ` [Buildroot] [PATCH 2/2] package/jack1: libsndfile " Fabrice Fontaine
2022-03-31 6:23 ` Peter Korsgaard
2022-03-27 15:58 ` [Buildroot] [PATCH 1/2] package/jack1: libsamplerate " Arnout Vandecappelle
2022-03-31 6:22 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.