All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	akpm@linux-foundation.org, broonie@kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz,
	mm-commits@vger.kernel.org, sfr@canb.auug.org.au,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: mmotm 2022-01-26-21-04 uploaded (gpu/drm/i915/i915_gem_evict.h)
Date: Thu, 27 Jan 2022 11:44:18 +0200	[thread overview]
Message-ID: <8735l9y0lp.fsf@intel.com> (raw)
In-Reply-To: <6b4f3d82-01e8-5bf3-927f-33ac62178fd5@infradead.org>

On Wed, 26 Jan 2022, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 1/26/22 21:04, akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2022-01-26-21-04 has been uploaded to
>> 
>>    https://www.ozlabs.org/~akpm/mmotm/
>> 
>> mmotm-readme.txt says
>> 
>> README for mm-of-the-moment:
>> 
>> https://www.ozlabs.org/~akpm/mmotm/
>> 
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
>> 
>> You will need quilt to apply these patches to the latest Linus release (5.x
>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
>> https://ozlabs.org/~akpm/mmotm/series
>> 
>> The file broken-out.tar.gz contains two datestamp files: .DATE and
>> .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
>> followed by the base kernel version against which this patch series is to
>> be applied.
>
> on x86_64:
> (from linux-next.patch)
>
>
>   HDRTEST drivers/gpu/drm/i915/i915_gem_evict.h
> In file included from <command-line>:0:0:
> ./../drivers/gpu/drm/i915/i915_gem_evict.h:15:15: error: ‘struct i915_gem_ww_ctx’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>         struct i915_gem_ww_ctx *ww,
>                ^~~~~~~~~~~~~~~
> ./../drivers/gpu/drm/i915/i915_gem_evict.h:21:14: error: ‘struct i915_gem_ww_ctx’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>        struct i915_gem_ww_ctx *ww,
>               ^~~~~~~~~~~~~~~
> ./../drivers/gpu/drm/i915/i915_gem_evict.h:25:16: error: ‘struct i915_gem_ww_ctx’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>          struct i915_gem_ww_ctx *ww);
>                 ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors

Thanks for the report.

This is only visible with CONFIG_DRM_I915_WERROR=y which depends on
COMPILE_TEST=n. We use the "HDRTEST" and -Werror for development and CI
to keep the driver clean, but it's not really intended for general
consumption. Usually when something like this even hits the tree it's
because of a merge mishap somewhere down the line.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	akpm@linux-foundation.org, broonie@kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz,
	mm-commits@vger.kernel.org, sfr@canb.auug.org.au,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] mmotm 2022-01-26-21-04 uploaded (gpu/drm/i915/i915_gem_evict.h)
Date: Thu, 27 Jan 2022 11:44:18 +0200	[thread overview]
Message-ID: <8735l9y0lp.fsf@intel.com> (raw)
In-Reply-To: <6b4f3d82-01e8-5bf3-927f-33ac62178fd5@infradead.org>

On Wed, 26 Jan 2022, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 1/26/22 21:04, akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2022-01-26-21-04 has been uploaded to
>> 
>>    https://www.ozlabs.org/~akpm/mmotm/
>> 
>> mmotm-readme.txt says
>> 
>> README for mm-of-the-moment:
>> 
>> https://www.ozlabs.org/~akpm/mmotm/
>> 
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
>> 
>> You will need quilt to apply these patches to the latest Linus release (5.x
>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
>> https://ozlabs.org/~akpm/mmotm/series
>> 
>> The file broken-out.tar.gz contains two datestamp files: .DATE and
>> .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
>> followed by the base kernel version against which this patch series is to
>> be applied.
>
> on x86_64:
> (from linux-next.patch)
>
>
>   HDRTEST drivers/gpu/drm/i915/i915_gem_evict.h
> In file included from <command-line>:0:0:
> ./../drivers/gpu/drm/i915/i915_gem_evict.h:15:15: error: ‘struct i915_gem_ww_ctx’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>         struct i915_gem_ww_ctx *ww,
>                ^~~~~~~~~~~~~~~
> ./../drivers/gpu/drm/i915/i915_gem_evict.h:21:14: error: ‘struct i915_gem_ww_ctx’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>        struct i915_gem_ww_ctx *ww,
>               ^~~~~~~~~~~~~~~
> ./../drivers/gpu/drm/i915/i915_gem_evict.h:25:16: error: ‘struct i915_gem_ww_ctx’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>          struct i915_gem_ww_ctx *ww);
>                 ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors

Thanks for the report.

This is only visible with CONFIG_DRM_I915_WERROR=y which depends on
COMPILE_TEST=n. We use the "HDRTEST" and -Werror for development and CI
to keep the driver clean, but it's not really intended for general
consumption. Usually when something like this even hits the tree it's
because of a merge mishap somewhere down the line.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2022-01-27  9:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27  5:04 mmotm 2022-01-26-21-04 uploaded akpm
2022-01-27  5:51 ` Stephen Rothwell
2022-01-27  6:02   ` Andrew Morton
2022-01-27  6:31 ` mmotm 2022-01-26-21-04 uploaded (drivers/mtd/nand.raw/Kconfig warning) Randy Dunlap
2022-01-27  6:31   ` Randy Dunlap
2022-01-27  6:52 ` mmotm 2022-01-26-21-04 uploaded (gpu/drm/i915/i915_gem_evict.h) Randy Dunlap
2022-01-27  6:52   ` [Intel-gfx] " Randy Dunlap
2022-01-27  9:44   ` Jani Nikula [this message]
2022-01-27  9:44     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735l9y0lp.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=mm-commits@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.