From: Thomas Gleixner <tglx@linutronix.de>
To: Will Deacon <will@kernel.org>
Cc: Xin Hao <xhao@linux.alibaba.com>,
fweisbec@gmail.com, john.stultz@linaro.org,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, lorenzo@google.com, maz@kernel.org,
mika.penttila@nextfour.com, sboyd@kernel.org
Subject: Re: [PATCH v2 2/5] tick/broadcast: Split __tick_broadcast_oneshot_control() into a helper
Date: Tue, 01 Jun 2021 20:14:33 +0200 [thread overview]
Message-ID: <8735u13112.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20210601121351.GA27832@willie-the-truck>
On Tue, Jun 01 2021 at 13:13, Will Deacon wrote:
> On Mon, May 31, 2021 at 04:29:20PM +0200, Thomas Gleixner wrote:
>> On Thu, May 27 2021 at 12:56, Will Deacon wrote:
>>
>> > On Thu, May 27, 2021 at 07:35:03PM +0800, Xin Hao wrote:
>> >>
>> >> 在 2021/5/27 下午4:22, Will Deacon 写道:
>> >> > On Thu, May 27, 2021 at 03:23:06PM +0800, Xin Hao wrote:
>> >> > > I had backport you tick/broadcast: Prefer per-cpu relatives patches,
>> >> > >
>> >> > > but i did not get the true result, the Wakeup Devices are all null, why?
>> >> > Probably because you don't have any suitable per-cpu timers to act as a
>> >> > wakeup. Do you have a per-cpu timer registered with CLOCK_EVT_FEAT_PERCPU
>> >>
>> >> Yes, you are right, but i want to know why the timer do not support
>> >> CLOCK_EVT_FEAT_PERCPU.
>> >
>> > I defer to Thomas on this one.
>>
>> How should I know what kind of timers this hardware has?
>
> Duh, sorry, I replied to the wrong question. I meant to defer the decision
> about whether to print "<NULL>" if the wakeup timer is absent, or whether to
> omit the line entirely.
>
> I went with the former in the patches you queued as it's both consistent
> with the rest of the code and probably (?) easier to parse.
That makes more sense. I just kept it as is. The <NULL> is fine.
Thanks,
tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Will Deacon <will@kernel.org>
Cc: Xin Hao <xhao@linux.alibaba.com>,
fweisbec@gmail.com, john.stultz@linaro.org,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, lorenzo@google.com, maz@kernel.org,
mika.penttila@nextfour.com, sboyd@kernel.org
Subject: Re: [PATCH v2 2/5] tick/broadcast: Split __tick_broadcast_oneshot_control() into a helper
Date: Tue, 01 Jun 2021 20:14:33 +0200 [thread overview]
Message-ID: <8735u13112.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20210601121351.GA27832@willie-the-truck>
On Tue, Jun 01 2021 at 13:13, Will Deacon wrote:
> On Mon, May 31, 2021 at 04:29:20PM +0200, Thomas Gleixner wrote:
>> On Thu, May 27 2021 at 12:56, Will Deacon wrote:
>>
>> > On Thu, May 27, 2021 at 07:35:03PM +0800, Xin Hao wrote:
>> >>
>> >> 在 2021/5/27 下午4:22, Will Deacon 写道:
>> >> > On Thu, May 27, 2021 at 03:23:06PM +0800, Xin Hao wrote:
>> >> > > I had backport you tick/broadcast: Prefer per-cpu relatives patches,
>> >> > >
>> >> > > but i did not get the true result, the Wakeup Devices are all null, why?
>> >> > Probably because you don't have any suitable per-cpu timers to act as a
>> >> > wakeup. Do you have a per-cpu timer registered with CLOCK_EVT_FEAT_PERCPU
>> >>
>> >> Yes, you are right, but i want to know why the timer do not support
>> >> CLOCK_EVT_FEAT_PERCPU.
>> >
>> > I defer to Thomas on this one.
>>
>> How should I know what kind of timers this hardware has?
>
> Duh, sorry, I replied to the wrong question. I meant to defer the decision
> about whether to print "<NULL>" if the wakeup timer is absent, or whether to
> omit the line entirely.
>
> I went with the former in the patches you queued as it's both consistent
> with the rest of the code and probably (?) easier to parse.
That makes more sense. I just kept it as is. The <NULL> is fine.
Thanks,
tglx
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-01 18:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 22:18 [PATCH v2 0/5] tick/broadcast: Allow per-cpu timers to be used instead of broadcast Will Deacon
2021-05-24 22:18 ` Will Deacon
2021-05-24 22:18 ` [PATCH v2 1/5] tick/broadcast: Drop unneeded CONFIG_GENERIC_CLOCKEVENTS_BROADCAST guard Will Deacon
2021-05-24 22:18 ` Will Deacon
2021-05-31 15:07 ` [tip: timers/core] " tip-bot2 for Will Deacon
2021-05-24 22:18 ` [PATCH v2 2/5] tick/broadcast: Split __tick_broadcast_oneshot_control() into a helper Will Deacon
2021-05-24 22:18 ` Will Deacon
2021-05-27 7:23 ` Xin Hao
2021-05-27 7:23 ` Xin Hao
2021-05-27 8:22 ` Will Deacon
2021-05-27 8:22 ` Will Deacon
2021-05-27 11:35 ` Xin Hao
2021-05-27 11:35 ` Xin Hao
2021-05-27 11:55 ` Will Deacon
2021-05-27 11:55 ` Will Deacon
2021-05-27 11:56 ` Will Deacon
2021-05-27 11:56 ` Will Deacon
2021-05-31 14:29 ` Thomas Gleixner
2021-05-31 14:29 ` Thomas Gleixner
2021-06-01 12:13 ` Will Deacon
2021-06-01 12:13 ` Will Deacon
2021-06-01 18:14 ` Thomas Gleixner [this message]
2021-06-01 18:14 ` Thomas Gleixner
2021-05-31 15:06 ` [tip: timers/core] " tip-bot2 for Will Deacon
2021-05-24 22:18 ` [PATCH v2 3/5] tick/broadcast: Prefer per-cpu oneshot wakeup timers to broadcast Will Deacon
2021-05-24 22:18 ` Will Deacon
2021-05-31 15:06 ` [tip: timers/core] " tip-bot2 for Will Deacon
2021-05-24 22:18 ` [PATCH v2 4/5] tick/broadcast: Program wakeup timer when entering idle if required Will Deacon
2021-05-24 22:18 ` Will Deacon
2021-05-31 15:06 ` [tip: timers/core] " tip-bot2 for Will Deacon
2021-05-24 22:18 ` [PATCH v2 5/5] timer_list: Print name of per-cpu wakeup device Will Deacon
2021-05-24 22:18 ` Will Deacon
2021-05-31 15:06 ` [tip: timers/core] " tip-bot2 for Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735u13112.ffs@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=fweisbec@gmail.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@google.com \
--cc=maz@kernel.org \
--cc=mika.penttila@nextfour.com \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
--cc=xhao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.