From: Felipe Balbi <balbi@kernel.org>
To: Li Jun <jun.li@nxp.com>, gregkh@linuxfoundation.org
Cc: shawnguo@kernel.org, linux-imx@nxp.com,
thunder.leizhen@huawei.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: imx8mp: detect dwc3 core node via compatible string
Date: Fri, 30 Apr 2021 11:24:18 +0300 [thread overview]
Message-ID: <8735v8ji31.fsf@kernel.org> (raw)
In-Reply-To: <1619765836-20387-1-git-send-email-jun.li@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
Li Jun <jun.li@nxp.com> writes:
> New schema of usb controller DT-node should be named with prefix
> "^usb(@.*)?", dt changed the node name, but missed counter part
> change in driver, fix it by switching to use compatible string as
> the dwc3 core compatible string keeps "snps,dwc3" in all dt.
>
> Fixes: d1689cd3c0f4 ("arm64: dts: imx8mp: Use the correct name for child node "snps, dwc3"")
> Signed-off-by: Li Jun <jun.li@nxp.com>
Nice fix :-) It may break down if we have two dwc3 nodes as child of a
single parent, but I guess that's very unlikely anyway.
Acked-by: Felipe Balbi <balbi@kernel.org>
That being said, why do need to keep a pointer to the child? I had a
quick look at the driver and it doesn't seem like the pointer is
necessary at all.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
next prev parent reply other threads:[~2021-04-30 8:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 6:57 [PATCH] usb: dwc3: imx8mp: detect dwc3 core node via compatible string Li Jun
2021-04-30 8:24 ` Felipe Balbi [this message]
2021-04-30 9:38 ` Jun Li
2021-04-30 10:00 ` Felipe Balbi
2021-05-06 11:28 ` Jun Li
2021-05-06 14:31 ` Felipe Balbi
2021-05-07 7:31 ` Jun Li
2021-05-11 7:59 ` Heikki Krogerus
2021-05-11 9:23 ` Jun Li
2021-05-11 9:26 ` Felipe Balbi
2021-08-02 5:29 ` Jun Li
2021-08-02 7:49 ` Felipe Balbi
2021-08-02 10:43 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735v8ji31.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.