All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] download/git: fix formatting of error message
@ 2019-06-19 15:05 John Keeping
  2019-06-20 16:15 ` Thomas Petazzoni
  2019-06-24 19:12 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: John Keeping @ 2019-06-19 15:05 UTC (permalink / raw)
  To: buildroot

'.' should be at the end of the sentence, not the beginning of a new
line.

Signed-off-by: John Keeping <john@metanate.com>
Cc: Yann E. MORIN <yann.morin.1998@free.fr>
---
 support/download/git | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/download/git b/support/download/git
index 17ca04eb98..075f665bbf 100755
--- a/support/download/git
+++ b/support/download/git
@@ -130,7 +130,7 @@ fi
 # scratch won't help, so we don't want to trash the repository for a
 # missing commit. We just exit without going through the ERR trap.
 if ! _git rev-parse --quiet --verify "'${cset}^{commit}'" >/dev/null 2>&1; then
-    printf "Commit '%s' does not exist in this repository\n." "${cset}"
+    printf "Commit '%s' does not exist in this repository.\n" "${cset}"
     exit 1
 fi
 
-- 
2.22.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] download/git: fix formatting of error message
  2019-06-19 15:05 [Buildroot] [PATCH] download/git: fix formatting of error message John Keeping
@ 2019-06-20 16:15 ` Thomas Petazzoni
  2019-06-24 19:12 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-06-20 16:15 UTC (permalink / raw)
  To: buildroot

On Wed, 19 Jun 2019 16:05:26 +0100
John Keeping <john@metanate.com> wrote:

> '.' should be at the end of the sentence, not the beginning of a new
> line.
> 
> Signed-off-by: John Keeping <john@metanate.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
>  support/download/git | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] download/git: fix formatting of error message
  2019-06-19 15:05 [Buildroot] [PATCH] download/git: fix formatting of error message John Keeping
  2019-06-20 16:15 ` Thomas Petazzoni
@ 2019-06-24 19:12 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-06-24 19:12 UTC (permalink / raw)
  To: buildroot

>>>>> "John" == John Keeping <john@metanate.com> writes:

 > '.' should be at the end of the sentence, not the beginning of a new
 > line.

 > Signed-off-by: John Keeping <john@metanate.com>
 > Cc: Yann E. MORIN <yann.morin.1998@free.fr>

Committed to 2019.02.x and 2019.05.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-24 19:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 15:05 [Buildroot] [PATCH] download/git: fix formatting of error message John Keeping
2019-06-20 16:15 ` Thomas Petazzoni
2019-06-24 19:12 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.