[Buildroot] [PATCH 1/1] ncmpc: fix build with ncursesw

[Buildroot] [PATCH 1/1] ncmpc: fix build with ncursesw

[Fabrice Fontaine]

Set curses to ncurses as ncurses and ncursesw are the same package in
buildroot. Otherwise, build will fail when trying to find
ncursesw/curses.h or ncursesw.h.

Fixes:
 - http://autobuild.buildroot.net/results/c5bb5f978602896179ff9c58ecf4ced40bb96b57

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ncmpc/ncmpc.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/ncmpc/ncmpc.mk b/package/ncmpc/ncmpc.mk
index 0c9dfd4658..6bce627562 100644
--- a/package/ncmpc/ncmpc.mk
+++ b/package/ncmpc/ncmpc.mk
@@ -14,6 +14,7 @@ NCMPC_LICENSE_FILES = COPYING
 
 NCMPC_CONF_OPTS += \
 	--prefix=/usr \
+	-Dcurses=ncurses \
 	--buildtype $(if $(BR2_ENABLE_DEBUG),debug,release) \
 	--cross-file $(HOST_DIR)/etc/meson/cross-compilation.conf
 
-- 
2.14.1

[Buildroot] [PATCH 1/1] ncmpc: fix build with ncursesw

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Set curses to ncurses as ncurses and ncursesw are the same package in
 > buildroot. Otherwise, build will fail when trying to find
 > ncursesw/curses.h or ncursesw.h.

Thanks. I don't find this commit message very clear, so I've rewritten
it to this and committed:

When ncurses is built with wide support, we install libncursesw (plus a
libncurses symlink) but NOT ncursesw.h, only ncurses.h.  This combination
confuses the ncmpc build system as it expects a ncursesw.h when it finds
libncursesw:

meson.build:92:4: ERROR: Problem encountered: No ncursesw header found

The ncurses/ncursesw logic in the build system is only used to know what
header file to #include, and what library to link with.  As we already
provide a libncurses symlink when building with wide support we can simply
force ncmpc to use the ncurses variant.

-- 
Bye, Peter Korsgaard