* [PATCH] powerpc: fix distclean with Makefile.postlink
@ 2017-05-08 8:50 Horia Geantă
2017-05-08 11:57 ` Michael Ellerman
2017-05-15 5:06 ` Michael Ellerman
0 siblings, 2 replies; 8+ messages in thread
From: Horia Geantă @ 2017-05-08 8:50 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
Cc: Nicholas Piggin, Mircea Pop, linuxppc-dev, linux-kernel
Makefile.postlink always includes include/config/auto.conf, however
this file is not present in a clean kernel tree, causing make to fail:
arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
make[1]: *** No rule to make target `include/config/auto.conf'. Stop.
make: *** [vmlinuxclean] Error 2
Change the inclusion such that file not being found does not trigger
an error.
Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")
Reported-by: Mircea Pop <mircea.pop@nxp.com>
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
---
arch/powerpc/Makefile.postlink | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/Makefile.postlink b/arch/powerpc/Makefile.postlink
index 3c22d64b2de9..eccfcc88afae 100644
--- a/arch/powerpc/Makefile.postlink
+++ b/arch/powerpc/Makefile.postlink
@@ -7,7 +7,7 @@
PHONY := __archpost
__archpost:
-include include/config/auto.conf
+-include include/config/auto.conf
include scripts/Kbuild.include
quiet_cmd_relocs_check = CHKREL $@
--
2.12.0.264.gd6db3f216544
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc: fix distclean with Makefile.postlink
2017-05-08 8:50 [PATCH] powerpc: fix distclean with Makefile.postlink Horia Geantă
@ 2017-05-08 11:57 ` Michael Ellerman
2017-05-15 5:06 ` Michael Ellerman
1 sibling, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2017-05-08 11:57 UTC (permalink / raw)
To: Horia Geantă, Benjamin Herrenschmidt, Paul Mackerras
Cc: Nicholas Piggin, Mircea Pop, linuxppc-dev, linux-kernel
Horia Geantă <horia.geanta@nxp.com> writes:
> Makefile.postlink always includes include/config/auto.conf, however
> this file is not present in a clean kernel tree, causing make to fail:
>
> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
> make[1]: *** No rule to make target `include/config/auto.conf'. Stop.
> make: *** [vmlinuxclean] Error 2
>
> Change the inclusion such that file not being found does not trigger
> an error.
>
> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")
I can't reproduce this. What exact steps are you doing? And what version
of Make?
cheers
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc: fix distclean with Makefile.postlink
@ 2017-05-08 11:57 ` Michael Ellerman
0 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2017-05-08 11:57 UTC (permalink / raw)
To: Horia Geantă, Benjamin Herrenschmidt, Paul Mackerras
Cc: Nicholas Piggin, Mircea Pop, linuxppc-dev, linux-kernel
Horia Geant=C4=83 <horia.geanta@nxp.com> writes:
> Makefile.postlink always includes include/config/auto.conf, however
> this file is not present in a clean kernel tree, causing make to fail:
>
> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file=
or directory
> make[1]: *** No rule to make target `include/config/auto.conf'. Stop.
> make: *** [vmlinuxclean] Error 2
>
> Change the inclusion such that file not being found does not trigger
> an error.
>
> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check reloca=
tions")
I can't reproduce this. What exact steps are you doing? And what version
of Make?
cheers
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc: fix distclean with Makefile.postlink
2017-05-08 11:57 ` Michael Ellerman
@ 2017-05-08 13:50 ` Horia Geantă
-1 siblings, 0 replies; 8+ messages in thread
From: Horia Geantă @ 2017-05-08 13:50 UTC (permalink / raw)
To: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras
Cc: Nicholas Piggin, Mircea Pop, linuxppc-dev, linux-kernel
On 5/8/2017 2:57 PM, Michael Ellerman wrote:
> Horia Geantă <horia.geanta@nxp.com> writes:
>
>> Makefile.postlink always includes include/config/auto.conf, however
>> this file is not present in a clean kernel tree, causing make to fail:
>>
>> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
>> make[1]: *** No rule to make target `include/config/auto.conf'. Stop.
>> make: *** [vmlinuxclean] Error 2
>>
>> Change the inclusion such that file not being found does not trigger
>> an error.
>>
>> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")
>
> I can't reproduce this. What exact steps are you doing? And what version
> of Make?
>
Start with a clean kernel tree and then
make distclean
arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such
file or directory
make[1]: *** No rule to make target `include/config/auto.conf'. Stop.
make: *** [vmlinuxclean] Error 2
make --version
GNU Make 3.82
Built for x86_64-redhat-linux-gnu
Copyright (C) 2010 Free Software Foundation, Inc.
[...]
The fix is basically the same as:
6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink
Regards,
Horia
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc: fix distclean with Makefile.postlink
@ 2017-05-08 13:50 ` Horia Geantă
0 siblings, 0 replies; 8+ messages in thread
From: Horia Geantă @ 2017-05-08 13:50 UTC (permalink / raw)
To: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras
Cc: Nicholas Piggin, Mircea Pop, linuxppc-dev, linux-kernel
On 5/8/2017 2:57 PM, Michael Ellerman wrote:=0A=
> Horia Geant=E3 <horia.geanta@nxp.com> writes:=0A=
> =0A=
>> Makefile.postlink always includes include/config/auto.conf, however=0A=
>> this file is not present in a clean kernel tree, causing make to fail:=
=0A=
>>=0A=
>> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such fil=
e or directory=0A=
>> make[1]: *** No rule to make target `include/config/auto.conf'. Stop.=
=0A=
>> make: *** [vmlinuxclean] Error 2=0A=
>>=0A=
>> Change the inclusion such that file not being found does not trigger=0A=
>> an error.=0A=
>>=0A=
>> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check reloc=
ations")=0A=
> =0A=
> I can't reproduce this. What exact steps are you doing? And what version=
=0A=
> of Make?=0A=
> =0A=
Start with a clean kernel tree and then=0A=
make distclean=0A=
arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such=0A=
file or directory=0A=
make[1]: *** No rule to make target `include/config/auto.conf'. Stop.=0A=
make: *** [vmlinuxclean] Error 2=0A=
=0A=
make --version=0A=
GNU Make 3.82=0A=
Built for x86_64-redhat-linux-gnu=0A=
Copyright (C) 2010 Free Software Foundation, Inc.=0A=
[...]=0A=
=0A=
The fix is basically the same as:=0A=
6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink=0A=
=0A=
Regards,=0A=
Horia=0A=
=0A=
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc: fix distclean with Makefile.postlink
2017-05-08 13:50 ` Horia Geantă
@ 2017-05-08 21:35 ` Justin Forbes
-1 siblings, 0 replies; 8+ messages in thread
From: Justin Forbes @ 2017-05-08 21:35 UTC (permalink / raw)
To: Horia Geantă
Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
Nicholas Piggin, Mircea Pop, linuxppc-dev, linux-kernel
On Mon, May 8, 2017 at 8:50 AM, Horia Geantă <horia.geanta@nxp.com> wrote:
> On 5/8/2017 2:57 PM, Michael Ellerman wrote:
>> Horia Geantă <horia.geanta@nxp.com> writes:
>>
>>> Makefile.postlink always includes include/config/auto.conf, however
>>> this file is not present in a clean kernel tree, causing make to fail:
>>>
>>> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
>>> make[1]: *** No rule to make target `include/config/auto.conf'. Stop.
>>> make: *** [vmlinuxclean] Error 2
>>>
>>> Change the inclusion such that file not being found does not trigger
>>> an error.
>>>
>>> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")
>>
>> I can't reproduce this. What exact steps are you doing? And what version
>> of Make?
>>
> Start with a clean kernel tree and then
> make distclean
> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such
> file or directory
> make[1]: *** No rule to make target `include/config/auto.conf'. Stop.
> make: *** [vmlinuxclean] Error 2
>
> make --version
> GNU Make 3.82
> Built for x86_64-redhat-linux-gnu
> Copyright (C) 2010 Free Software Foundation, Inc.
> [...]
>
> The fix is basically the same as:
> 6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink
>
Noticed it on the Fedora builds as well today. This patch fixes it.
Tested-by: Justin M. Forbes <jforbes@fedoraproject.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc: fix distclean with Makefile.postlink
@ 2017-05-08 21:35 ` Justin Forbes
0 siblings, 0 replies; 8+ messages in thread
From: Justin Forbes @ 2017-05-08 21:35 UTC (permalink / raw)
To: Horia Geantă
Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
Nicholas Piggin, Mircea Pop, linuxppc-dev, linux-kernel
On Mon, May 8, 2017 at 8:50 AM, Horia Geant=C4=83 <horia.geanta@nxp.com> wr=
ote:
> On 5/8/2017 2:57 PM, Michael Ellerman wrote:
>> Horia Geant=C4=83 <horia.geanta@nxp.com> writes:
>>
>>> Makefile.postlink always includes include/config/auto.conf, however
>>> this file is not present in a clean kernel tree, causing make to fail:
>>>
>>> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such fi=
le or directory
>>> make[1]: *** No rule to make target `include/config/auto.conf'. Stop.
>>> make: *** [vmlinuxclean] Error 2
>>>
>>> Change the inclusion such that file not being found does not trigger
>>> an error.
>>>
>>> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relo=
cations")
>>
>> I can't reproduce this. What exact steps are you doing? And what version
>> of Make?
>>
> Start with a clean kernel tree and then
> make distclean
> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such
> file or directory
> make[1]: *** No rule to make target `include/config/auto.conf'. Stop.
> make: *** [vmlinuxclean] Error 2
>
> make --version
> GNU Make 3.82
> Built for x86_64-redhat-linux-gnu
> Copyright (C) 2010 Free Software Foundation, Inc.
> [...]
>
> The fix is basically the same as:
> 6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink
>
Noticed it on the Fedora builds as well today. This patch fixes it.
Tested-by: Justin M. Forbes <jforbes@fedoraproject.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: powerpc: fix distclean with Makefile.postlink
2017-05-08 8:50 [PATCH] powerpc: fix distclean with Makefile.postlink Horia Geantă
2017-05-08 11:57 ` Michael Ellerman
@ 2017-05-15 5:06 ` Michael Ellerman
1 sibling, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2017-05-15 5:06 UTC (permalink / raw)
To: Horia Geantă, Benjamin Herrenschmidt, Paul Mackerras
Cc: linuxppc-dev, linux-kernel, Nicholas Piggin, Mircea Pop
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On Mon, 2017-05-08 at 08:50:16 UTC, =?utf-8?q?Horia_Geant=C4=83?= wrote:
> Makefile.postlink always includes include/config/auto.conf, however
> this file is not present in a clean kernel tree, causing make to fail:
>
> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
> make[1]: *** No rule to make target `include/config/auto.conf'. Stop.
> make: *** [vmlinuxclean] Error 2
>
> Change the inclusion such that file not being found does not trigger
> an error.
>
> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")
> Reported-by: Mircea Pop <mircea.pop@nxp.com>
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> Tested-by: Justin M. Forbes <jforbes@fedoraproject.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/24e0bfbf63bac18495b0ad76115269
cheers
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-05-15 5:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-08 8:50 [PATCH] powerpc: fix distclean with Makefile.postlink Horia Geantă
2017-05-08 11:57 ` Michael Ellerman
2017-05-08 11:57 ` Michael Ellerman
2017-05-08 13:50 ` Horia Geantă
2017-05-08 13:50 ` Horia Geantă
2017-05-08 21:35 ` Justin Forbes
2017-05-08 21:35 ` Justin Forbes
2017-05-15 5:06 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.