* [PATCH 09/11] f2fs: Remove __GFP_NOFAIL flag from call to mempool_alloc()
@ 2017-04-10 2:17 NeilBrown
0 siblings, 0 replies; only message in thread
From: NeilBrown @ 2017-04-10 2:17 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu; +Cc: linux-f2fs-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
Passing __GFP_NOFAIL to mempool_alloc() is strange
because it bypasses the pool functionality provided
by the mempool. mempool_alloc() will not fail
even without the NOFAIL flag.
So remove the flag and allow the pool to be used properly.
Signed-off-by: NeilBrown <neilb@suse.com>
---
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 1602b4bccae6..7e31751ec708 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -204,7 +204,7 @@ static inline void __submit_bio(struct f2fs_sb_info *sbi,
for (; start < F2FS_IO_SIZE(sbi); start++) {
struct page *page =
mempool_alloc(sbi->write_io_dummy,
- GFP_NOIO | __GFP_ZERO | __GFP_NOFAIL);
+ GFP_NOIO | __GFP_ZERO);
f2fs_bug_on(sbi, !page);
SetPagePrivate(page);
--
2.12.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-04-10 2:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-10 2:17 [PATCH 09/11] f2fs: Remove __GFP_NOFAIL flag from call to mempool_alloc() NeilBrown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.