All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] fs/skeleton: allow rootfs not to be remounted read-write
@ 2011-07-03 10:56 Luca Ceresoli
  2011-07-04 20:25 ` Diego Iastrubni
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Luca Ceresoli @ 2011-07-03 10:56 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 fs/skeleton/etc/inittab    |    2 +-
 package/sysvinit/inittab   |    2 +-
 target/generic/Config.in   |   11 +++++++++++
 target/generic/Makefile.in |   13 +++++++++++++
 4 files changed, 26 insertions(+), 2 deletions(-)

diff --git a/fs/skeleton/etc/inittab b/fs/skeleton/etc/inittab
index b1e5c16..47ab8e8 100644
--- a/fs/skeleton/etc/inittab
+++ b/fs/skeleton/etc/inittab
@@ -15,7 +15,7 @@
 
 # Startup the system
 null::sysinit:/bin/mount -t proc proc /proc
-null::sysinit:/bin/mount -o remount,rw /
+null::sysinit:/bin/mount -o remount,rw / # REMOUNT_ROOTFS_RW
 null::sysinit:/bin/mkdir -p /dev/pts
 null::sysinit:/bin/mount -a
 null::sysinit:/bin/hostname -F /etc/hostname
diff --git a/package/sysvinit/inittab b/package/sysvinit/inittab
index a4bcf82..afa0dc3 100644
--- a/package/sysvinit/inittab
+++ b/package/sysvinit/inittab
@@ -5,7 +5,7 @@
 id:1:initdefault:
 
 proc::sysinit:/bin/mount -t proc proc /proc
-rwmo::sysinit:/bin/mount -o remount,rw /
+rwmo::sysinit:/bin/mount -o remount,rw / # REMOUNT_ROOTFS_RW
 dpts::sysinit:/bin/mkdir -p /dev/pts
 moun::sysinit:/bin/mount -a
 host::sysinit:/bin/hostname -F /etc/hostname
diff --git a/target/generic/Config.in b/target/generic/Config.in
index 4969fcd..716f428 100644
--- a/target/generic/Config.in
+++ b/target/generic/Config.in
@@ -109,6 +109,17 @@ config BR2_TARGET_GENERIC_GETTY_BAUDRATE
 	default "57600"		if BR2_TARGET_GENERIC_GETTY_BAUDRATE_57600
 	default "115200"	if BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200
 
+config BR2_REMOUNT_ROOTFS_RW
+	bool "remount root filesystem read-write during boot"
+	default y
+	help
+	  The root filesystem is typically mounted read-only at boot.
+	  By default, buildroot remounts it in read-write mode early during the
+	  boot process.
+	  Say no here if you would rather like your root filesystem to remain
+	  read-only.
+	  If unsure, say Y.
+
 endif # BR2_ROOTFS_SKELETON_DEFAULT
 
 config BR2_ROOTFS_POST_BUILD_SCRIPT
diff --git a/target/generic/Makefile.in b/target/generic/Makefile.in
index ce07ecf..d945f4c 100644
--- a/target/generic/Makefile.in
+++ b/target/generic/Makefile.in
@@ -23,6 +23,14 @@ target-generic-getty-sysvinit:
 	$(SED) '/# GENERIC_SERIAL$$/s~^.*#~$(shell echo $(TARGET_GENERIC_GETTY) | tail -c+4)::respawn:/sbin/getty -L $(TARGET_GENERIC_GETTY) $(TARGET_GENERIC_GETTY_BAUDRATE) vt100 #~' \
 		$(TARGET_DIR)/etc/inittab
 
+# Find commented line, if any, and remove leading '#'s
+target-generic-do-remount-rw:
+	$(SED) '/^#.*# REMOUNT_ROOTFS_RW$$/s~^#\+~~' $(TARGET_DIR)/etc/inittab
+
+# Find uncommented line, if any, and add a leading '#'
+target-generic-dont-remount-rw:
+	$(SED) '/^[^#].*# REMOUNT_ROOTFS_RW$$/s~^~#~' $(TARGET_DIR)/etc/inittab
+
 ifneq ($(TARGET_GENERIC_HOSTNAME),)
 TARGETS += target-generic-hostname
 endif
@@ -37,4 +45,9 @@ TARGETS += target-generic-getty-sysvinit
 else
 TARGETS += target-generic-getty-busybox
 endif
+ifeq ($(BR2_REMOUNT_ROOTFS_RW),y)
+TARGETS += target-generic-do-remount-rw
+else
+TARGETS += target-generic-dont-remount-rw
+endif
 endif
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] fs/skeleton: allow rootfs not to be remounted read-write
  2011-07-03 10:56 [Buildroot] [PATCH] fs/skeleton: allow rootfs not to be remounted read-write Luca Ceresoli
@ 2011-07-04 20:25 ` Diego Iastrubni
  2011-07-05 20:33   ` Luca Ceresoli
  2011-07-05 20:25 ` Thomas Petazzoni
  2011-07-10 20:45 ` Peter Korsgaard
  2 siblings, 1 reply; 5+ messages in thread
From: Diego Iastrubni @ 2011-07-04 20:25 UTC (permalink / raw)
  To: buildroot

On Sun, Jul 3, 2011 at 1:56 PM, Luca Ceresoli <luca@lucaceresoli.net> wrote:
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
  +config BR2_REMOUNT_ROOTFS_RW
+       bool "remount root filesystem read-write during boot"
+       default y
+       help
+         The root filesystem is typically mounted read-only at boot.
+         By default, buildroot remounts it in read-write mode early during
the
+         boot process.
+         Say no here if you would rather like your root filesystem to
remain
+         read-only.
+         If unsure, say Y.
+
 endif # BR2_ROOTFS_SKELETON_DEFAULT


Wait... nothing breaks...? this just works?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20110704/c2e09c1e/attachment.html>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] fs/skeleton: allow rootfs not to be remounted read-write
  2011-07-03 10:56 [Buildroot] [PATCH] fs/skeleton: allow rootfs not to be remounted read-write Luca Ceresoli
  2011-07-04 20:25 ` Diego Iastrubni
@ 2011-07-05 20:25 ` Thomas Petazzoni
  2011-07-10 20:45 ` Peter Korsgaard
  2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2011-07-05 20:25 UTC (permalink / raw)
  To: buildroot

Le Sun,  3 Jul 2011 12:56:03 +0200,
Luca Ceresoli <luca@lucaceresoli.net> a ?crit :

> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] fs/skeleton: allow rootfs not to be remounted read-write
  2011-07-04 20:25 ` Diego Iastrubni
@ 2011-07-05 20:33   ` Luca Ceresoli
  0 siblings, 0 replies; 5+ messages in thread
From: Luca Ceresoli @ 2011-07-05 20:33 UTC (permalink / raw)
  To: buildroot

Hi Diego,

Diego Iastrubni wrote:
> On Sun, Jul 3, 2011 at 1:56 PM, Luca Ceresoli <luca@lucaceresoli.net 
> <mailto:luca@lucaceresoli.net>> wrote:
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net 
> <mailto:luca@lucaceresoli.net>>
>   +config BR2_REMOUNT_ROOTFS_RW
> +       bool "remount root filesystem read-write during boot"
> +       default y
> +       help
> +         The root filesystem is typically mounted read-only at boot.
> +         By default, buildroot remounts it in read-write mode early 
> during the
> +         boot process.
> +         Say no here if you would rather like your root filesystem to 
> remain
> +         read-only.
> +         If unsure, say Y.
> +
>  endif # BR2_ROOTFS_SKELETON_DEFAULT
>
>
> Wait... nothing breaks...? this just works?

It does not break anything.

If the new BR2_REMOUNT_ROOTFS_RW option is left at its default value (y),
then the generated filesystem does the same thing it used to do in the past.

If you disable it, BR will simply comment out the "mount -o remount,rw /"
line in /etc/inittab, thus the rootfs will stay read-only.

It works quite well, unless your apps need to write the rootfs.
I use it since >1 year without problems.

The only issue I notice is that the random seed cannot be saved on shutdown.
But this is a no-issue on those embedded devices that can be shut down only
by removing power: these will never see a clean shutdown.

Luca

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] fs/skeleton: allow rootfs not to be remounted read-write
  2011-07-03 10:56 [Buildroot] [PATCH] fs/skeleton: allow rootfs not to be remounted read-write Luca Ceresoli
  2011-07-04 20:25 ` Diego Iastrubni
  2011-07-05 20:25 ` Thomas Petazzoni
@ 2011-07-10 20:45 ` Peter Korsgaard
  2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2011-07-10 20:45 UTC (permalink / raw)
  To: buildroot

>>>>> "Luca" == Luca Ceresoli <luca@lucaceresoli.net> writes:

 Luca> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Committed with minor edit, thanks.

 Luca> +config BR2_REMOUNT_ROOTFS_RW

The other options are prefixed with TARGET_GENERIC, so I renamed it to
BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-07-10 20:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-03 10:56 [Buildroot] [PATCH] fs/skeleton: allow rootfs not to be remounted read-write Luca Ceresoli
2011-07-04 20:25 ` Diego Iastrubni
2011-07-05 20:33   ` Luca Ceresoli
2011-07-05 20:25 ` Thomas Petazzoni
2011-07-10 20:45 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.