All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Gonglei <arei.gonglei@huawei.com>,
	virtualization@lists.linux-foundation.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: herbert@gondor.apana.org.au, mst@redhat.com
Subject: Re: [PATCH] virtio-crypto: adjust priority of algorithm
Date: Fri, 13 Jan 2017 09:28:29 +0100	[thread overview]
Message-ID: <874ee338-4dd6-8a2c-fb95-59bd784de026@de.ibm.com> (raw)
In-Reply-To: <1484288741-31100-1-git-send-email-arei.gonglei@huawei.com>

ACK. Whoever takes this patch might want to fixup 3 typos.

On 01/13/2017 07:25 AM, Gonglei wrote:

> Some hardware accelerators (like intel aseni or the s390
					aesni
> cpacf functions) have lower priorities than virtio
> crypto, and those drivers are faster than the same in
> the host via virtio. So let's lower the priority of
> virtio-crypto's algorithm, make it's higher than sofeware
                                                   software
> implimentations but lower than the hardware ones.
  implementations
> 
> Suggested-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  drivers/crypto/virtio/virtio_crypto_algs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c
> index 6f40a42..4de4740 100644
> --- a/drivers/crypto/virtio/virtio_crypto_algs.c
> +++ b/drivers/crypto/virtio/virtio_crypto_algs.c
> @@ -498,7 +498,7 @@ void virtio_crypto_ablkcipher_finalize_req(
>  static struct crypto_alg virtio_crypto_algs[] = { {
>  	.cra_name = "cbc(aes)",
>  	.cra_driver_name = "virtio_crypto_aes_cbc",
> -	.cra_priority = 501,
> +	.cra_priority = 150,
>  	.cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | CRYPTO_ALG_ASYNC,
>  	.cra_blocksize = AES_BLOCK_SIZE,
>  	.cra_ctxsize  = sizeof(struct virtio_crypto_ablkcipher_ctx),
> 

WARNING: multiple messages have this Message-ID (diff)
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Gonglei <arei.gonglei@huawei.com>,
	virtualization@lists.linux-foundation.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: mst@redhat.com, herbert@gondor.apana.org.au
Subject: Re: [PATCH] virtio-crypto: adjust priority of algorithm
Date: Fri, 13 Jan 2017 09:28:29 +0100	[thread overview]
Message-ID: <874ee338-4dd6-8a2c-fb95-59bd784de026@de.ibm.com> (raw)
In-Reply-To: <1484288741-31100-1-git-send-email-arei.gonglei@huawei.com>

ACK. Whoever takes this patch might want to fixup 3 typos.

On 01/13/2017 07:25 AM, Gonglei wrote:

> Some hardware accelerators (like intel aseni or the s390
					aesni
> cpacf functions) have lower priorities than virtio
> crypto, and those drivers are faster than the same in
> the host via virtio. So let's lower the priority of
> virtio-crypto's algorithm, make it's higher than sofeware
                                                   software
> implimentations but lower than the hardware ones.
  implementations
> 
> Suggested-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  drivers/crypto/virtio/virtio_crypto_algs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c
> index 6f40a42..4de4740 100644
> --- a/drivers/crypto/virtio/virtio_crypto_algs.c
> +++ b/drivers/crypto/virtio/virtio_crypto_algs.c
> @@ -498,7 +498,7 @@ void virtio_crypto_ablkcipher_finalize_req(
>  static struct crypto_alg virtio_crypto_algs[] = { {
>  	.cra_name = "cbc(aes)",
>  	.cra_driver_name = "virtio_crypto_aes_cbc",
> -	.cra_priority = 501,
> +	.cra_priority = 150,
>  	.cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | CRYPTO_ALG_ASYNC,
>  	.cra_blocksize = AES_BLOCK_SIZE,
>  	.cra_ctxsize  = sizeof(struct virtio_crypto_ablkcipher_ctx),
> 

  reply	other threads:[~2017-01-13  8:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  6:25 [PATCH] virtio-crypto: adjust priority of algorithm Gonglei
2017-01-13  8:28 ` Christian Borntraeger [this message]
2017-01-13  8:28   ` Christian Borntraeger
2017-01-13  9:24   ` Gonglei (Arei)
2017-01-13  9:24     ` Gonglei (Arei)
2017-01-13  6:25 Gonglei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ee338-4dd6-8a2c-fb95-59bd784de026@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=arei.gonglei@huawei.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.