All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/rtl8192eu: fix build failure on Big Endian architectures
@ 2022-12-13 20:32 Giulio Benetti
  2022-12-13 20:35 ` Giulio Benetti
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Giulio Benetti @ 2022-12-13 20:32 UTC (permalink / raw)
  To: buildroot; +Cc: James Hilliard, Giulio Benetti

Let's disable the CONFIG_PLATFORM_I386_PC that is set to y by default
involving the endianness to be set to little. This way we can set the
CFLAGS according to architecture with some default define like:
-DCONFIG_IOCTL_CFG80211
-DRTW_USE_CFG80211_STA_EVENT
-Wno-error

Suggested-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/rtl8192eu/rtl8192eu.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/package/rtl8192eu/rtl8192eu.mk b/package/rtl8192eu/rtl8192eu.mk
index e1688eef1b..d967db90b8 100644
--- a/package/rtl8192eu/rtl8192eu.mk
+++ b/package/rtl8192eu/rtl8192eu.mk
@@ -7,9 +7,16 @@
 RTL8192EU_VERSION = 94bce7798bbb18de6d8b1646dedb2511f24867d3
 RTL8192EU_SITE = $(call github,clnhub,rtl8192eu-linux,$(RTL8192EU_VERSION))
 RTL8192EU_LICENSE = GPL-2.0
+
+RTL8192EU_USER_EXTRA_CFLAGS = -DCONFIG_$(call qstrip,$(BR2_ENDIAN))_ENDIAN \
+			      -DCONFIG_IOCTL_CFG80211 \
+			      -DRTW_USE_CFG80211_STA_EVENT \
+			      -Wno-error
+
 RTL8192EU_MODULE_MAKE_OPTS = \
+	CONFIG_PLATFORM_I386_PC=n \
 	CONFIG_RTL8192EU=m \
-	USER_EXTRA_CFLAGS="-Wno-error"
+	USER_EXTRA_CFLAGS="$(RTL8192EU_USER_EXTRA_CFLAGS)"
 
 define RTL8192EU_LINUX_CONFIG_FIXUPS
 	$(call KCONFIG_ENABLE_OPT,CONFIG_NET)
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v2] package/rtl8192eu: fix build failure on Big Endian architectures
  2022-12-13 20:32 [Buildroot] [PATCH v2] package/rtl8192eu: fix build failure on Big Endian architectures Giulio Benetti
@ 2022-12-13 20:35 ` Giulio Benetti
  2022-12-20  7:23 ` Peter Korsgaard
  2022-12-21 18:08 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Giulio Benetti @ 2022-12-13 20:35 UTC (permalink / raw)
  To: buildroot; +Cc: James Hilliard

On 13/12/22 21:32, Giulio Benetti wrote:
> Let's disable the CONFIG_PLATFORM_I386_PC that is set to y by default
> involving the endianness to be set to little. This way we can set the
> CFLAGS according to architecture with some default define like:
> -DCONFIG_IOCTL_CFG80211
> -DRTW_USE_CFG80211_STA_EVENT
> -Wno-error

Fixes:
http://autobuild.buildroot.net/results/13a/13a809570423ead33628663033db4c3c4001a79b/

> Suggested-by: Arnout Vandecappelle <arnout@mind.be>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   package/rtl8192eu/rtl8192eu.mk | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/package/rtl8192eu/rtl8192eu.mk b/package/rtl8192eu/rtl8192eu.mk
> index e1688eef1b..d967db90b8 100644
> --- a/package/rtl8192eu/rtl8192eu.mk
> +++ b/package/rtl8192eu/rtl8192eu.mk
> @@ -7,9 +7,16 @@
>   RTL8192EU_VERSION = 94bce7798bbb18de6d8b1646dedb2511f24867d3
>   RTL8192EU_SITE = $(call github,clnhub,rtl8192eu-linux,$(RTL8192EU_VERSION))
>   RTL8192EU_LICENSE = GPL-2.0
> +
> +RTL8192EU_USER_EXTRA_CFLAGS = -DCONFIG_$(call qstrip,$(BR2_ENDIAN))_ENDIAN \
> +			      -DCONFIG_IOCTL_CFG80211 \
> +			      -DRTW_USE_CFG80211_STA_EVENT \
> +			      -Wno-error
> +
>   RTL8192EU_MODULE_MAKE_OPTS = \
> +	CONFIG_PLATFORM_I386_PC=n \
>   	CONFIG_RTL8192EU=m \
> -	USER_EXTRA_CFLAGS="-Wno-error"
> +	USER_EXTRA_CFLAGS="$(RTL8192EU_USER_EXTRA_CFLAGS)"
>   
>   define RTL8192EU_LINUX_CONFIG_FIXUPS
>   	$(call KCONFIG_ENABLE_OPT,CONFIG_NET)

-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v2] package/rtl8192eu: fix build failure on Big Endian architectures
  2022-12-13 20:32 [Buildroot] [PATCH v2] package/rtl8192eu: fix build failure on Big Endian architectures Giulio Benetti
  2022-12-13 20:35 ` Giulio Benetti
@ 2022-12-20  7:23 ` Peter Korsgaard
  2022-12-21 18:08 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-12-20  7:23 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: James Hilliard, buildroot

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > Let's disable the CONFIG_PLATFORM_I386_PC that is set to y by default
 > involving the endianness to be set to little. This way we can set the
 > CFLAGS according to architecture with some default define like:
 > -DCONFIG_IOCTL_CFG80211
 > -DRTW_USE_CFG80211_STA_EVENT
 > -Wno-error

 > Suggested-by: Arnout Vandecappelle <arnout@mind.be>
 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v2] package/rtl8192eu: fix build failure on Big Endian architectures
  2022-12-13 20:32 [Buildroot] [PATCH v2] package/rtl8192eu: fix build failure on Big Endian architectures Giulio Benetti
  2022-12-13 20:35 ` Giulio Benetti
  2022-12-20  7:23 ` Peter Korsgaard
@ 2022-12-21 18:08 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-12-21 18:08 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: James Hilliard, buildroot

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > Let's disable the CONFIG_PLATFORM_I386_PC that is set to y by default
 > involving the endianness to be set to little. This way we can set the
 > CFLAGS according to architecture with some default define like:
 > -DCONFIG_IOCTL_CFG80211
 > -DRTW_USE_CFG80211_STA_EVENT
 > -Wno-error

 > Suggested-by: Arnout Vandecappelle <arnout@mind.be>
 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2022.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-12-21 18:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-13 20:32 [Buildroot] [PATCH v2] package/rtl8192eu: fix build failure on Big Endian architectures Giulio Benetti
2022-12-13 20:35 ` Giulio Benetti
2022-12-20  7:23 ` Peter Korsgaard
2022-12-21 18:08 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.