* [PATCH 1/1] Fix reserved Feature bits numbering
@ 2021-08-01 12:45 Max Gurtovoy
2021-08-02 14:07 ` Stefan Hajnoczi
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Max Gurtovoy @ 2021-08-01 12:45 UTC (permalink / raw)
To: virtio-comment, mst, cohuck; +Cc: stefanha, eperezma, oren, Max Gurtovoy
This should have been updated during VIRTIO_F_NOTIFICATION_DATA and
VIRTIO_F_NOTIF_CONFIG_DATA standartization.
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
content.tex | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/content.tex b/content.tex
index 5c70a3c..e9a32fa 100644
--- a/content.tex
+++ b/content.tex
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
\begin{description}
\item[0 to 23] Feature bits for the specific device type
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 39] Feature bits reserved for extensions to the queue and
feature negotiation mechanisms
-\item[38 and above] Feature bits reserved for future extensions.
+\item[40 and above] Feature bits reserved for future extensions.
\end{description}
\begin{note}
--
2.21.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-08-01 12:45 [PATCH 1/1] Fix reserved Feature bits numbering Max Gurtovoy @ 2021-08-02 14:07 ` Stefan Hajnoczi 2021-08-10 6:44 ` [virtio-comment] " Cornelia Huck 2022-01-03 11:13 ` Cornelia Huck 2 siblings, 0 replies; 15+ messages in thread From: Stefan Hajnoczi @ 2021-08-02 14:07 UTC (permalink / raw) To: Max Gurtovoy; +Cc: virtio-comment, mst, cohuck, eperezma, oren [-- Attachment #1: Type: text/plain, Size: 377 bytes --] On Sun, Aug 01, 2021 at 03:45:27PM +0300, Max Gurtovoy wrote: > This should have been updated during VIRTIO_F_NOTIFICATION_DATA and > VIRTIO_F_NOTIF_CONFIG_DATA standartization. > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> > --- > content.tex | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-08-01 12:45 [PATCH 1/1] Fix reserved Feature bits numbering Max Gurtovoy 2021-08-02 14:07 ` Stefan Hajnoczi @ 2021-08-10 6:44 ` Cornelia Huck 2021-08-12 10:35 ` Max Gurtovoy 2022-01-03 11:13 ` Cornelia Huck 2 siblings, 1 reply; 15+ messages in thread From: Cornelia Huck @ 2021-08-10 6:44 UTC (permalink / raw) To: Max Gurtovoy, virtio-comment, mst; +Cc: stefanha, eperezma, oren, Max Gurtovoy On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > This should have been updated during VIRTIO_F_NOTIFICATION_DATA and > VIRTIO_F_NOTIF_CONFIG_DATA standartization. > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> > --- > content.tex | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/content.tex b/content.tex > index 5c70a3c..e9a32fa 100644 > --- a/content.tex > +++ b/content.tex > @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B > \begin{description} > \item[0 to 23] Feature bits for the specific device type > > -\item[24 to 37] Feature bits reserved for extensions to the queue and > +\item[24 to 39] Feature bits reserved for extensions to the queue and > feature negotiation mechanisms I'm wondering whether we should do s/reserved/used/ here? > > -\item[38 and above] Feature bits reserved for future extensions. > +\item[40 and above] Feature bits reserved for future extensions. > \end{description} > > \begin{note} This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ ^ permalink raw reply [flat|nested] 15+ messages in thread
* [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-08-10 6:44 ` [virtio-comment] " Cornelia Huck @ 2021-08-12 10:35 ` Max Gurtovoy 2021-08-16 8:48 ` Cornelia Huck 0 siblings, 1 reply; 15+ messages in thread From: Max Gurtovoy @ 2021-08-12 10:35 UTC (permalink / raw) To: Cornelia Huck, virtio-comment, mst; +Cc: stefanha, eperezma, oren On 8/10/2021 9:44 AM, Cornelia Huck wrote: > On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > >> This should have been updated during VIRTIO_F_NOTIFICATION_DATA and >> VIRTIO_F_NOTIF_CONFIG_DATA standartization. >> >> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> >> --- >> content.tex | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/content.tex b/content.tex >> index 5c70a3c..e9a32fa 100644 >> --- a/content.tex >> +++ b/content.tex >> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B >> \begin{description} >> \item[0 to 23] Feature bits for the specific device type >> >> -\item[24 to 37] Feature bits reserved for extensions to the queue and >> +\item[24 to 39] Feature bits reserved for extensions to the queue and >> feature negotiation mechanisms > I'm wondering whether we should do s/reserved/used/ here? I'm just fixing a bug here. You can take this patch and create another one with the above suggestion on top. I'm ok with your suggestion. > >> >> -\item[38 and above] Feature bits reserved for future extensions. >> +\item[40 and above] Feature bits reserved for future extensions. >> \end{description} >> >> \begin{note} This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-08-12 10:35 ` Max Gurtovoy @ 2021-08-16 8:48 ` Cornelia Huck 2021-08-16 14:40 ` Michael S. Tsirkin 0 siblings, 1 reply; 15+ messages in thread From: Cornelia Huck @ 2021-08-16 8:48 UTC (permalink / raw) To: Max Gurtovoy, virtio-comment, mst; +Cc: stefanha, eperezma, oren On Thu, Aug 12 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > On 8/10/2021 9:44 AM, Cornelia Huck wrote: >> On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: >> >>> This should have been updated during VIRTIO_F_NOTIFICATION_DATA and >>> VIRTIO_F_NOTIF_CONFIG_DATA standartization. >>> >>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> >>> --- >>> content.tex | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/content.tex b/content.tex >>> index 5c70a3c..e9a32fa 100644 >>> --- a/content.tex >>> +++ b/content.tex >>> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B >>> \begin{description} >>> \item[0 to 23] Feature bits for the specific device type >>> >>> -\item[24 to 37] Feature bits reserved for extensions to the queue and >>> +\item[24 to 39] Feature bits reserved for extensions to the queue and >>> feature negotiation mechanisms >> I'm wondering whether we should do s/reserved/used/ here? > > I'm just fixing a bug here. You can take this patch and create another > one with the above suggestion on top. > > I'm ok with your suggestion. So... any opinions on whether this should get a proper vote? [I won't be able to handle that in the next weeks. Michael?] > >> >>> >>> -\item[38 and above] Feature bits reserved for future extensions. >>> +\item[40 and above] Feature bits reserved for future extensions. >>> \end{description} >>> >>> \begin{note} This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-08-16 8:48 ` Cornelia Huck @ 2021-08-16 14:40 ` Michael S. Tsirkin 2021-12-30 14:24 ` Max Gurtovoy 0 siblings, 1 reply; 15+ messages in thread From: Michael S. Tsirkin @ 2021-08-16 14:40 UTC (permalink / raw) To: Cornelia Huck; +Cc: Max Gurtovoy, virtio-comment, stefanha, eperezma, oren On Mon, Aug 16, 2021 at 10:48:36AM +0200, Cornelia Huck wrote: > On Thu, Aug 12 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > > > On 8/10/2021 9:44 AM, Cornelia Huck wrote: > >> On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > >> > >>> This should have been updated during VIRTIO_F_NOTIFICATION_DATA and > >>> VIRTIO_F_NOTIF_CONFIG_DATA standartization. > >>> > >>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> > >>> --- > >>> content.tex | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/content.tex b/content.tex > >>> index 5c70a3c..e9a32fa 100644 > >>> --- a/content.tex > >>> +++ b/content.tex > >>> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B > >>> \begin{description} > >>> \item[0 to 23] Feature bits for the specific device type > >>> > >>> -\item[24 to 37] Feature bits reserved for extensions to the queue and > >>> +\item[24 to 39] Feature bits reserved for extensions to the queue and > >>> feature negotiation mechanisms > >> I'm wondering whether we should do s/reserved/used/ here? > > > > I'm just fixing a bug here. You can take this patch and create another > > one with the above suggestion on top. > > > > I'm ok with your suggestion. > > So... any opinions on whether this should get a proper vote? [I won't be > able to handle that in the next weeks. Michael?] Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot. > > > >> > >>> > >>> -\item[38 and above] Feature bits reserved for future extensions. > >>> +\item[40 and above] Feature bits reserved for future extensions. > >>> \end{description} > >>> > >>> \begin{note} ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-08-16 14:40 ` Michael S. Tsirkin @ 2021-12-30 14:24 ` Max Gurtovoy 2021-12-30 14:27 ` Michael S. Tsirkin 0 siblings, 1 reply; 15+ messages in thread From: Max Gurtovoy @ 2021-12-30 14:24 UTC (permalink / raw) To: Michael S. Tsirkin, Cornelia Huck Cc: virtio-comment, stefanha, eperezma, Oren Duer, Parav Pandit Hi MST/Cornelia, Can you please update on the status of this patch ? It's open for few months and I'm wondering if there is something wrong with it ? -----Original Message----- From: Michael S. Tsirkin <mst@redhat.com> Sent: Monday, August 16, 2021 5:40 PM To: Cornelia Huck <cohuck@redhat.com> Cc: Max Gurtovoy <mgurtovoy@nvidia.com>; virtio-comment@lists.oasis-open.org; stefanha@redhat.com; eperezma@redhat.com; Oren Duer <oren@nvidia.com> Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering On Mon, Aug 16, 2021 at 10:48:36AM +0200, Cornelia Huck wrote: > On Thu, Aug 12 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > > > On 8/10/2021 9:44 AM, Cornelia Huck wrote: > >> On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > >> > >>> This should have been updated during VIRTIO_F_NOTIFICATION_DATA > >>> and VIRTIO_F_NOTIF_CONFIG_DATA standartization. > >>> > >>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> > >>> --- > >>> content.tex | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/content.tex b/content.tex index 5c70a3c..e9a32fa > >>> 100644 > >>> --- a/content.tex > >>> +++ b/content.tex > >>> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B > >>> \begin{description} > >>> \item[0 to 23] Feature bits for the specific device type > >>> > >>> -\item[24 to 37] Feature bits reserved for extensions to the queue > >>> and > >>> +\item[24 to 39] Feature bits reserved for extensions to the queue > >>> +and > >>> feature negotiation mechanisms > >> I'm wondering whether we should do s/reserved/used/ here? > > > > I'm just fixing a bug here. You can take this patch and create > > another one with the above suggestion on top. > > > > I'm ok with your suggestion. > > So... any opinions on whether this should get a proper vote? [I won't > be able to handle that in the next weeks. Michael?] Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot. > > > >> > >>> > >>> -\item[38 and above] Feature bits reserved for future extensions. > >>> +\item[40 and above] Feature bits reserved for future extensions. > >>> \end{description} > >>> > >>> \begin{note} This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-12-30 14:24 ` Max Gurtovoy @ 2021-12-30 14:27 ` Michael S. Tsirkin 2021-12-30 14:30 ` Max Gurtovoy 0 siblings, 1 reply; 15+ messages in thread From: Michael S. Tsirkin @ 2021-12-30 14:27 UTC (permalink / raw) To: Max Gurtovoy Cc: Cornelia Huck, virtio-comment, stefanha, eperezma, Oren Duer, Parav Pandit On Thu, Dec 30, 2021 at 02:24:46PM +0000, Max Gurtovoy wrote: > Hi MST/Cornelia, > Can you please update on the status of this patch ? > It's open for few months and I'm wondering if there is something wrong with it ? Hmm. Is there a git issue for this? > > -----Original Message----- > From: Michael S. Tsirkin <mst@redhat.com> > Sent: Monday, August 16, 2021 5:40 PM > To: Cornelia Huck <cohuck@redhat.com> > Cc: Max Gurtovoy <mgurtovoy@nvidia.com>; virtio-comment@lists.oasis-open.org; stefanha@redhat.com; eperezma@redhat.com; Oren Duer <oren@nvidia.com> > Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering > > On Mon, Aug 16, 2021 at 10:48:36AM +0200, Cornelia Huck wrote: > > On Thu, Aug 12 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > > > > > On 8/10/2021 9:44 AM, Cornelia Huck wrote: > > >> On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > > >> > > >>> This should have been updated during VIRTIO_F_NOTIFICATION_DATA > > >>> and VIRTIO_F_NOTIF_CONFIG_DATA standartization. > > >>> > > >>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> > > >>> --- > > >>> content.tex | 4 ++-- > > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > > >>> > > >>> diff --git a/content.tex b/content.tex index 5c70a3c..e9a32fa > > >>> 100644 > > >>> --- a/content.tex > > >>> +++ b/content.tex > > >>> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B > > >>> \begin{description} > > >>> \item[0 to 23] Feature bits for the specific device type > > >>> > > >>> -\item[24 to 37] Feature bits reserved for extensions to the queue > > >>> and > > >>> +\item[24 to 39] Feature bits reserved for extensions to the queue > > >>> +and > > >>> feature negotiation mechanisms > > >> I'm wondering whether we should do s/reserved/used/ here? > > > > > > I'm just fixing a bug here. You can take this patch and create > > > another one with the above suggestion on top. > > > > > > I'm ok with your suggestion. > > > > So... any opinions on whether this should get a proper vote? [I won't > > be able to handle that in the next weeks. Michael?] > > > Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot. > > > > > > >> > > >>> > > >>> -\item[38 and above] Feature bits reserved for future extensions. > > >>> +\item[40 and above] Feature bits reserved for future extensions. > > >>> \end{description} > > >>> > > >>> \begin{note} ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-12-30 14:27 ` Michael S. Tsirkin @ 2021-12-30 14:30 ` Max Gurtovoy 2021-12-30 14:49 ` Michael S. Tsirkin 0 siblings, 1 reply; 15+ messages in thread From: Max Gurtovoy @ 2021-12-30 14:30 UTC (permalink / raw) To: Michael S. Tsirkin Cc: Cornelia Huck, virtio-comment, stefanha, eperezma, Oren Duer, Parav Pandit On 12/30/2021 4:27 PM, Michael S. Tsirkin wrote: > On Thu, Dec 30, 2021 at 02:24:46PM +0000, Max Gurtovoy wrote: >> Hi MST/Cornelia, >> Can you please update on the status of this patch ? >> It's open for few months and I'm wondering if there is something wrong with it ? > Hmm. Is there a git issue for this? Not that I'm aware of. Who should open it ? >> -----Original Message----- >> From: Michael S. Tsirkin <mst@redhat.com> >> Sent: Monday, August 16, 2021 5:40 PM >> To: Cornelia Huck <cohuck@redhat.com> >> Cc: Max Gurtovoy <mgurtovoy@nvidia.com>; virtio-comment@lists.oasis-open.org; stefanha@redhat.com; eperezma@redhat.com; Oren Duer <oren@nvidia.com> >> Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering >> >> On Mon, Aug 16, 2021 at 10:48:36AM +0200, Cornelia Huck wrote: >>> On Thu, Aug 12 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: >>> >>>> On 8/10/2021 9:44 AM, Cornelia Huck wrote: >>>>> On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: >>>>> >>>>>> This should have been updated during VIRTIO_F_NOTIFICATION_DATA >>>>>> and VIRTIO_F_NOTIF_CONFIG_DATA standartization. >>>>>> >>>>>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> >>>>>> --- >>>>>> content.tex | 4 ++-- >>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/content.tex b/content.tex index 5c70a3c..e9a32fa >>>>>> 100644 >>>>>> --- a/content.tex >>>>>> +++ b/content.tex >>>>>> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B >>>>>> \begin{description} >>>>>> \item[0 to 23] Feature bits for the specific device type >>>>>> >>>>>> -\item[24 to 37] Feature bits reserved for extensions to the queue >>>>>> and >>>>>> +\item[24 to 39] Feature bits reserved for extensions to the queue >>>>>> +and >>>>>> feature negotiation mechanisms >>>>> I'm wondering whether we should do s/reserved/used/ here? >>>> I'm just fixing a bug here. You can take this patch and create >>>> another one with the above suggestion on top. >>>> >>>> I'm ok with your suggestion. >>> So... any opinions on whether this should get a proper vote? [I won't >>> be able to handle that in the next weeks. Michael?] >> >> Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot. >> >>>>>> >>>>>> -\item[38 and above] Feature bits reserved for future extensions. >>>>>> +\item[40 and above] Feature bits reserved for future extensions. >>>>>> \end{description} >>>>>> >>>>>> \begin{note} ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-12-30 14:30 ` Max Gurtovoy @ 2021-12-30 14:49 ` Michael S. Tsirkin 2021-12-30 14:57 ` Max Gurtovoy 0 siblings, 1 reply; 15+ messages in thread From: Michael S. Tsirkin @ 2021-12-30 14:49 UTC (permalink / raw) To: Max Gurtovoy Cc: Cornelia Huck, virtio-comment, stefanha, eperezma, Oren Duer, Parav Pandit On Thu, Dec 30, 2021 at 04:30:00PM +0200, Max Gurtovoy wrote: > > On 12/30/2021 4:27 PM, Michael S. Tsirkin wrote: > > On Thu, Dec 30, 2021 at 02:24:46PM +0000, Max Gurtovoy wrote: > > > Hi MST/Cornelia, > > > Can you please update on the status of this patch ? > > > It's open for few months and I'm wondering if there is something wrong with it ? > > Hmm. Is there a git issue for this? > > Not that I'm aware of. Who should open it ? Please do if possible. > > > > -----Original Message----- > > > From: Michael S. Tsirkin <mst@redhat.com> > > > Sent: Monday, August 16, 2021 5:40 PM > > > To: Cornelia Huck <cohuck@redhat.com> > > > Cc: Max Gurtovoy <mgurtovoy@nvidia.com>; virtio-comment@lists.oasis-open.org; stefanha@redhat.com; eperezma@redhat.com; Oren Duer <oren@nvidia.com> > > > Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering > > > > > > On Mon, Aug 16, 2021 at 10:48:36AM +0200, Cornelia Huck wrote: > > > > On Thu, Aug 12 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > > > > > > > > > On 8/10/2021 9:44 AM, Cornelia Huck wrote: > > > > > > On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > > > > > > > > > > > > > This should have been updated during VIRTIO_F_NOTIFICATION_DATA > > > > > > > and VIRTIO_F_NOTIF_CONFIG_DATA standartization. > > > > > > > > > > > > > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> > > > > > > > --- > > > > > > > content.tex | 4 ++-- > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > diff --git a/content.tex b/content.tex index 5c70a3c..e9a32fa > > > > > > > 100644 > > > > > > > --- a/content.tex > > > > > > > +++ b/content.tex > > > > > > > @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B > > > > > > > \begin{description} > > > > > > > \item[0 to 23] Feature bits for the specific device type > > > > > > > -\item[24 to 37] Feature bits reserved for extensions to the queue > > > > > > > and > > > > > > > +\item[24 to 39] Feature bits reserved for extensions to the queue > > > > > > > +and > > > > > > > feature negotiation mechanisms > > > > > > I'm wondering whether we should do s/reserved/used/ here? > > > > > I'm just fixing a bug here. You can take this patch and create > > > > > another one with the above suggestion on top. > > > > > > > > > > I'm ok with your suggestion. > > > > So... any opinions on whether this should get a proper vote? [I won't > > > > be able to handle that in the next weeks. Michael?] > > > > > > Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot. > > > > > > > > > > -\item[38 and above] Feature bits reserved for future extensions. > > > > > > > +\item[40 and above] Feature bits reserved for future extensions. > > > > > > > \end{description} > > > > > > > \begin{note} ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-12-30 14:49 ` Michael S. Tsirkin @ 2021-12-30 14:57 ` Max Gurtovoy 2021-12-30 17:55 ` Michael S. Tsirkin 2021-12-30 18:12 ` Michael S. Tsirkin 0 siblings, 2 replies; 15+ messages in thread From: Max Gurtovoy @ 2021-12-30 14:57 UTC (permalink / raw) To: Michael S. Tsirkin Cc: Cornelia Huck, virtio-comment, stefanha, eperezma, Oren Duer, Parav Pandit On 12/30/2021 4:49 PM, Michael S. Tsirkin wrote: > On Thu, Dec 30, 2021 at 04:30:00PM +0200, Max Gurtovoy wrote: >> On 12/30/2021 4:27 PM, Michael S. Tsirkin wrote: >>> On Thu, Dec 30, 2021 at 02:24:46PM +0000, Max Gurtovoy wrote: >>>> Hi MST/Cornelia, >>>> Can you please update on the status of this patch ? >>>> It's open for few months and I'm wondering if there is something wrong with it ? >>> Hmm. Is there a git issue for this? >> Not that I'm aware of. Who should open it ? > Please do if possible. > Done. Issue #128. >>>> -----Original Message----- >>>> From: Michael S. Tsirkin <mst@redhat.com> >>>> Sent: Monday, August 16, 2021 5:40 PM >>>> To: Cornelia Huck <cohuck@redhat.com> >>>> Cc: Max Gurtovoy <mgurtovoy@nvidia.com>; virtio-comment@lists.oasis-open.org; stefanha@redhat.com; eperezma@redhat.com; Oren Duer <oren@nvidia.com> >>>> Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering >>>> >>>> On Mon, Aug 16, 2021 at 10:48:36AM +0200, Cornelia Huck wrote: >>>>> On Thu, Aug 12 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: >>>>> >>>>>> On 8/10/2021 9:44 AM, Cornelia Huck wrote: >>>>>>> On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: >>>>>>> >>>>>>>> This should have been updated during VIRTIO_F_NOTIFICATION_DATA >>>>>>>> and VIRTIO_F_NOTIF_CONFIG_DATA standartization. >>>>>>>> >>>>>>>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> >>>>>>>> --- >>>>>>>> content.tex | 4 ++-- >>>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>>>> >>>>>>>> diff --git a/content.tex b/content.tex index 5c70a3c..e9a32fa >>>>>>>> 100644 >>>>>>>> --- a/content.tex >>>>>>>> +++ b/content.tex >>>>>>>> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B >>>>>>>> \begin{description} >>>>>>>> \item[0 to 23] Feature bits for the specific device type >>>>>>>> -\item[24 to 37] Feature bits reserved for extensions to the queue >>>>>>>> and >>>>>>>> +\item[24 to 39] Feature bits reserved for extensions to the queue >>>>>>>> +and >>>>>>>> feature negotiation mechanisms >>>>>>> I'm wondering whether we should do s/reserved/used/ here? >>>>>> I'm just fixing a bug here. You can take this patch and create >>>>>> another one with the above suggestion on top. >>>>>> >>>>>> I'm ok with your suggestion. >>>>> So... any opinions on whether this should get a proper vote? [I won't >>>>> be able to handle that in the next weeks. Michael?] >>>> Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot. >>>> >>>>>>>> -\item[38 and above] Feature bits reserved for future extensions. >>>>>>>> +\item[40 and above] Feature bits reserved for future extensions. >>>>>>>> \end{description} >>>>>>>> \begin{note} ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-12-30 14:57 ` Max Gurtovoy @ 2021-12-30 17:55 ` Michael S. Tsirkin 2021-12-30 18:12 ` Michael S. Tsirkin 1 sibling, 0 replies; 15+ messages in thread From: Michael S. Tsirkin @ 2021-12-30 17:55 UTC (permalink / raw) To: Max Gurtovoy Cc: Cornelia Huck, virtio-comment, stefanha, eperezma, Oren Duer, Parav Pandit On Thu, Dec 30, 2021 at 04:57:57PM +0200, Max Gurtovoy wrote: > > On 12/30/2021 4:49 PM, Michael S. Tsirkin wrote: > > On Thu, Dec 30, 2021 at 04:30:00PM +0200, Max Gurtovoy wrote: > > > On 12/30/2021 4:27 PM, Michael S. Tsirkin wrote: > > > > On Thu, Dec 30, 2021 at 02:24:46PM +0000, Max Gurtovoy wrote: > > > > > Hi MST/Cornelia, > > > > > Can you please update on the status of this patch ? > > > > > It's open for few months and I'm wondering if there is something wrong with it ? > > > > Hmm. Is there a git issue for this? > > > Not that I'm aware of. Who should open it ? > > Please do if possible. > > > Done. > > Issue #128. Thanks and now you follow https://github.com/oasis-tcs/virtio-spec/blob/master/README.md#use-of-github-issues > > > > > -----Original Message----- > > > > > From: Michael S. Tsirkin <mst@redhat.com> > > > > > Sent: Monday, August 16, 2021 5:40 PM > > > > > To: Cornelia Huck <cohuck@redhat.com> > > > > > Cc: Max Gurtovoy <mgurtovoy@nvidia.com>; virtio-comment@lists.oasis-open.org; stefanha@redhat.com; eperezma@redhat.com; Oren Duer <oren@nvidia.com> > > > > > Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering > > > > > > > > > > On Mon, Aug 16, 2021 at 10:48:36AM +0200, Cornelia Huck wrote: > > > > > > On Thu, Aug 12 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > > > > > > > > > > > > > On 8/10/2021 9:44 AM, Cornelia Huck wrote: > > > > > > > > On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > > > > > > > > > > > > > > > > > This should have been updated during VIRTIO_F_NOTIFICATION_DATA > > > > > > > > > and VIRTIO_F_NOTIF_CONFIG_DATA standartization. > > > > > > > > > > > > > > > > > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> > > > > > > > > > --- > > > > > > > > > content.tex | 4 ++-- > > > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > diff --git a/content.tex b/content.tex index 5c70a3c..e9a32fa > > > > > > > > > 100644 > > > > > > > > > --- a/content.tex > > > > > > > > > +++ b/content.tex > > > > > > > > > @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B > > > > > > > > > \begin{description} > > > > > > > > > \item[0 to 23] Feature bits for the specific device type > > > > > > > > > -\item[24 to 37] Feature bits reserved for extensions to the queue > > > > > > > > > and > > > > > > > > > +\item[24 to 39] Feature bits reserved for extensions to the queue > > > > > > > > > +and > > > > > > > > > feature negotiation mechanisms > > > > > > > > I'm wondering whether we should do s/reserved/used/ here? > > > > > > > I'm just fixing a bug here. You can take this patch and create > > > > > > > another one with the above suggestion on top. > > > > > > > > > > > > > > I'm ok with your suggestion. > > > > > > So... any opinions on whether this should get a proper vote? [I won't > > > > > > be able to handle that in the next weeks. Michael?] > > > > > Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot. > > > > > > > > > > > > > > -\item[38 and above] Feature bits reserved for future extensions. > > > > > > > > > +\item[40 and above] Feature bits reserved for future extensions. > > > > > > > > > \end{description} > > > > > > > > > \begin{note} ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-12-30 14:57 ` Max Gurtovoy 2021-12-30 17:55 ` Michael S. Tsirkin @ 2021-12-30 18:12 ` Michael S. Tsirkin 1 sibling, 0 replies; 15+ messages in thread From: Michael S. Tsirkin @ 2021-12-30 18:12 UTC (permalink / raw) To: Max Gurtovoy Cc: Cornelia Huck, virtio-comment, stefanha, eperezma, Oren Duer, Parav Pandit On Thu, Dec 30, 2021 at 04:57:57PM +0200, Max Gurtovoy wrote: > > On 12/30/2021 4:49 PM, Michael S. Tsirkin wrote: > > On Thu, Dec 30, 2021 at 04:30:00PM +0200, Max Gurtovoy wrote: > > > On 12/30/2021 4:27 PM, Michael S. Tsirkin wrote: > > > > On Thu, Dec 30, 2021 at 02:24:46PM +0000, Max Gurtovoy wrote: > > > > > Hi MST/Cornelia, > > > > > Can you please update on the status of this patch ? > > > > > It's open for few months and I'm wondering if there is something wrong with it ? > > > > Hmm. Is there a git issue for this? > > > Not that I'm aware of. Who should open it ? > > Please do if possible. > > > Done. > > Issue #128. Note that at the moment the issue itself is empty, the only content is in the comments. > > > > > -----Original Message----- > > > > > From: Michael S. Tsirkin <mst@redhat.com> > > > > > Sent: Monday, August 16, 2021 5:40 PM > > > > > To: Cornelia Huck <cohuck@redhat.com> > > > > > Cc: Max Gurtovoy <mgurtovoy@nvidia.com>; virtio-comment@lists.oasis-open.org; stefanha@redhat.com; eperezma@redhat.com; Oren Duer <oren@nvidia.com> > > > > > Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering > > > > > > > > > > On Mon, Aug 16, 2021 at 10:48:36AM +0200, Cornelia Huck wrote: > > > > > > On Thu, Aug 12 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > > > > > > > > > > > > > On 8/10/2021 9:44 AM, Cornelia Huck wrote: > > > > > > > > On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > > > > > > > > > > > > > > > > > This should have been updated during VIRTIO_F_NOTIFICATION_DATA > > > > > > > > > and VIRTIO_F_NOTIF_CONFIG_DATA standartization. > > > > > > > > > > > > > > > > > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> > > > > > > > > > --- > > > > > > > > > content.tex | 4 ++-- > > > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > diff --git a/content.tex b/content.tex index 5c70a3c..e9a32fa > > > > > > > > > 100644 > > > > > > > > > --- a/content.tex > > > > > > > > > +++ b/content.tex > > > > > > > > > @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B > > > > > > > > > \begin{description} > > > > > > > > > \item[0 to 23] Feature bits for the specific device type > > > > > > > > > -\item[24 to 37] Feature bits reserved for extensions to the queue > > > > > > > > > and > > > > > > > > > +\item[24 to 39] Feature bits reserved for extensions to the queue > > > > > > > > > +and > > > > > > > > > feature negotiation mechanisms > > > > > > > > I'm wondering whether we should do s/reserved/used/ here? > > > > > > > I'm just fixing a bug here. You can take this patch and create > > > > > > > another one with the above suggestion on top. > > > > > > > > > > > > > > I'm ok with your suggestion. > > > > > > So... any opinions on whether this should get a proper vote? [I won't > > > > > > be able to handle that in the next weeks. Michael?] > > > > > Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot. > > > > > > > > > > > > > > -\item[38 and above] Feature bits reserved for future extensions. > > > > > > > > > +\item[40 and above] Feature bits reserved for future extensions. > > > > > > > > > \end{description} > > > > > > > > > \begin{note} ^ permalink raw reply [flat|nested] 15+ messages in thread
* [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2021-08-01 12:45 [PATCH 1/1] Fix reserved Feature bits numbering Max Gurtovoy 2021-08-02 14:07 ` Stefan Hajnoczi 2021-08-10 6:44 ` [virtio-comment] " Cornelia Huck @ 2022-01-03 11:13 ` Cornelia Huck 2022-01-03 16:58 ` Max Gurtovoy 2 siblings, 1 reply; 15+ messages in thread From: Cornelia Huck @ 2022-01-03 11:13 UTC (permalink / raw) To: Max Gurtovoy, virtio-comment, mst; +Cc: stefanha, eperezma, oren, Max Gurtovoy On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > This should have been updated during VIRTIO_F_NOTIFICATION_DATA and > VIRTIO_F_NOTIF_CONFIG_DATA standartization. > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> > --- > content.tex | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/content.tex b/content.tex > index 5c70a3c..e9a32fa 100644 > --- a/content.tex > +++ b/content.tex > @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B > \begin{description} > \item[0 to 23] Feature bits for the specific device type > > -\item[24 to 37] Feature bits reserved for extensions to the queue and > +\item[24 to 39] Feature bits reserved for extensions to the queue and > feature negotiation mechanisms > > -\item[38 and above] Feature bits reserved for future extensions. > +\item[40 and above] Feature bits reserved for future extensions. > \end{description} > > \begin{note} Sigh, I just noticed that we also missed to adjust this for the new VIRTIO_F_RING_RESET feature bit :( Obviously not your fault, but could you please post an updated version for us to vote on? This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ ^ permalink raw reply [flat|nested] 15+ messages in thread
* [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering 2022-01-03 11:13 ` Cornelia Huck @ 2022-01-03 16:58 ` Max Gurtovoy 0 siblings, 0 replies; 15+ messages in thread From: Max Gurtovoy @ 2022-01-03 16:58 UTC (permalink / raw) To: Cornelia Huck, virtio-comment, mst; +Cc: stefanha, eperezma, oren On 1/3/2022 1:13 PM, Cornelia Huck wrote: > On Sun, Aug 01 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote: > >> This should have been updated during VIRTIO_F_NOTIFICATION_DATA and >> VIRTIO_F_NOTIF_CONFIG_DATA standartization. >> >> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> >> --- >> content.tex | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/content.tex b/content.tex >> index 5c70a3c..e9a32fa 100644 >> --- a/content.tex >> +++ b/content.tex >> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B >> \begin{description} >> \item[0 to 23] Feature bits for the specific device type >> >> -\item[24 to 37] Feature bits reserved for extensions to the queue and >> +\item[24 to 39] Feature bits reserved for extensions to the queue and >> feature negotiation mechanisms >> >> -\item[38 and above] Feature bits reserved for future extensions. >> +\item[40 and above] Feature bits reserved for future extensions. >> \end{description} >> >> \begin{note} > Sigh, I just noticed that we also missed to adjust this for the new > VIRTIO_F_RING_RESET feature bit :( > > Obviously not your fault, but could you please post an updated version > for us to vote on? Yes sure. Sending v2. This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-01-03 16:59 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-08-01 12:45 [PATCH 1/1] Fix reserved Feature bits numbering Max Gurtovoy 2021-08-02 14:07 ` Stefan Hajnoczi 2021-08-10 6:44 ` [virtio-comment] " Cornelia Huck 2021-08-12 10:35 ` Max Gurtovoy 2021-08-16 8:48 ` Cornelia Huck 2021-08-16 14:40 ` Michael S. Tsirkin 2021-12-30 14:24 ` Max Gurtovoy 2021-12-30 14:27 ` Michael S. Tsirkin 2021-12-30 14:30 ` Max Gurtovoy 2021-12-30 14:49 ` Michael S. Tsirkin 2021-12-30 14:57 ` Max Gurtovoy 2021-12-30 17:55 ` Michael S. Tsirkin 2021-12-30 18:12 ` Michael S. Tsirkin 2022-01-03 11:13 ` Cornelia Huck 2022-01-03 16:58 ` Max Gurtovoy
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.