audio-graph-port.yaml doesn't work ?

audio-graph-port.yaml doesn't work ?

[Kuninori Morimoto]

Hi Rob

I noticed that it seems "$ref: audio-graph-port.yaml#" is not working.
For example, below is under "renesas,rcar.yaml" control which
is using "$ref: audio-graph-port.yaml#" for ports/port and endpoint.

"audio-graph-port.yaml" has "endpoint" properties,
and below are not allowed by it.
But there is no warning/error by

	make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sound/renesas,rsnd.yaml 

Am I misunderstanding ?

--------
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 1f177af3eb9d..f40ec421b45a 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -410,8 +410,8 @@ rsnd_port0: port@0 {
 			rsnd_for_ak4613: endpoint {
 				remote-endpoint = <&ak4613_endpoint>;
 
-				dai-format = "left_j";
+				dai-format = "foo-bar";
-				bitclock-master = <&rsnd_for_ak4613>;
+				bitclock-master = <1>;
 				frame-master = <&rsnd_for_ak4613>;
 
 				playback = <&ssi0>, <&src0>, <&dvc0>;
------

Thank you for your help !!

Best regards
---
Kuninori Morimoto

Re: audio-graph-port.yaml doesn't work ?

[Rob Herring]

On Mon, May 24, 2021 at 11:50 PM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
>
> Hi Rob
>
> I noticed that it seems "$ref: audio-graph-port.yaml#" is not working.
> For example, below is under "renesas,rcar.yaml" control which
> is using "$ref: audio-graph-port.yaml#" for ports/port and endpoint.
>
> "audio-graph-port.yaml" has "endpoint" properties,
> and below are not allowed by it.
> But there is no warning/error by
>
>         make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
>
> Am I misunderstanding ?

Sorry, I missed this. Independently, with some meta-schema
improvements I think I found the issue:

  ports:
    $ref: /schemas/graph.yaml#/properties/ports
    properties:
      port(@[0-9a-f]+)?:
        $ref: audio-graph-port.yaml#
        unevaluatedProperties: false

The problem is you have a regex under 'properties' so it's treated as
a fixed string.

Will send out a patch shortly.

Rob