* [Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR
@ 2021-01-08 17:53 Fabrice Fontaine
2021-01-09 15:08 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2021-01-08 17:53 UTC (permalink / raw)
To: buildroot
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/openvpn/openvpn.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/openvpn/openvpn.mk b/package/openvpn/openvpn.mk
index 53f332534d..913235679a 100644
--- a/package/openvpn/openvpn.mk
+++ b/package/openvpn/openvpn.mk
@@ -10,6 +10,7 @@ OPENVPN_SITE = http://swupdate.openvpn.net/community/releases
OPENVPN_DEPENDENCIES = host-pkgconf
OPENVPN_LICENSE = GPL-2.0
OPENVPN_LICENSE_FILES = COPYRIGHT.GPL
+OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)
OPENVPN_CONF_OPTS = \
--disable-unit-tests \
$(if $(BR2_STATIC_LIBS),--disable-plugins)
--
2.29.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR
2021-01-08 17:53 [Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR Fabrice Fontaine
@ 2021-01-09 15:08 ` Peter Korsgaard
2021-01-09 20:14 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2021-01-09 15:08 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/openvpn/openvpn.mk | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/package/openvpn/openvpn.mk b/package/openvpn/openvpn.mk
> index 53f332534d..913235679a 100644
> --- a/package/openvpn/openvpn.mk
> +++ b/package/openvpn/openvpn.mk
> @@ -10,6 +10,7 @@ OPENVPN_SITE = http://swupdate.openvpn.net/community/releases
> OPENVPN_DEPENDENCIES = host-pkgconf
> OPENVPN_LICENSE = GPL-2.0
> OPENVPN_LICENSE_FILES = COPYRIGHT.GPL
> +OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)
I am not sure why we do this obfuscation with the _NAME variable instead
of just "openvpn" - But ok, a bunch of other packages do so as well.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR
2021-01-09 15:08 ` Peter Korsgaard
@ 2021-01-09 20:14 ` Thomas Petazzoni
2021-01-09 21:18 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2021-01-09 20:14 UTC (permalink / raw)
To: buildroot
On Sat, 09 Jan 2021 16:08:24 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:
> > +OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)
>
> I am not sure why we do this obfuscation with the _NAME variable instead
> of just "openvpn" - But ok, a bunch of other packages do so as well.
Yes, it was done like this in the original patch from Matt, and I kept
it as-is, but I also wasn't too sure about it. But since nobody
complained when I posted the patch, I applied it as-is.
I definitely wouldn't oppose to changing this to not use the
<pkg>_NAME variable, as it find this indirection to not be very useful.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR
2021-01-09 20:14 ` Thomas Petazzoni
@ 2021-01-09 21:18 ` Peter Korsgaard
2021-01-09 21:54 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2021-01-09 21:18 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> On Sat, 09 Jan 2021 16:08:24 +0100
> Peter Korsgaard <peter@korsgaard.com> wrote:
>> > +OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)
>>
>> I am not sure why we do this obfuscation with the _NAME variable instead
>> of just "openvpn" - But ok, a bunch of other packages do so as well.
> Yes, it was done like this in the original patch from Matt, and I kept
> it as-is, but I also wasn't too sure about it. But since nobody
> complained when I posted the patch, I applied it as-is.
> I definitely wouldn't oppose to changing this to not use the
> <pkg>_NAME variable, as it find this indirection to not be very useful.
Ok, good. It may make sense to default _CPE_ID_VENDOR to $($(PKG)_NAME),
which is perhaps where this comes from?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR
2021-01-09 21:18 ` Peter Korsgaard
@ 2021-01-09 21:54 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2021-01-09 21:54 UTC (permalink / raw)
To: buildroot
On Sat, 09 Jan 2021 22:18:04 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:
> Ok, good. It may make sense to default _CPE_ID_VENDOR to $($(PKG)_NAME),
> which is perhaps where this comes from?
CPE_ID_VENDOR already has a default, which is:
$(2)_CPE_ID_VENDOR = $$($(2)_RAWNAME)_project
Indeed, for a large number of packages, the CPE vendor ID follows that
<foo>_project scheme.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-09 21:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 17:53 [Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR Fabrice Fontaine
2021-01-09 15:08 ` Peter Korsgaard
2021-01-09 20:14 ` Thomas Petazzoni
2021-01-09 21:18 ` Peter Korsgaard
2021-01-09 21:54 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.