From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Sameer Pujar <spujar@nvidia.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
<alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: ASoC: audio-graph-card: switch to yaml base Documentation
Date: 29 Oct 2020 13:48:23 +0900 [thread overview]
Message-ID: <874kmdej4z.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <53ecc751-b0b2-2bc2-75f4-88b56b22b6c6@nvidia.com>
Hi Sameer
Thank you for your feedback
> > + endpoint:
> > + type: object
> > + properties:
> > + remote-endpoint:
> > + maxItems: 1
> > + mclk-fs:
> > + description: |
> > + Multiplication factor between stream rate and codec mclk.
> > + When defined, mclk-fs property defined in dai-link sub nodes are ignored.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + frame-inversion:
> > + description: dai-link uses frame clock inversion
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + bitclock-inversion:
> > + description: dai-link uses bit clock inversion
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + frame-master:
> > + description: Indicates dai-link frame master.
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + maxItems: 1
> > + bitclock-master:
> > + description: Indicates dai-link bit clock master
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + maxItems: 1
> > + dai-format:
> > + description: audio format.
> > + items:
> > + enum:
> > + - i2s
> > + - right_j
> > + - left_j
> > + - dsp_a
> > + - dsp_b
> > + - ac97
> > + - pdm
> > + - msb
> > + - lsb
> > + convert-rate:
> > + description: CPU to Codec rate convert.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + convert-channels:
> > + description: CPU to Codec rate channels.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + required:
> > + - remote-endpoint
> > +
>
> Sorry this point was not clear to me. Can 'endpoint' exist without
> port/ports? Should this rather be moved inside of port?
Ahh, yes.
You had been indicated it in previous mail.
I will try to move under port in v5
Thank you for your help !!
Best regards
---
Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Sameer Pujar <spujar@nvidia.com>
Cc: devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v4 1/3] dt-bindings: ASoC: audio-graph-card: switch to yaml base Documentation
Date: 29 Oct 2020 13:48:23 +0900 [thread overview]
Message-ID: <874kmdej4z.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <53ecc751-b0b2-2bc2-75f4-88b56b22b6c6@nvidia.com>
Hi Sameer
Thank you for your feedback
> > + endpoint:
> > + type: object
> > + properties:
> > + remote-endpoint:
> > + maxItems: 1
> > + mclk-fs:
> > + description: |
> > + Multiplication factor between stream rate and codec mclk.
> > + When defined, mclk-fs property defined in dai-link sub nodes are ignored.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + frame-inversion:
> > + description: dai-link uses frame clock inversion
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + bitclock-inversion:
> > + description: dai-link uses bit clock inversion
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + frame-master:
> > + description: Indicates dai-link frame master.
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + maxItems: 1
> > + bitclock-master:
> > + description: Indicates dai-link bit clock master
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + maxItems: 1
> > + dai-format:
> > + description: audio format.
> > + items:
> > + enum:
> > + - i2s
> > + - right_j
> > + - left_j
> > + - dsp_a
> > + - dsp_b
> > + - ac97
> > + - pdm
> > + - msb
> > + - lsb
> > + convert-rate:
> > + description: CPU to Codec rate convert.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + convert-channels:
> > + description: CPU to Codec rate channels.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + required:
> > + - remote-endpoint
> > +
>
> Sorry this point was not clear to me. Can 'endpoint' exist without
> port/ports? Should this rather be moved inside of port?
Ahh, yes.
You had been indicated it in previous mail.
I will try to move under port in v5
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2020-10-29 7:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 0:04 [PATCH v4 0/3] ASoC: dt-bindings: audio-graph-card: switch to yaml base Documentation Kuninori Morimoto
2020-10-29 0:04 ` Kuninori Morimoto
2020-10-29 0:05 ` [PATCH v4 1/3] dt-bindings: ASoC: " Kuninori Morimoto
2020-10-29 0:05 ` Kuninori Morimoto
2020-10-29 4:36 ` Sameer Pujar
2020-10-29 4:36 ` Sameer Pujar
2020-10-29 4:48 ` Kuninori Morimoto [this message]
2020-10-29 4:48 ` Kuninori Morimoto
2020-10-29 0:05 ` [PATCH v4 2/3] dt-bindings: ASoC: renesas,rsnd: " Kuninori Morimoto
2020-10-29 0:05 ` [PATCH v4 2/3] dt-bindings: ASoC: renesas, rsnd: " Kuninori Morimoto
2020-10-29 0:05 ` [PATCH v4 3/3] dt-bindings: ASoC: renesas,rsnd: Add r8a77961 support Kuninori Morimoto
2020-10-29 0:05 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kmdej4z.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=spujar@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.